Merge pull request #29 from RelationalAI/dg-cjs-fix

CommonJS bundle fix

Author: Denis Gursky

.eslintignore

@@ -1 +1,2 @@
-dist
+dist
+dist-test

.github/workflows/sdk.yaml

@@ -29,3 +29,6 @@ jobs:
 
       - name: Build
         run: npm run build
+
+      - name: Bundle Test
+        run: npm run test:bundle

dist-test/cjs-test.cjs

@@ -0,0 +1,4 @@
+// this is supposed to fail if there's something wrong with the CJS bundle
+const { Client } = require('@relationalai/rai-sdk-javascript');
+
+console.log('SDK Client', Client);

dist-test/esm-test.mjs

@@ -0,0 +1,4 @@
+// this is supposed to fail if there's something wrong with the ESM bundle
+import { Client } from '@relationalai/rai-sdk-javascript';
+
+console.log('SDK Client', Client);

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "@relationalai/rai-sdk-javascript",
   "description": "RelationalAI SDK for JavaScript",
-  "version": "0.5.9",
+  "version": "0.5.10",
   "author": {
     "name": "RelationalAI",
     "url": "https://relational.ai"
@@ -62,7 +62,7 @@
     "build": "rm -rf ./dist && $npm_execpath run build:web && $npm_execpath run build:node && $npm_execpath run build:node:cjs",
     "build:web": "microbundle -i ./index.web.ts -o ./dist/web --target web --alias node-fetch=./fetch.ts --external none --define __RAI_SDK_VERSION__=$npm_package_version",
     "build:node": "microbundle -i ./index.node.ts -o ./dist/node --target node --define __RAI_SDK_VERSION__=$npm_package_version",
-    "build:node:cjs": "$npm_execpath run build:node -- --format cjs --alias lodash-es=lodash --generateTypes false",
+    "build:node:cjs": "$npm_execpath run build:node -- --format cjs --alias lodash-es=lodash,node-fetch=node-fetch-commonjs --generateTypes false",
     "dev:web": "$npm_execpath run build:web -- -w",
     "dev:node": "$npm_execpath run build:node -- -w",
     "format": "prettier --write ./src --loglevel warn",
@@ -71,6 +71,7 @@
     "fix": "eslint --cache --fix . --ext js --ext ts --ext tsx",
     "test": "jest",
     "test:debug": "npx --node-arg=--inspect jest --runInBand --testTimeout=60000 --verbose --watch",
+    "test:bundle": "node ./dist-test/esm-test.mjs && node ./dist-test/cjs-test.cjs",
     "example": "node --es-module-specifier-resolution=node --loader ts-node/esm"
   },
   "devDependencies": {
@@ -99,10 +100,10 @@
   "dependencies": {
     "apache-arrow": "8.0.0",
     "config-ini-parser": "1.5.9",
-    "cross-fetch": "3.1.5",
     "lodash": "4.17.21",
     "lodash-es": "4.17.21",
-    "node-fetch": "3.2.4",
+    "node-fetch": "3.1.1",
+    "node-fetch-commonjs": "3.1.1",
     "query-string": "7.1.0"
   }
 }

package.json

@@ -63,6 +63,12 @@ export async function request<T>(url: string, options: RequestOptions = {}) {
     body: JSON.stringify(options.body),
     headers: addDefaultHeaders(options.headers, url),
   };
+
+  if (typeof window === 'undefined') {
+    // See: https://github.com/node-fetch/node-fetch#custom-highwatermark
+    (opts as any).highWaterMark = 1024 * 1024;
+  }
+
   const fullUrl =
     options.query && Object.keys(options.query).length > 0
       ? `${url}?${stringify(options.query, { arrayFormat: 'none' })}`