#5 Implement user input checks

- change percentage data type from integer to float
- allow decimal values in percentage

Author: OndrejVane

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/BusinessAsUsualDetectorImpl.java

@@ -23,8 +23,8 @@ public class BusinessAsUsualDetectorImpl implements AntiPatternDetector {
                 put("divisionOfIterationsWithRetrospective", new Configuration<Percentage>("divisionOfIterationsWithRetrospective",
                         "Division of iterations with retrospective",
                         "Minimum percentage of the total number of iterations with a retrospective (0,100)",
-                        "Percentage must be between 0 and 100",
-                        new Percentage(66)));
+                        "Percentage must be float number between 0 and 100",
+                        new Percentage(66.66f)));
                 put("searchSubstringsWithRetrospective", new Configuration<String>("searchSubstringsWithRetrospective",
                         "Search substrings with retrospective",
                         "Substring that will be search in wikipages and activities",

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/LongOrNonExistentFeedbackLoopsDetectorImpl.java

@@ -28,9 +28,9 @@ public class LongOrNonExistentFeedbackLoopsDetectorImpl implements AntiPatternDe
             new HashMap<>() {{
                 put("divisionOfIterationsWithFeedbackLoop", new Configuration<Percentage>("divisionOfIterationsWithFeedbackLoop",
                         "Division of iterations with feedback loop",
-                        "Minimum percentage of the total number of iterations with feedback loop (0,1)",
-                        "Percentage must be between 0 and 100",
-                        new Percentage(50)));
+                        "Minimum percentage of the total number of iterations with feedback loop (0,100)",
+                        "Percentage must be float number between 0 and 100",
+                        new Percentage(50.00f)));
                 put("maxGapBetweenFeedbackLoopRate", new Configuration<PositiveFloat>("maxGapBetweenFeedbackLoopRate",
                         "Maximum gap between feedback loop rate",
                         "Value that multiplies average iteration length for given project. Result" +

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/model/types/Percentage.java

@@ -5,22 +5,22 @@ public class Percentage extends Number {
     public static final float MAX_VALUE = 100;
     public static final float MIN_VALUE = 0;
 
-    private final int value;
+    private final float value;
 
-    public Percentage(int value) throws NumberFormatException {
+    public Percentage(float value) throws NumberFormatException {
         if (value > MAX_VALUE || value < MIN_VALUE) {
             throw new NumberFormatException("Percentage should be between 0 and 100");
         }
         this.value = value;
     }
 
     public static Percentage parsePercentage(String value) {
-        return new Percentage(Integer.parseInt(value));
+        return new Percentage(Float.parseFloat(value));
     }
 
     @Override
     public int intValue() {
-        return this.value;
+        return (int) this.value;
     }
 
     @Override
@@ -44,6 +44,6 @@ public String toString() {
     }
 
     public float getValue() {
-        return (float) value/100;
+        return value /100;
     }
 }