fix: resolve clippy warnings

- Add TcpConnectionMap type alias to fix type_complexity warning
- Add #[allow(dead_code)] to DnsProvider trait for unused methods
- Add #[allow(unused_assignments)] to diagnostic structs for miette derives

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: RemiKalbe

crates/siphon-e2e/src/test_client.rs

@@ -19,6 +19,9 @@ use siphon_protocol::{ClientMessage, ServerMessage, TunnelCodec, TunnelType};
 
 use crate::harness::TestServer;
 
+/// Type alias for TCP connection registry to avoid clippy::type_complexity
+type TcpConnectionMap = Arc<RwLock<HashMap<u64, mpsc::Sender<Vec<u8>>>>>;
+
 /// A test tunnel client
 pub struct TestClient {
     /// Handle to the spawned client task
@@ -151,8 +154,7 @@ async fn run_client(
     let (shutdown_tx, mut shutdown_rx) = mpsc::channel::<()>(1);
 
     // TCP connection state - maps stream_id to writer channel
-    let tcp_connections: Arc<RwLock<HashMap<u64, mpsc::Sender<Vec<u8>>>>> =
-        Arc::new(RwLock::new(HashMap::new()));
+    let tcp_connections: TcpConnectionMap = Arc::new(RwLock::new(HashMap::new()));
 
     // Spawn the main client loop
     let tcp_conns = tcp_connections.clone();
@@ -237,7 +239,7 @@ async fn handle_message(
     http_client: &reqwest::Client,
     local_addr: &str,
     response_tx: &mpsc::Sender<ClientMessage>,
-    tcp_connections: &Arc<RwLock<HashMap<u64, mpsc::Sender<Vec<u8>>>>>,
+    tcp_connections: &TcpConnectionMap,
 ) {
     match msg {
         ServerMessage::HttpRequest {

crates/siphon-server/src/dns_provider.rs

@@ -31,6 +31,7 @@ pub enum DnsError {
 /// This abstraction allows the server to work with different DNS backends,
 /// such as Cloudflare for production or a mock implementation for testing.
 #[async_trait]
+#[allow(dead_code)]
 pub trait DnsProvider: Send + Sync {
     /// Create a DNS record for a subdomain
     ///

crates/siphon/src/main.rs

@@ -421,14 +421,12 @@ async fn run_tui_mode(
     severity(error),
     url("https://github.com/remikalbe/siphon#certificate-setup")
 )]
+#[allow(unused_assignments)]
 struct SanMismatchDiagnostic {
-    #[allow(unused)]
     expected: String,
-    #[allow(unused)]
     presented: Vec<String>,
 
     #[help]
-    #[allow(unused)]
     help: String,
 }
 
@@ -455,31 +453,30 @@ impl std::error::Error for SanMismatchDiagnostic {}
 #[derive(Debug, miette::Diagnostic, thiserror::Error)]
 #[error("Certificate has expired")]
 #[diagnostic(code(siphon::tls::expired), severity(error))]
+#[allow(unused_assignments)]
 struct ExpiredCertDiagnostic {
     #[help]
-    #[allow(unused)]
     help: String,
 }
 
 /// Unknown issuer diagnostic
 #[derive(Debug, miette::Diagnostic, thiserror::Error)]
 #[error("Certificate issuer not trusted")]
 #[diagnostic(code(siphon::tls::unknown_issuer), severity(error))]
+#[allow(unused_assignments)]
 struct UnknownIssuerDiagnostic {
     #[help]
-    #[allow(unused)]
     help: String,
 }
 
 /// Generic TLS diagnostic for other errors
 #[derive(Debug, miette::Diagnostic, thiserror::Error)]
 #[error("{message}")]
 #[diagnostic(code(siphon::tls::error), severity(error))]
+#[allow(unused_assignments)]
 struct GenericTlsDiagnostic {
-    #[allow(unused)]
     message: String,
     #[help]
-    #[allow(unused)]
     help: String,
 }