Skip to content

Commit 8ca9375

Browse files
committed
addressed comments
1 parent 9e9e0e4 commit 8ca9375

File tree

7 files changed

+27
-12
lines changed

7 files changed

+27
-12
lines changed

.github/workflows/python-compatibility.yml

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# Tests Python package build compatibility across:
44
# - Operating Systems: Ubuntu, macOS, Windows
5-
# - Python Versions: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13
5+
# - Python Versions: 3.9, 3.10, 3.11, 3.12, 3.13
66
#
77
# Validates that the package can be built and installed correctly
88
# on all supported platforms and Python versions.
@@ -16,8 +16,7 @@ concurrency:
1616
on:
1717
workflow_dispatch:
1818
push:
19-
branches:
20-
- resilv/py313
19+
pull_request:
2120

2221
env:
2322
# Change this to invalidate existing cache.
@@ -36,7 +35,7 @@ jobs:
3635
fail-fast: false
3736
matrix:
3837
os: [ubuntu-latest, macos-latest, windows-latest]
39-
python: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
38+
python: ['3.9', '3.10', '3.11', '3.12', '3.13']
4039
task:
4140
- name: Build
4241
run: |
@@ -65,6 +64,26 @@ jobs:
6564
run: |
6665
echo "PYTHON_VERSION=$(python --version)" >> $GITHUB_ENV
6766
67+
- name: Test dependency wheels availability - Unix/Linux/macOS
68+
if: runner.os != 'Windows'
69+
run: |
70+
python -m venv .venv-deps-test
71+
. .venv-deps-test/bin/activate
72+
pip install --only-binary=:all: -r requirements.txt
73+
deactivate
74+
rm -rf .venv-deps-test
75+
shell: bash
76+
77+
- name: Test dependency wheels availability - Windows
78+
if: runner.os == 'Windows'
79+
run: |
80+
python -m venv .venv-deps-test
81+
.venv-deps-test\Scripts\Activate.ps1
82+
pip install --only-binary=:all: -r requirements.txt
83+
deactivate
84+
Remove-Item -Recurse -Force .venv-deps-test
85+
shell: pwsh
86+
6887
- name: Setup virtual environment - Unix/Linux/macOS
6988
if: runner.os != 'Windows'
7089
run: |

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ After clone you can add `upstream` for every repos in your local clone by using
2121
### 2 Setup python
2222

2323
#### 2.1 Install python
24-
Please install python with version >= 3.8 and <= 3.13 in your local machine.
24+
Please install python with version >= 3.9 and <= 3.13 in your local machine.
2525

2626
- For windows: You can download and run full installer from [Python Download](https://www.python.org/downloads/).
2727
- For linux: You can install python from Package Manager or build a stable relase from source code
2828

29-
Check the version of python, make use it's not less than 3.8.
29+
Check the version of python, make use it's not less than 3.9.
3030
- For windows:
3131
You can run:
3232
```PowerShell

docs/pages/usage/setup_and_run.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ weight: 100
1717

1818
### Install python
1919

20-
This tool is compatible with python versions >=3.8 and <=3.13. You can use an existing python or install a new one by the following ways:
20+
This tool is compatible with python versions >=3.9 and <=3.13. You can use an existing python or install a new one by the following ways:
2121

2222
- For Windows users: You can download and run full installer from [Python Download](https://www.python.org/downloads/).
2323
- For Linux users: You can install python from Package Manager or build a stable release from source code

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ def fix_url_dependencies(req: str) -> str:
5050
"Environment :: Console",
5151
"License :: OSI Approved :: MIT License",
5252
"Natural Language :: English",
53-
"Programming Language :: Python :: 3.8",
5453
"Programming Language :: Python :: 3.9",
5554
"Programming Language :: Python :: 3.10",
5655
"Programming Language :: Python :: 3.11",
@@ -71,7 +70,7 @@ def fix_url_dependencies(req: str) -> str:
7170
),
7271
include_package_data=True,
7372
install_requires=read_requirements("requirements.txt"),
74-
python_requires=">=3.8",
73+
python_requires=">=3.9",
7574
entry_points={
7675
"console_scripts": ["aaz-dev=aaz_dev.app.main:main"]
7776
},

src/aaz_dev/cli/templates/extension/setup.py.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ CLASSIFIERS = [
1717
'Intended Audience :: System Administrators',
1818
'Programming Language :: Python',
1919
'Programming Language :: Python :: 3',
20-
'Programming Language :: Python :: 3.8',
2120
'Programming Language :: Python :: 3.9',
2221
'Programming Language :: Python :: 3.10',
2322
'Programming Language :: Python :: 3.11',

src/aaz_dev/cli/tests/extension_tests/output/az-firewall/setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
'Intended Audience :: System Administrators',
2121
'Programming Language :: Python',
2222
'Programming Language :: Python :: 3',
23-
'Programming Language :: Python :: 3.8',
2423
'Programming Language :: Python :: 3.9',
2524
'Programming Language :: Python :: 3.10',
2625
'Programming Language :: Python :: 3.11',

src/aaz_dev/cli/tests/extension_tests/output/new-extension/setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
'Intended Audience :: System Administrators',
2121
'Programming Language :: Python',
2222
'Programming Language :: Python :: 3',
23-
'Programming Language :: Python :: 3.8',
2423
'Programming Language :: Python :: 3.9',
2524
'Programming Language :: Python :: 3.10',
2625
'Programming Language :: Python :: 3.11',

0 commit comments

Comments
 (0)