[Bug]

[Caleidocane]

Unity Version

6.1

AVPro DeckLink edition

Full

AVPro Decklink Version

1.9.9

Desktop Video version

14.5

Which Windows version(s) are you using?

Windows 10

Which graphics API(s) are you using?

Direct3D 12

Decklink device model

Mini recorder 4k

Cables used

HDMI

Video mode

3840x2160 @30 RGB 24bit

The issue

using the 1st example just to check the input i've got this error in console:
d3d12 error: Creating a default shader resource view with non compatible format (dxgi-fmt=0 for a resource that uses dxgi-fmt=30)
Itried to open another software like blackmagic media express and it is working well, it's showing the correct input. Is the error related to the 6.1 unity version?

Log output

[Caleidocane]

Switching to D3D11 is solving the issue at the moment, is it planned an update to D3D12? Because I need to works with a HDR colorspace that seems not supported well in AVPRO 3 and d3d11

[Chris-RH]

We do support d3d12. It might be an issue with that Unity version. Our Decklink dev is out of office today, but should be able to have a look tomorrow.

[RichRH]

Hi @Caleidocane,

I've managed to reproduce this issue and it's due to Unity supporting a limited number of texture formats when wrapping the native textures we produce. There was a workaround in place for this but it seems to no longer function.

I might have found a new workaround which I'll continue investigating, and if all good will hopefully get into a new build next week.

Cheers,

[bloomav]

Hi all,

It looks like I am getting the same error receiving an HDR signal with d3d12.

I can also confirm that recording clips with embedded HDR with BMD Media Express works and I'm seeing it with d3d11 in Unity 6.1 without the full HDR range.

I'm happy to test any workarounds otherwise I'll keep an eye out for the next update!

Thanks

[RichRH]

Hi @Caleidocane and @bloomav,

Apologies, holiday season around here so proving difficult to get a new build out, but in the meantime you could try the following workaround - in 'FormatConverter.cs' -> 'CreateRawTexture()', replace the current chunk of code below '// Account for potential padding' with:

				// Account for potential padding
#if UNITY_6000_1_OR_NEWER
				GraphicsFormat graphicsFormat = GraphicsFormat.R8G8B8A8_UNorm;
				if (_mode.PixelFormat == DeckLinkPlugin.PixelFormat.YCbCr_10bpp_422)
				{
					textureWidth = ((_mode.Width + 47) / 48) * 32;
					graphicsFormat = GraphicsFormat.A2B10G10R10_UNormPack32;
				}
				else if (_mode.PixelFormat == DeckLinkPlugin.PixelFormat.RGB_10bpp_444)
				{
					textureWidth = ((_mode.Width + 63) / 64) * 64;
					graphicsFormat = GraphicsFormat.R8G8B8A8_UInt;
				}
#else
				TextureFormat textureFormat = TextureFormat.RGBA32;//ARGB32;
				if (_mode.PixelFormat == DeckLinkPlugin.PixelFormat.YCbCr_10bpp_422)
				{
					textureWidth = ((_mode.Width + 47) / 48) * 32;
	#if UNITY_2021_3_OR_NEWER
					// RJT NOTE: It seems the format parameter is mostly ignored, except under Unity 2022(+?)/D3D12, where it appears to create
					// a 'default' SRV for it, but unfortunately there isn't an obvious 'TextureFormat' for our native 'DXGI_FORMAT_R10G10B10A2_UNORM'
					// format and it crashes, so for now forcing it to a format that appears to bypass invalid SRV creation..
					// - Changed from 'ETC_RGB24' to 'RGB24' as per 'https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/1286'
					textureFormat = TextureFormat.RGB24;//DXGI_FORMAT_R10G10B10A2_UNORM;
	#endif
				}
				else if (_mode.PixelFormat == DeckLinkPlugin.PixelFormat.RGB_10bpp_444)
				{
					textureWidth = ((_mode.Width + 63) / 64) * 64;
	#if UNITY_2021_3_OR_NEWER
					textureFormat = TextureFormat.RGB24;//DXGI_FORMAT_R8G8B8A8_UINT;
	#endif
				}
#endif

..and then..

							_eye[i].rawTexture = Texture2D.CreateExternalTexture(textureWidth, textureHeight, textureFormat, false, true, texPtr);

with:

#if UNITY_6000_1_OR_NEWER
							_eye[i].rawTexture = new Texture2D(textureWidth, textureHeight, /*graphicsFormat*/GraphicsFormat.R8G8B8A8_UNorm, (TextureCreationFlags.DontInitializePixels | TextureCreationFlags.DontUploadUponCreate));
							_eye[i].rawTexture.Reinitialize(textureWidth, textureHeight, graphicsFormat, false);
							_eye[i].rawTexture.UpdateExternalTexture(texPtr);
#else
							_eye[i].rawTexture = Texture2D.CreateExternalTexture(textureWidth, textureHeight, textureFormat, false, true, texPtr);
#endif

Hopefully that makes sense and let me know if it helps!

Cheers,