fix: use discriminated union for duration

Author: AlirezaHadjar

README.md

@@ -179,11 +179,9 @@ export function SomeScreen() {
 
 ## Types (inputs)
 
-| Type                  | Values                        |
-| --------------------- | ----------------------------- |
-| `HapticEventType`     | `'transient' \| 'continuous'` |
-| `HapticParameterType` | `'intensity' \| 'sharpness'`  |
-| `HapticCurveType`     | `'intensity' \| 'sharpness'`  |
+| Type                  | Values                       |
+| --------------------- | ---------------------------- |
+| `HapticParameterType` | `'intensity' \| 'sharpness'` |
 
 | `HapticEventParameter` | Type                  |
 | ---------------------- | --------------------- |

src/Ahap.nitro.ts

@@ -2,7 +2,7 @@ import type { HybridObject } from 'react-native-nitro-modules';
 
 export type HapticEventType = 'transient' | 'continuous';
 export type HapticParameterType = 'intensity' | 'sharpness';
-export type HapticCurveType = 'intensity' | 'sharpness';
+
 export type HapticEventParameter = {
   type: HapticParameterType;
   value: number;
@@ -12,21 +12,15 @@ export type HapticCurveControlPoint = {
   value: number;
 };
 
-export type HapticEvent =
-  | {
-      type: 'transient';
-      parameters: HapticEventParameter[];
-      relativeTime: number;
-    }
-  | {
-      type: 'continuous';
-      parameters: HapticEventParameter[];
-      relativeTime: number;
-      duration: number;
-    };
+export type HapticEvent = {
+  type: HapticEventType;
+  parameters: HapticEventParameter[];
+  relativeTime: number;
+  duration?: number; // Optional for transient events
+};
 
 export type HapticCurve = {
-  type: HapticCurveType;
+  type: HapticParameterType;
   controlPoints: HapticCurveControlPoint[];
   relativeTime: number;
 };

src/index.tsx

@@ -1,7 +1,27 @@
 import { useEffect } from 'react';
 import { AppState } from 'react-native';
 import { NitroModules } from 'react-native-nitro-modules';
-import type { Ahap, HapticCurve, HapticEvent } from './Ahap.nitro';
+import type {
+  Ahap,
+  HapticCurve,
+  HapticEventParameter,
+  HapticParameterType,
+} from './Ahap.nitro';
+
+export type TransientHapticEvent = {
+  type: 'transient';
+  parameters: HapticEventParameter[];
+  relativeTime: number;
+};
+
+export type ContinuousHapticEvent = {
+  type: 'continuous';
+  parameters: HapticEventParameter[];
+  relativeTime: number;
+  duration: number;
+};
+
+export type HapticEvent = TransientHapticEvent | ContinuousHapticEvent;
 
 const AhapHybridObject = NitroModules.createHybridObject<Ahap>('Ahap');
 
@@ -93,4 +113,4 @@ export function HapticProvider({ children }: { children: React.ReactNode }) {
 }
 
 export { AhapHybridObject };
-export type { HapticCurve, HapticEvent };
+export type { HapticCurve, HapticEventParameter, HapticParameterType };