Skip to content

Commit d7a413e

Browse files
committed
fix: modified to use path param when purchasing packs
1 parent 585ee2c commit d7a413e

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

src/main/java/com/renzzle/backend/domain/puzzle/training/api/TrainingController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ public ApiResponse<GetPackPurchaseResponse> PurchaseTrainingPack(
119119
@Operation(summary = "Purchase Training Puzzle Answer", description = "Purchase Training Puzzle Answer")
120120
@PostMapping("/puzzle/{puzzleId}/answer")
121121
public ApiResponse<GetTrainingPuzzleAnswerResponse> PurchaseTrainingPuzzleAnswer(
122-
@Valid @RequestBody PurchaseTrainingPuzzleAnswerRequest request,
122+
@PathVariable Long puzzleId,
123123
@AuthenticationPrincipal UserDetailsImpl user
124124
){
125-
GetTrainingPuzzleAnswerResponse response = trainingService.purchaseTrainingPuzzleAnswer(user.getUser(), request);
125+
GetTrainingPuzzleAnswerResponse response = trainingService.purchaseTrainingPuzzleAnswer(user.getUser(), puzzleId);
126126

127127
return ApiUtils.success(response);
128128
}

src/main/java/com/renzzle/backend/domain/puzzle/training/service/TrainingService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,10 @@ public GetPackPurchaseResponse purchaseTrainingPack(UserEntity user, PurchaseTra
293293
}
294294

295295
@Transactional
296-
public GetTrainingPuzzleAnswerResponse purchaseTrainingPuzzleAnswer(UserEntity user, PurchaseTrainingPuzzleAnswerRequest request) {
296+
public GetTrainingPuzzleAnswerResponse purchaseTrainingPuzzleAnswer(UserEntity user, Long puzzleId) {
297297
UserEntity newUser = userRepository.findById(user.getId())
298298
.orElseThrow(() -> new CustomException(ErrorCode.CANNOT_FIND_USER));
299-
TrainingPuzzle puzzle = trainingPuzzleRepository.findById(request.puzzleId())
299+
TrainingPuzzle puzzle = trainingPuzzleRepository.findById(puzzleId)
300300
.orElseThrow(() -> new CustomException(ErrorCode.CANNOT_FIND_TRAINING_PUZZLE));
301301

302302
newUser.purchase(ItemPrice.HINT.getPrice());

src/test/java/com/renzzle/backend/domain/puzzle/rank/service/RankServiceTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,7 @@ void endRankGame_WhenValidSession_ThenDeletesSessionAndReturnsRating() {
313313
RankSessionData session = new RankSessionData();
314314
session.setStarted(true);
315315

316+
when(userRepository.findById(user.getId())).thenReturn(Optional.of(user));
316317
when(valueOperations.get("3")).thenReturn(session);
317318
when(userRepository.findById(user.getId())).thenReturn(Optional.of(user)); // 추가: userRepository Mock
318319
when(latestRankPuzzleRepository.findAllByUser(user))

src/test/java/com/renzzle/backend/domain/puzzle/training/service/TrainingServiceTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -531,10 +531,10 @@ public void testPurchaseTrainingPuzzleAnswer() {
531531
when(userRepository.findById(eq(user.getId())))
532532
.thenReturn(Optional.of(user));
533533

534-
PurchaseTrainingPuzzleAnswerRequest request = new PurchaseTrainingPuzzleAnswerRequest(puzzleId);
534+
// PurchaseTrainingPuzzleAnswerRequest request = new PurchaseTrainingPuzzleAnswerRequest(puzzleId);
535535

536536
// when
537-
GetTrainingPuzzleAnswerResponse response = trainingService.purchaseTrainingPuzzleAnswer(user, request);
537+
GetTrainingPuzzleAnswerResponse response = trainingService.purchaseTrainingPuzzleAnswer(user, puzzleId);
538538

539539
// then
540540
assertThat(response.answer()).isEqualTo("Correct Answer");
@@ -787,7 +787,7 @@ public void testPurchaseTrainingPuzzleAnswer_CannotPurchasePuzzle() {
787787
.deletedAt(Instant.now().plus(1, ChronoUnit.DAYS))
788788
.status(Status.getDefaultStatus())
789789
.build();
790-
PurchaseTrainingPuzzleAnswerRequest request = new PurchaseTrainingPuzzleAnswerRequest(puzzleId);
790+
// PurchaseTrainingPuzzleAnswerRequest request = new PurchaseTrainingPuzzleAnswerRequest(puzzleId);
791791

792792
when(trainingPuzzleRepository.findById(eq(puzzleId)))
793793
.thenReturn(Optional.empty());
@@ -797,7 +797,7 @@ public void testPurchaseTrainingPuzzleAnswer_CannotPurchasePuzzle() {
797797

798798
// when
799799
CustomException exception = assertThrows(CustomException.class, () ->
800-
trainingService.purchaseTrainingPuzzleAnswer(user, request)
800+
trainingService.purchaseTrainingPuzzleAnswer(user, puzzleId)
801801
);
802802

803803
// then

0 commit comments

Comments
 (0)