Fix item meta not being saved when including block state data (ViaVersion#4298)

booky10 · web-flow · commit 037410d40552 · 2024-12-06T18:53:53.000+01:00
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitPickItemProvider.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/providers/BukkitPickItemProvider.java
@@ -79,6 +79,7 @@ public void pickItemFromBlock(final UserConnection connection, final BlockPositi
             final ItemStack item = new ItemStack(block.getBlockData().getPlacementMaterial(), 1);
             if (includeData && item.getItemMeta() instanceof final BlockStateMeta blockStateMeta) {
                 blockStateMeta.setBlockState(block.getState());
+                item.setItemMeta(blockStateMeta);
             }
             return item;
         } else if (block.getType().isItem()) {

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ public void pickItemFromBlock(final UserConnection connection, final BlockPositi`
`79`	`79`	`final ItemStack item = new ItemStack(block.getBlockData().getPlacementMaterial(), 1);`
`80`	`80`	`if (includeData && item.getItemMeta() instanceof final BlockStateMeta blockStateMeta) {`
`81`	`81`	`blockStateMeta.setBlockState(block.getState());`
	`82`	`+ item.setItemMeta(blockStateMeta);`
`82`	`83`	`}`
`83`	`84`	`return item;`
`84`	`85`	`} else if (block.getType().isItem()) {`