Check if the channel is open in BukkitEncodeHandler

kennytv · kennytv · commit 8edad673948a · 2024-03-02T20:13:58.000+01:00
diff --git a/bukkit/src/main/java/com/viaversion/viaversion/bukkit/handlers/BukkitEncodeHandler.java b/bukkit/src/main/java/com/viaversion/viaversion/bukkit/handlers/BukkitEncodeHandler.java
@@ -43,7 +43,8 @@ public BukkitEncodeHandler(final UserConnection connection) {
 
     @Override
     protected void encode(final ChannelHandlerContext ctx, final ByteBuf bytebuf, final List<Object> out) throws Exception {
-        if (!connection.checkClientboundPacket()) {
+        // Check if the channel is open as older servers might start sending packets through the pipeline despite the channel being closed
+        if (!connection.checkClientboundPacket() || !ctx.channel().isOpen()) {
             throw CancelEncoderException.generate(null);
         }
         if (!connection.shouldTransformPacket()) {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,8 @@ public BukkitEncodeHandler(final UserConnection connection) {`
`43`	`43`
`44`	`44`	`@Override`
`45`	`45`	`protected void encode(final ChannelHandlerContext ctx, final ByteBuf bytebuf, final List<Object> out) throws Exception {`
`46`		`- if (!connection.checkClientboundPacket()) {`
	`46`	`+ // Check if the channel is open as older servers might start sending packets through the pipeline despite the channel being closed`
	`47`	`+ if (!connection.checkClientboundPacket() \|\| !ctx.channel().isOpen()) {`
`47`	`48`	`throw CancelEncoderException.generate(null);`
`48`	`49`	`}`
`49`	`50`	`if (!connection.shouldTransformPacket()) {`