Add max-error-length config option

Author: kennytv

api/src/main/java/com/viaversion/viaversion/api/configuration/ViaVersionConfig.java

@@ -498,4 +498,11 @@ public interface ViaVersionConfig extends Config {
      * @return true if enabled
      */
     boolean cancelSwingInInventory();
+
+    /**
+     * Returns the max length of error messages. Longer messages will be truncated unless in debug mode.
+     *
+     * @return the max length of error messages
+     */
+    int maxErrorLength();
 }

api/src/main/java/com/viaversion/viaversion/exception/InformativeException.java

@@ -29,7 +29,6 @@
 import org.checkerframework.checker.nullness.qual.Nullable;
 
 public class InformativeException extends RuntimeException {
-    private static final int MAX_MESSAGE_LENGTH = 5_000;
     private final List<DataEntry> dataEntries = new ArrayList<>();
     private boolean shouldBePrinted = true;
     private int sources;
@@ -72,8 +71,8 @@ public String getMessage() {
 
             builder.append(entry.name()).append(": ");
             String s = String.valueOf(entry.value());
-            if (!Via.getManager().isDebug() && s.length() > 10 && builder.length() + s.length() > MAX_MESSAGE_LENGTH) {
-                final int remaining = Math.max(0, MAX_MESSAGE_LENGTH - builder.length());
+            if (!Via.getManager().isDebug() && s.length() > 10 && builder.length() + s.length() > Via.getConfig().maxErrorLength()) {
+                final int remaining = Math.max(0, Via.getConfig().maxErrorLength() - builder.length());
                 s = s.substring(0, Math.min(remaining, s.length())) + "...";
             }
             builder.append(StringUtil.forLogging(s));

common/src/main/java/com/viaversion/viaversion/configuration/AbstractViaConfig.java

@@ -97,6 +97,7 @@ public abstract class AbstractViaConfig extends Config implements ViaVersionConf
     private boolean hideScoreboardNumbers;
     private boolean fix1_21PlacementRotation;
     private boolean cancelSwingInInventory;
+    private int maxErrorLength;
 
     protected AbstractViaConfig(final File configFile, final Logger logger) {
         super(configFile, logger);
@@ -165,6 +166,7 @@ protected void loadFields() {
         cancelSwingInInventory = getBoolean("cancel-swing-in-inventory", true);
         packetTrackerConfig = loadRateLimitConfig(getSection("packet-limiter"), "%pps", 1);
         packetSizeTrackerConfig = loadRateLimitConfig(getSection("packet-size-limiter"), "%bps", 1024);
+        maxErrorLength = getInt("max-error-length", 1500);
     }
 
     protected void updateConfig() {
@@ -606,4 +608,9 @@ public boolean fix1_21PlacementRotation() {
     public boolean cancelSwingInInventory() {
         return cancelSwingInInventory;
     }
+
+    @Override
+    public int maxErrorLength() {
+        return maxErrorLength;
+    }
 }

common/src/main/java/com/viaversion/viaversion/protocol/packet/PacketWrapperImpl.java

@@ -32,6 +32,7 @@
 import com.viaversion.viaversion.api.type.Types;
 import com.viaversion.viaversion.exception.CancelException;
 import com.viaversion.viaversion.exception.InformativeException;
+import com.viaversion.viaversion.util.ArrayUtil;
 import com.viaversion.viaversion.util.PipelineUtil;
 import io.netty.buffer.ByteBuf;
 import io.netty.channel.ChannelFuture;
@@ -624,7 +625,7 @@ public int hashCode() {
 
         @Override
         public String toString() {
-            return "{" + type + ": " + value + "}";
+            return "{" + type + ": " + ArrayUtil.toString(value) + "}";
         }
     }
 }

common/src/main/resources/assets/viaversion/config.yml

@@ -31,6 +31,8 @@ reload-disconnect-msg: "Server reload, please rejoin!"
 suppress-conversion-warnings: false
 # This can be disabled for debugging purposes if text in chat/entities/items shows an error tag.
 suppress-text-component-conversion-warnings: true
+# Maximum length of error messages in the console.
+max-error-length: 1500
 #
 #----------------------------------------------------------#
 #                    VELOCITY OPTIONS                      #