Manually handle text component boolean entries

Fixes ViaVersion#4558

Author: kennytv

api/src/main/java/com/viaversion/viaversion/api/minecraft/data/StructuredDataKey.java

@@ -95,10 +95,10 @@ public record StructuredDataKey<T>(String identifier, Type<T> type) {
     public static final StructuredDataKey<Integer> DAMAGE = new StructuredDataKey<>("damage", Types.VAR_INT);
     public static final StructuredDataKey<Unbreakable> UNBREAKABLE1_20_5 = new StructuredDataKey<>("unbreakable", Unbreakable.TYPE);
     public static final StructuredDataKey<Unit> UNBREAKABLE1_21_5 = new StructuredDataKey<>("unbreakable", Types.EMPTY);
-    public static final StructuredDataKey<Tag> CUSTOM_NAME = new StructuredDataKey<>("custom_name", Types.TAG);
-    public static final StructuredDataKey<Tag> ITEM_NAME = new StructuredDataKey<>("item_name", Types.TAG);
+    public static final StructuredDataKey<Tag> CUSTOM_NAME = new StructuredDataKey<>("custom_name", Types.TEXT_COMPONENT_TAG);
+    public static final StructuredDataKey<Tag> ITEM_NAME = new StructuredDataKey<>("item_name", Types.TEXT_COMPONENT_TAG);
     public static final StructuredDataKey<Key> ITEM_MODEL = new StructuredDataKey<>("item_model", Types.RESOURCE_LOCATION);
-    public static final StructuredDataKey<Tag[]> LORE = new StructuredDataKey<>("lore", new ArrayType<>(Types.TAG, 256));
+    public static final StructuredDataKey<Tag[]> LORE = new StructuredDataKey<>("lore", new ArrayType<>(Types.TEXT_COMPONENT_TAG, 256));
     public static final StructuredDataKey<Integer> RARITY = new StructuredDataKey<>("rarity", EnumTypes.RARITY);
     public static final StructuredDataKey<Enchantments> ENCHANTMENTS1_20_5 = new StructuredDataKey<>("enchantments", Enchantments.TYPE1_20_5);
     public static final StructuredDataKey<Enchantments> ENCHANTMENTS1_21_5 = new StructuredDataKey<>("enchantments", Enchantments.TYPE1_21_5);

api/src/main/java/com/viaversion/viaversion/api/minecraft/item/data/AttributeModifiers1_21.java

@@ -173,7 +173,7 @@ public void write(final Ops ops, final AttributeModifier value) {
                     map.writeMap("display", display -> {
                         display.write("type", Types.STRING, Display.DISPLAY_TYPES[value.display.id()]);
                         if (value.display instanceof final OverrideText overrideText) {
-                            display.write("value", Types.TAG, overrideText.component);
+                            display.write("value", Types.TEXT_COMPONENT_TAG, overrideText.component);
                         }
                     });
                 });

api/src/main/java/com/viaversion/viaversion/api/type/Types.java

@@ -116,6 +116,7 @@
 import com.viaversion.viaversion.api.type.types.misc.SoundEventType;
 import com.viaversion.viaversion.api.type.types.misc.TagKeyType;
 import com.viaversion.viaversion.api.type.types.misc.TagType;
+import com.viaversion.viaversion.api.type.types.misc.TextComponentTagType;
 import com.viaversion.viaversion.api.type.types.misc.VillagerDataType;
 import com.viaversion.viaversion.api.type.types.version.Types1_20_5;
 import com.viaversion.viaversion.util.Key;
@@ -200,6 +201,7 @@ public final class Types {
     public static final Type<Tag> TAG = new TagType();
     public static final Type<Tag[]> TAG_ARRAY = new ArrayType<>(TAG);
     public static final Type<Tag> OPTIONAL_TAG = new TagType.OptionalTagType();
+    public static final Type<Tag> TEXT_COMPONENT_TAG = new TextComponentTagType(); // only strictly needed for hashing
     public static final Type<Tag> CUSTOM_CLICK_ACTION_TAG = new LengthPrefixedTagType(65536);
 
     public static final Type<GlobalBlockPosition> GLOBAL_POSITION = new GlobalBlockPositionType();

api/src/main/java/com/viaversion/viaversion/api/type/types/misc/TagType.java

@@ -105,13 +105,13 @@ public void write(final Ops ops, final Tag value) {
         } else if (value instanceof CompoundTag compoundTag) {
             ops.writeMap(map -> {
                 for (final Map.Entry<String, Tag> entry : compoundTag.entrySet()) {
-                    map.write(entry.getKey(), Types.TAG, entry.getValue());
+                    map.write(entry.getKey(), this, entry.getValue());
                 }
             });
         } else if (value instanceof ListTag<?> listTag) {
             ops.writeList(list -> {
                 for (final Tag tag : listTag) {
-                    list.write(Types.TAG, tag);
+                    list.write(this, tag);
                 }
             });
         } else if (value instanceof IntArrayTag intArrayTag) {

api/src/main/java/com/viaversion/viaversion/api/type/types/misc/TextComponentTagType.java

@@ -0,0 +1,61 @@
+/*
+ * This file is part of ViaVersion - https://github.com/ViaVersion/ViaVersion
+ * Copyright (C) 2016-2025 ViaVersion and contributors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package com.viaversion.viaversion.api.type.types.misc;
+
+import com.viaversion.nbt.tag.ByteTag;
+import com.viaversion.nbt.tag.CompoundTag;
+import com.viaversion.nbt.tag.Tag;
+import com.viaversion.viaversion.api.minecraft.codec.Ops;
+import com.viaversion.viaversion.api.type.Types;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Only strictly needed for hashing purposes for now.
+ */
+public class TextComponentTagType extends TagType {
+
+    private static final Set<String> BOOLEAN_KEYS = Set.of("bold", "italic", "underlined", "strikethrough", "obfuscated", "interpret");
+
+    @Override
+    public void write(final Ops ops, final Tag value) {
+        if (value instanceof final CompoundTag compoundTag) {
+            ops.writeMap(map -> {
+                for (final Map.Entry<String, Tag> entry : compoundTag.entrySet()) {
+                    write(map, entry.getKey(), entry.getValue());
+                }
+            });
+        } else {
+            super.write(ops, value);
+        }
+    }
+
+    private void write(final Ops.MapSerializer map, final String key, final Tag value) {
+        // Better than fully parsing and re-serializing the component
+        if (value instanceof final ByteTag byteTag && BOOLEAN_KEYS.contains(key)) {
+            map.write(key, Types.BOOLEAN, byteTag.asBoolean());
+        } else {
+            map.write(key, this, value);
+        }
+    }
+}