Add client and server protocol to informative exception data

Author: kennytv

api/src/main/java/com/viaversion/viaversion/api/minecraft/BlockChangeRecord1_16_2.java

@@ -58,7 +58,7 @@ public byte getSectionZ() {
 
     @Override
     public short getY(int chunkSectionY) {
-        Preconditions.checkArgument(chunkSectionY >= 0, "Invalid chunkSectionY: " + chunkSectionY);
+        Preconditions.checkArgument(chunkSectionY >= 0, "Invalid chunkSectionY: %s", chunkSectionY);
         return (short) ((chunkSectionY << 4) + sectionY);
     }
 

api/src/main/java/com/viaversion/viaversion/api/type/types/BitSetType.java

@@ -36,7 +36,7 @@ public class BitSetType extends Type<BitSet> {
     public BitSetType(final int length) {
         super(BitSet.class);
         this.length = length;
-        this.bytesLength = -Math.floorDiv(-length, 8); // Ceiled quotient
+        this.bytesLength = (int) Math.ceil(length / 8D);
     }
 
     @Override
@@ -48,8 +48,8 @@ public BitSet read(ByteBuf buffer) {
 
     @Override
     public void write(ByteBuf buffer, BitSet object) {
-        Preconditions.checkArgument(object.length() <= length, "BitSet of length " + object.length() + " larger than max length " + length);
+        Preconditions.checkArgument(object.length() <= length, "BitSet of length %s larger than max length %s", object.length(), length);
         final byte[] bytes = object.toByteArray();
-        buffer.writeBytes(Arrays.copyOf(bytes, bytesLength));
+        buffer.writeBytes(bytes.length == bytesLength ? bytes : Arrays.copyOf(bytes, bytesLength));
     }
 }

common/src/main/java/com/viaversion/viaversion/protocol/packet/PacketWrapperImpl.java

@@ -263,10 +263,13 @@ public void writeProcessedValues(ByteBuf buffer) throws InformativeException {
     }
 
     private InformativeException createInformativeException(final Exception cause, final Type<?> type, final int index) {
+        final ProtocolInfo protocolInfo = this.user().getProtocolInfo();
         return new InformativeException(cause)
             .set("Packet Type", this.packetType)
             .set("Index", index)
             .set("Type", type.getTypeName())
+            .set("Client Protocol", protocolInfo.protocolVersion().getName())
+            .set("Server Protocol", protocolInfo.serverProtocolVersion().getName())
             .set("Data", this.packetValues)
             .set("Packet ID", this.id);
     }