Remove empty mapped data component types in tooltip display

kennytv · kennytv · commit a3ff540cb3a5 · 2025-12-12T15:59:10.000+01:00
diff --git a/api/src/main/java/com/viaversion/viaversion/api/minecraft/item/data/TooltipDisplay.java b/api/src/main/java/com/viaversion/viaversion/api/minecraft/item/data/TooltipDisplay.java
@@ -75,7 +75,10 @@ public TooltipDisplay rewrite(final UserConnection connection, final Protocol<?,
 
         final IntSortedSet newHiddenComponents = new IntLinkedOpenHashSet();
         for (final int hiddenComponent : hiddenComponents) {
-            newHiddenComponents.add(Rewritable.rewriteDataComponentType(protocol, clientbound, hiddenComponent));
+            final int mappedId = Rewritable.rewriteDataComponentType(protocol, clientbound, hiddenComponent);
+            if (mappedId != -1) {
+                newHiddenComponents.add(mappedId);
+            }
         }
         return new TooltipDisplay(hideTooltip, newHiddenComponents);
     }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,10 @@ public TooltipDisplay rewrite(final UserConnection connection, final Protocol<?,`
`75`	`75`
`76`	`76`	`final IntSortedSet newHiddenComponents = new IntLinkedOpenHashSet();`
`77`	`77`	`for (final int hiddenComponent : hiddenComponents) {`
`78`		`- newHiddenComponents.add(Rewritable.rewriteDataComponentType(protocol, clientbound, hiddenComponent));`
	`78`	`+ final int mappedId = Rewritable.rewriteDataComponentType(protocol, clientbound, hiddenComponent);`
	`79`	`+ if (mappedId != -1) {`
	`80`	`+ newHiddenComponents.add(mappedId);`
	`81`	`+ }`
`79`	`82`	`}`
`80`	`83`	`return new TooltipDisplay(hideTooltip, newHiddenComponents);`
`81`	`84`	`}`