1.20.5 -> 1.20.3: nullify empty tags (ViaVersion#3949)

Camotoy · AJ-Ferguson · web-flow · commit b7f388b9ee79 · 2024-06-17T09:42:09.000+02:00
Co-authored-by: AJ Ferguson &lt;AJ-Ferguson@users.noreply.github.com&gt;
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/v1_20_3to1_20_5/rewriter/BlockItemPacketRewriter1_20_5.java b/common/src/main/java/com/viaversion/viaversion/protocols/v1_20_3to1_20_5/rewriter/BlockItemPacketRewriter1_20_5.java
@@ -408,6 +408,10 @@ public Item toOldItem(final UserConnection connection, final Item item, final St
             dataConverter.writeToTag(connection, structuredData, tag);
         }
 
+        if (tag.isEmpty()) {
+            dataItem.setTag(null);
+        }
+
         return dataItem;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -408,6 +408,10 @@ public Item toOldItem(final UserConnection connection, final Item item, final St`
`408`	`408`	`dataConverter.writeToTag(connection, structuredData, tag);`
`409`	`409`	`}`
`410`	`410`
	`411`	`+ if (tag.isEmpty()) {`
	`412`	`+ dataItem.setTag(null);`
	`413`	`+ }`
	`414`	`+`
`411`	`415`	`return dataItem;`
`412`	`416`	`}`
`413`	`417`