Add separate config option for text component conversion errors

kennytv · kennytv · commit bf84eb0141dd · 2025-04-20T15:57:22.000+02:00
diff --git a/api/src/main/java/com/viaversion/viaversion/api/configuration/ViaVersionConfig.java b/api/src/main/java/com/viaversion/viaversion/api/configuration/ViaVersionConfig.java
@@ -285,6 +285,13 @@ public interface ViaVersionConfig extends Config {
      */
     boolean isSuppressConversionWarnings();
 
+    /**
+     * Should we hide errors that occur when trying to convert text components?
+     *
+     * @return true if enabled
+     */
+    boolean isSuppressTextComponentConversionWarnings();
+
     /**
      * Should we disable the 1.13 auto-complete feature to stop spam kicks? (for any server lower than 1.13)
      *
diff --git a/api/src/main/java/com/viaversion/viaversion/exception/InformativeException.java b/api/src/main/java/com/viaversion/viaversion/exception/InformativeException.java
@@ -23,6 +23,7 @@
 package com.viaversion.viaversion.exception;
 
 import com.viaversion.viaversion.api.Via;
+import com.viaversion.viaversion.util.StringUtil;
 import java.util.ArrayList;
 import java.util.List;
 import org.checkerframework.checker.nullness.qual.Nullable;
@@ -74,7 +75,7 @@ public String getMessage() {
             if (!Via.getManager().isDebug() && s.length() > 10 && builder.length() + s.length() > MAX_MESSAGE_LENGTH) {
                 s = s.substring(0, MAX_MESSAGE_LENGTH - builder.length()) + "...";
             }
-            builder.append(s.replaceAll("\\s", ""));
+            builder.append(StringUtil.forLogging(s));
         }
         return builder.toString();
     }
diff --git a/api/src/main/java/com/viaversion/viaversion/util/StringUtil.java b/api/src/main/java/com/viaversion/viaversion/util/StringUtil.java
@@ -0,0 +1,43 @@
+/*
+ * This file is part of ViaVersion - https://github.com/ViaVersion/ViaVersion
+ * Copyright (C) 2016-2025 ViaVersion and contributors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package com.viaversion.viaversion.util;
+
+public final class StringUtil {
+
+    public static String forLogging(final Object o) {
+        return forLogging(String.valueOf(o));
+    }
+
+    public static String forLogging(final String s) {
+        final StringBuilder builder = new StringBuilder(s.length());
+        for (int i = 0, len = s.length(); i < len; i++) {
+            final char c = s.charAt(i);
+            if (c == '\t' || c == '\n' || c == '\r') {
+                builder.append(' ');
+            } else if (!Character.isISOControl(c)) {
+                builder.append(c);
+            }
+        }
+        return builder.toString();
+    }
+}
diff --git a/common/src/main/java/com/viaversion/viaversion/configuration/AbstractViaConfig.java b/common/src/main/java/com/viaversion/viaversion/configuration/AbstractViaConfig.java
@@ -71,6 +71,7 @@ public abstract class AbstractViaConfig extends Config implements ViaVersionConf
     private String blockedDisconnectMessage;
     private String reloadDisconnectMessage;
     private boolean suppressConversionWarnings;
+    private boolean suppressTextComponentConversionWarnings;
     private boolean disable1_13TabComplete;
     private boolean teamColourFix;
     private boolean serversideBlockConnections;
@@ -138,6 +139,7 @@ protected void loadFields() {
         reloadDisconnectMessage = getString("reload-disconnect-msg", "Server reload, please rejoin!");
         teamColourFix = getBoolean("team-colour-fix", true);
         suppressConversionWarnings = getBoolean("suppress-conversion-warnings", false);
+        suppressTextComponentConversionWarnings = getBoolean("suppress-text-component-conversion-warnings", true);
         disable1_13TabComplete = getBoolean("disable-1_13-auto-complete", false);
         serversideBlockConnections = getBoolean("serverside-blockconnections", true);
         reduceBlockStorageMemory = getBoolean("reduce-blockstorage-memory", false);
@@ -417,6 +419,11 @@ public boolean isSuppressConversionWarnings() {
         return suppressConversionWarnings && !Via.getManager().isDebug(); // Debug mode overrules config
     }
 
+    @Override
+    public boolean isSuppressTextComponentConversionWarnings() {
+        return suppressTextComponentConversionWarnings && !Via.getManager().isDebug(); // Debug mode overrules config
+    }
+
     @Override
     public boolean isDisable1_13AutoComplete() {
         return disable1_13TabComplete;
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/v1_11_1to1_12/data/TranslateRewriter.java b/common/src/main/java/com/viaversion/viaversion/protocols/v1_11_1to1_12/data/TranslateRewriter.java
@@ -25,6 +25,7 @@
 import com.viaversion.viaversion.protocols.v1_9_1to1_9_3.packet.ClientboundPackets1_9_3;
 import com.viaversion.viaversion.rewriter.text.JsonNBTComponentRewriter;
 import com.viaversion.viaversion.util.SerializerVersion;
+import com.viaversion.viaversion.util.StringUtil;
 import java.util.logging.Level;
 
 public class TranslateRewriter {
@@ -87,7 +88,7 @@ protected void handleHoverEvent(UserConnection connection, JsonObject hoverEvent
                 hoverEvent.add("value", baseArray);
             } catch (Exception e) {
                 if (!Via.getConfig().isSuppressConversionWarnings()) {
-                    protocol.getLogger().log(Level.WARNING, "Error rewriting show_achievement: " + hoverEvent, e);
+                    protocol.getLogger().log(Level.WARNING, "Error rewriting show_achievement: " + StringUtil.forLogging(hoverEvent), e);
                 }
                 JsonObject invalidText = new JsonObject();
                 invalidText.addProperty("text", "Invalid statistic/achievement!");
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/v1_12_2to1_13/rewriter/ComponentRewriter1_13.java b/common/src/main/java/com/viaversion/viaversion/protocols/v1_12_2to1_13/rewriter/ComponentRewriter1_13.java
@@ -33,6 +33,7 @@
 import com.viaversion.viaversion.rewriter.text.JsonNBTComponentRewriter;
 import com.viaversion.viaversion.util.ComponentUtil;
 import com.viaversion.viaversion.util.SerializerVersion;
+import com.viaversion.viaversion.util.StringUtil;
 import java.util.logging.Level;
 
 public class ComponentRewriter1_13<C extends ClientboundPacketType> extends JsonNBTComponentRewriter<C> {
@@ -54,8 +55,8 @@ protected void handleHoverEvent(UserConnection connection, JsonObject hoverEvent
         try {
             tag = ComponentUtil.deserializeLegacyShowItem(value, SerializerVersion.V1_12);
         } catch (Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error reading NBT in show_item: " + value, e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error reading NBT in show_item: " + StringUtil.forLogging(value), e);
             }
             return;
         }
@@ -86,8 +87,8 @@ protected void handleHoverEvent(UserConnection connection, JsonObject hoverEvent
             showItem.addProperty("text", SerializerVersion.V1_13.toSNBT(tag));
             hoverEvent.add("value", newValue);
         } catch (Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error writing NBT in show_item: " + value, e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error writing NBT in show_item: " + StringUtil.forLogging(value), e);
             }
         }
     }
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/v1_20_2to1_20_3/rewriter/BlockItemPacketRewriter1_20_3.java b/common/src/main/java/com/viaversion/viaversion/protocols/v1_20_2to1_20_3/rewriter/BlockItemPacketRewriter1_20_3.java
@@ -42,6 +42,7 @@
 import com.viaversion.viaversion.util.ComponentUtil;
 import com.viaversion.viaversion.util.Key;
 import com.viaversion.viaversion.util.SerializerVersion;
+import com.viaversion.viaversion.util.StringUtil;
 import java.util.logging.Level;
 import org.checkerframework.checker.nullness.qual.Nullable;
 
@@ -168,8 +169,8 @@ private void updatePageTag(final StringTag pageTag) {
             final JsonElement updatedComponent = ComponentUtil.convertJson(pageTag.getValue(), SerializerVersion.V1_19_4, SerializerVersion.V1_20_3);
             pageTag.setValue(updatedComponent.toString());
         } catch (final Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                protocol.getLogger().log(Level.SEVERE, "Error during book conversion: " + pageTag.getValue(), e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                protocol.getLogger().log(Level.SEVERE, "Error during book conversion: " + StringUtil.forLogging(pageTag.getValue()), e);
             }
         }
     }
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/v1_20_3to1_20_5/rewriter/ComponentRewriter1_20_5.java b/common/src/main/java/com/viaversion/viaversion/protocols/v1_20_3to1_20_5/rewriter/ComponentRewriter1_20_5.java
@@ -91,6 +91,7 @@
 import com.viaversion.viaversion.util.Key;
 import com.viaversion.viaversion.util.MathUtil;
 import com.viaversion.viaversion.util.SerializerVersion;
+import com.viaversion.viaversion.util.StringUtil;
 import com.viaversion.viaversion.util.UUIDUtil;
 import com.viaversion.viaversion.util.Unit;
 import it.unimi.dsi.fastutil.ints.Int2IntMap;
@@ -215,8 +216,8 @@ protected void handleShowItem(final UserConnection connection, final CompoundTag
         try {
             tagTag = tag != null ? (CompoundTag) inputSerializerVersion().toTag(tag.getValue()) : null;
         } catch (final Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                protocol.getLogger().log(Level.WARNING, "Error reading NBT in show_item: " + itemTag, e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                protocol.getLogger().log(Level.WARNING, "Error reading NBT in show_item: " + StringUtil.forLogging(itemTag), e);
             }
             return;
         }
@@ -249,7 +250,7 @@ protected void handleShowItem(final UserConnection connection, final CompoundTag
             try {
                 components = toTag(connection, data);
             } catch (final Exception e) {
-                if (!Via.getConfig().isSuppressConversionWarnings()) {
+                if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
                     protocol.getLogger().log(Level.WARNING, "Error writing components in show_item!", e);
                 }
                 return;
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/v1_21_4to1_21_5/rewriter/ComponentRewriter1_21_5.java b/common/src/main/java/com/viaversion/viaversion/protocols/v1_21_4to1_21_5/rewriter/ComponentRewriter1_21_5.java
@@ -28,6 +28,7 @@
 import com.viaversion.viaversion.protocols.v1_21to1_21_2.packet.ClientboundPacket1_21_2;
 import com.viaversion.viaversion.rewriter.text.JsonNBTComponentRewriter;
 import com.viaversion.viaversion.util.SerializerVersion;
+import com.viaversion.viaversion.util.StringUtil;
 import com.viaversion.viaversion.util.TagUtil;
 import java.net.URI;
 import java.net.URISyntaxException;
@@ -318,8 +319,8 @@ public Tag uglyJsonToTag(final UserConnection connection, final String value) {
         try {
             return uglyJsonToTagUncaught(connection, value);
         } catch (final Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting json text component: " + value, e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting json text component: " + StringUtil.forLogging(value), e);
             }
             return new StringTag("<error>");
         }
diff --git a/common/src/main/java/com/viaversion/viaversion/rewriter/RecipeDisplayRewriter.java b/common/src/main/java/com/viaversion/viaversion/rewriter/RecipeDisplayRewriter.java
@@ -19,7 +19,6 @@
 
 import com.viaversion.viaversion.api.minecraft.HolderSet;
 import com.viaversion.viaversion.api.minecraft.item.Item;
-import com.viaversion.viaversion.api.minecraft.item.data.ArmorTrimPattern;
 import com.viaversion.viaversion.api.protocol.Protocol;
 import com.viaversion.viaversion.api.protocol.packet.ClientboundPacketType;
 import com.viaversion.viaversion.api.protocol.packet.PacketWrapper;
diff --git a/common/src/main/java/com/viaversion/viaversion/rewriter/StructuredItemRewriter.java b/common/src/main/java/com/viaversion/viaversion/rewriter/StructuredItemRewriter.java
@@ -114,7 +114,6 @@ protected void updateItemDataComponentTypeIds(final StructuredDataContainer cont
     // Casting around Rewritable and especially Holder gets ugly, but the only good alternative is to do everything manually
     @SuppressWarnings("unchecked")
     protected void updateItemDataComponents(final UserConnection connection, final Item item, final boolean clientbound) {
-        // Specific types that need deep handling
         final StructuredDataContainer container = item.dataContainer();
         if (clientbound && protocol.getComponentRewriter() != null) {
             updateComponent(connection, item, StructuredDataKey.ITEM_NAME, "item_name");
@@ -145,29 +144,25 @@ protected void updateItemDataComponents(final UserConnection connection, final I
                 continue;
             }
 
-            final StructuredDataKey<?> key = entry.getKey();
             final Object value = data.value();
-            final Class<?> outputClass = key.type().getOutputClass();
-            if (outputClass == Item.class) {
+            if (value instanceof Item itemValue) {
                 final StructuredData<Item> itemData = (StructuredData<Item>) data;
-                itemData.setValue(itemHandler.rewrite(connection, itemData.value()));
-            } else if (outputClass == Item[].class) {
-                final StructuredData<Item[]> itemArrayData = (StructuredData<Item[]>) data;
-                final Item[] items = itemArrayData.value();
+                itemData.setValue(itemHandler.rewrite(connection, itemValue));
+            } else if (value instanceof Item[] items) {
                 for (int i = 0; i < items.length; i++) {
                     items[i] = itemHandler.rewrite(connection, items[i]);
                 }
             } else if (value instanceof Rewritable rewritable) {
                 setDataUnchecked(data, rewritable.rewrite(connection, protocol, clientbound));
-            } else if (outputClass == Holder.class) {
+            } else if (value instanceof Holder<?> holder) {
                 final StructuredData<Holder<?>> holderData = (StructuredData<Holder<?>>) data;
-                final Holder<?> holder = holderData.value();
                 if (holder.isDirect() && holder.value() instanceof Rewritable) {
                     holderData.setValue(updateHolderUnchecked(holder, connection, clientbound));
                 }
             } else if (value instanceof EitherHolder<?> eitherHolder) {
+                final StructuredData<EitherHolder<?>> holderData = (StructuredData<EitherHolder<?>>) data;
                 if (eitherHolder.hasHolder() && eitherHolder.holder().isDirect() && eitherHolder.holder().value() instanceof Rewritable) {
-                    setDataUnchecked(data, EitherHolder.of(updateHolderUnchecked(eitherHolder.holder(), connection, clientbound)));
+                    holderData.setValue(EitherHolder.of(updateHolderUnchecked(eitherHolder.holder(), connection, clientbound)));
                 }
             }
         }
diff --git a/common/src/main/java/com/viaversion/viaversion/util/ComponentUtil.java b/common/src/main/java/com/viaversion/viaversion/util/ComponentUtil.java
@@ -65,8 +65,8 @@ public static JsonObject plainToJson(final String message) {
             final TextComponent component = SerializerVersion.V1_20_3.toComponent(tag);
             return component != null ? SerializerVersion.V1_19_4.toJson(component) : null;
         } catch (final Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting tag: " + tag, e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting tag: " + StringUtil.forLogging(tag), e);
             }
             return plainToJson("<error>");
         }
@@ -81,8 +81,8 @@ public static JsonObject plainToJson(final String message) {
             final TextComponent component = SerializerVersion.V1_19_4.toComponent(element);
             return trimStrings(SerializerVersion.V1_20_3.toTag(component));
         } catch (final Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting component: " + element, e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting component: " + StringUtil.forLogging(element), e);
             }
             return new StringTag("<error>");
         }
@@ -110,8 +110,8 @@ public static Tag trimStrings(final Tag input) {
             final TextComponent component = SerializerVersion.V1_20_5.toComponent(tag);
             return component != null ? SerializerVersion.V1_20_3.toString(component) : null;
         } catch (final Exception e) {
-            if (!Via.getConfig().isSuppressConversionWarnings()) {
-                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting tag: " + tag, e);
+            if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {
+                Via.getPlatform().getLogger().log(Level.SEVERE, "Error converting tag: " + StringUtil.forLogging(tag), e);
             }
             return plainToJson("<error>").toString();
         }
diff --git a/common/src/main/java/com/viaversion/viaversion/util/SerializerVersion.java b/common/src/main/java/com/viaversion/viaversion/util/SerializerVersion.java
@@ -50,7 +50,7 @@ public enum SerializerVersion {
     V1_20_3(TextComponentCodec.V1_20_3, SNbt.V1_14),
     V1_20_5(TextComponentCodec.V1_20_5, SNbt.V1_14),
     V1_21_4(TextComponentCodec.V1_21_4, SNbt.V1_14),
-    V1_21_5(TextComponentCodec.V1_21_5, null/*Currently not needed and also not implemented 100% in MCStructs*/);
+    V1_21_5(TextComponentCodec.V1_21_5, SNbt.V1_21_5);
 
     final TextComponentSerializer jsonSerializer;
     final SNbt<? extends Tag> sNbt;
diff --git a/common/src/main/resources/assets/viaversion/config.yml b/common/src/main/resources/assets/viaversion/config.yml
@@ -27,6 +27,8 @@ block-disconnect-msg: "You are using an unsupported Minecraft version!"
 reload-disconnect-msg: "Server reload, please rejoin!"
 # We warn when there's an error converting item/block or component/nbt data over versions, should we suppress these? (Only suggested if spamming)
 suppress-conversion-warnings: false
+# This can be disabled for debugging purposes if text in chat/entities/items shows an error tag.
+suppress-text-component-conversion-warnings: true
 #
 #----------------------------------------------------------#
 #                    VELOCITY OPTIONS                      #

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`package com.viaversion.viaversion.exception;`
`24`	`24`
`25`	`25`	`import com.viaversion.viaversion.api.Via;`
	`26`	`+import com.viaversion.viaversion.util.StringUtil;`
`26`	`27`	`import java.util.ArrayList;`
`27`	`28`	`import java.util.List;`
`28`	`29`	`import org.checkerframework.checker.nullness.qual.Nullable;`
`@@ -74,7 +75,7 @@ public String getMessage() {`
`74`	`75`	`if (!Via.getManager().isDebug() && s.length() > 10 && builder.length() + s.length() > MAX_MESSAGE_LENGTH) {`
`75`	`76`	`s = s.substring(0, MAX_MESSAGE_LENGTH - builder.length()) + "...";`
`76`	`77`	`}`
`77`		`- builder.append(s.replaceAll("\\s", ""));`
	`78`	`+ builder.append(StringUtil.forLogging(s));`
`78`	`79`	`}`
`79`	`80`	`return builder.toString();`
`80`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@`
`33`	`33`	`import com.viaversion.viaversion.rewriter.text.JsonNBTComponentRewriter;`
`34`	`34`	`import com.viaversion.viaversion.util.ComponentUtil;`
`35`	`35`	`import com.viaversion.viaversion.util.SerializerVersion;`
	`36`	`+import com.viaversion.viaversion.util.StringUtil;`
`36`	`37`	`import java.util.logging.Level;`
`37`	`38`
`38`	`39`	`public class ComponentRewriter1_13<C extends ClientboundPacketType> extends JsonNBTComponentRewriter<C> {`
`@@ -54,8 +55,8 @@ protected void handleHoverEvent(UserConnection connection, JsonObject hoverEvent`
`54`	`55`	`try {`
`55`	`56`	`tag = ComponentUtil.deserializeLegacyShowItem(value, SerializerVersion.V1_12);`
`56`	`57`	`} catch (Exception e) {`
`57`		`- if (!Via.getConfig().isSuppressConversionWarnings()) {`
`58`		`- Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error reading NBT in show_item: " + value, e);`
	`58`	`+ if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {`
	`59`	`+ Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error reading NBT in show_item: " + StringUtil.forLogging(value), e);`
`59`	`60`	`}`
`60`	`61`	`return;`
`61`	`62`	`}`
`@@ -86,8 +87,8 @@ protected void handleHoverEvent(UserConnection connection, JsonObject hoverEvent`
`86`	`87`	`showItem.addProperty("text", SerializerVersion.V1_13.toSNBT(tag));`
`87`	`88`	`hoverEvent.add("value", newValue);`
`88`	`89`	`} catch (Exception e) {`
`89`		`- if (!Via.getConfig().isSuppressConversionWarnings()) {`
`90`		`- Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error writing NBT in show_item: " + value, e);`
	`90`	`+ if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {`
	`91`	`+ Protocol1_12_2To1_13.LOGGER.log(Level.WARNING, "Error writing NBT in show_item: " + StringUtil.forLogging(value), e);`
`91`	`92`	`}`
`92`	`93`	`}`
`93`	`94`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@`
`42`	`42`	`import com.viaversion.viaversion.util.ComponentUtil;`
`43`	`43`	`import com.viaversion.viaversion.util.Key;`
`44`	`44`	`import com.viaversion.viaversion.util.SerializerVersion;`
	`45`	`+import com.viaversion.viaversion.util.StringUtil;`
`45`	`46`	`import java.util.logging.Level;`
`46`	`47`	`import org.checkerframework.checker.nullness.qual.Nullable;`
`47`	`48`
`@@ -168,8 +169,8 @@ private void updatePageTag(final StringTag pageTag) {`
`168`	`169`	`final JsonElement updatedComponent = ComponentUtil.convertJson(pageTag.getValue(), SerializerVersion.V1_19_4, SerializerVersion.V1_20_3);`
`169`	`170`	`pageTag.setValue(updatedComponent.toString());`
`170`	`171`	`} catch (final Exception e) {`
`171`		`- if (!Via.getConfig().isSuppressConversionWarnings()) {`
`172`		`- protocol.getLogger().log(Level.SEVERE, "Error during book conversion: " + pageTag.getValue(), e);`
	`172`	`+ if (!Via.getConfig().isSuppressTextComponentConversionWarnings()) {`
	`173`	`+ protocol.getLogger().log(Level.SEVERE, "Error during book conversion: " + StringUtil.forLogging(pageTag.getValue()), e);`
`173`	`174`	`}`
`174`	`175`	`}`
`175`	`176`	`}`