feat: test subnet governance

Author: Shas

src/SubnetManager.sol

@@ -606,6 +606,11 @@ contract SubnetManager is ISubnetManager, ERC721Upgradeable, Ownable2StepUpgrade
         emit SubnetFeeBurnRateUpdated(newBurnRate);
     }
 
+    /// @inheritdoc ISubnetManager
+    function getSubnetFeeBurnRate() public view returns (uint8) {
+        return subnetFeeBurnRate;
+    }
+
     /// @inheritdoc ISubnetManager
     function setPerformancePoolShare(uint8 newShare) public onlyRole(SUBNET_ADMIN_ROLE) {
         if (newShare > 50) {
@@ -615,6 +620,11 @@ contract SubnetManager is ISubnetManager, ERC721Upgradeable, Ownable2StepUpgrade
         emit PerformancePoolShareUpdated(newShare);
     }
 
+    /// @inheritdoc ISubnetManager
+    function getPerformancePoolShare() public view returns (uint8) {
+        return performancePoolShare;
+    }
+
     /// @inheritdoc ISubnetManager
     function subnetOwner(uint256 subnetId) public view returns (address) {
         return ownerOf(subnetId);

src/interfaces/ISubnetManager.sol

@@ -466,10 +466,18 @@ interface ISubnetManager {
     /// @param newBurnRate New subnet fee burn rate (percentage)
     function setSubnetFeeBurnRate(uint8 newBurnRate) external;
 
+    /// @notice Gets the subnet fee burn rate
+    /// @return Subnet fee burn rate (percentage)
+    function getSubnetFeeBurnRate() external view returns (uint8);
+
     /// @notice Sets the performance pool share for a subnet
     /// @param newShare New performance pool share
     function setPerformancePoolShare(uint8 newShare) external;
 
+    /// @notice Gets the performance pool share for a subnet
+    /// @return Performance pool share
+    function getPerformancePoolShare() external view returns (uint8);
+
     /// @notice Deletes a subnet
     /// @param subnetId ID of the subnet to delete
     function deleteSubnet(uint256 subnetId) external;

test/PodManagerV2/PodManagerV2.Base.t.sol

@@ -432,6 +432,10 @@ contract SubnetManagerMock is ISubnetManager {
     function getSeederFeeShare(
         uint256 subnetId
     ) external view override returns (uint8) {}
+
+    function getSubnetFeeBurnRate() external view override returns (uint8) {}
+
+    function getPerformancePoolShare() external view override returns (uint8) {}
 }
 
 abstract contract PodManagerV2TestBase is Test {

test/SubnetManager/SubnetManager.SubnetGovernance.t.sol

@@ -0,0 +1,55 @@
+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.29;
+
+import {SubnetManagerTestBase} from "./SubnetManager.Base.t.sol";
+
+contract SubnetManagerSubnetGovernanceTest is SubnetManagerTestBase {
+
+    function test_governanceAdminCanChangeTaxRate() public {
+        uint8 newTaxRate = 15;
+        vm.startPrank(admin);
+        subnetManager.setTaxRate(newTaxRate);
+        vm.stopPrank();
+        uint8 currentTaxRate = subnetManager.getTaxRate();
+        assertEq(currentTaxRate, newTaxRate, "Tax rate should be updated by admin");
+    }
+
+    function testRevert_nonAdminCannotChangeTaxRate() public {
+        vm.startPrank(user1);
+        vm.expectRevert(abi.encodeWithSignature("AccessControlUnauthorizedAccount(address,bytes32)", user1, keccak256("SUBNET_ADMIN_ROLE")));
+        subnetManager.setTaxRate(20);
+        vm.stopPrank();
+    }
+
+    function test_governanceAdminCanChangeSubnetFeeBurnRate() public {
+        uint8 newBurnRate = 5;
+        vm.startPrank(admin);
+        subnetManager.setSubnetFeeBurnRate(newBurnRate);
+        vm.stopPrank();
+        uint8 currentBurnRate = subnetManager.getSubnetFeeBurnRate();
+        assertEq(currentBurnRate, newBurnRate, "Subnet fee burn rate should be updated by admin");
+    }
+
+    function testRevert_nonAdminCannotChangeSubnetFeeBurnRate() public {
+        vm.startPrank(user1);
+        vm.expectRevert(abi.encodeWithSignature("AccessControlUnauthorizedAccount(address,bytes32)", user1, keccak256("SUBNET_ADMIN_ROLE")));
+        subnetManager.setSubnetFeeBurnRate(10);
+        vm.stopPrank();
+    }
+
+    function test_governaceCanChangePerformancePoolShare() public {
+        uint8 newShare = 25;
+        vm.startPrank(admin);
+        subnetManager.setPerformancePoolShare(newShare);
+        vm.stopPrank();
+        uint8 currentShare = subnetManager.getPerformancePoolShare();
+        assertEq(currentShare, newShare, "Performance pool share should be updated by admin");
+    }
+
+    function testRevert_nonAdminCannotChangePerformancePoolShare() public {
+        vm.startPrank(user1);
+        vm.expectRevert(abi.encodeWithSignature("AccessControlUnauthorizedAccount(address,bytes32)", user1, keccak256("SUBNET_ADMIN_ROLE")));
+        subnetManager.setPerformancePoolShare(30);
+        vm.stopPrank();
+    }
+}