Skip to content

Commit 9e1cb88

Browse files
authored
use double quotes around pkgs in conda and pip installs (#287)
* use double quotes around pkgs in conda and pip installs * add user workdir to fix conda installs
1 parent 4699b6c commit 9e1cb88

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

neurodocker/interfaces/tests/test_miniconda.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ def test_docker(self):
1111
'instructions': [
1212
('base', 'centos:7'),
1313
('user', 'neuro'),
14+
('workdir', '/home/neuro'),
1415
(
1516
'miniconda',
1617
{
@@ -40,6 +41,7 @@ def test_singularity(self):
4041
'instructions': [
4142
('base', 'docker://debian:stretch-slim'),
4243
('user', 'neuro'),
44+
('workdir', '/home/neuro'),
4345
(
4446
'miniconda',
4547
{

neurodocker/templates/miniconda.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ generic:
3535
conda install -y {{ miniconda.conda_opts|default("-q") }} --name {{ miniconda.env_name }} \
3636
{%- for pkg in miniconda.conda_install %}
3737
{% if not loop.last -%}
38-
'{{ pkg }}' \
38+
"{{ pkg }}" \
3939
{%- else -%}
40-
'{{ pkg }}'
40+
"{{ pkg }}"
4141
{%- endif -%}
4242
{% endfor %}
4343
sync && conda clean --all && sync
@@ -47,9 +47,9 @@ generic:
4747
pip install --no-cache-dir {{ miniconda.pip_opts }} \
4848
{%- for pkg in miniconda.pip_install %}
4949
{% if not loop.last -%}
50-
'{{ pkg }}' \
50+
"{{ pkg }}" \
5151
{%- else -%}
52-
'{{ pkg }}'
52+
"{{ pkg }}"
5353
{%- endif -%}
5454
{% endfor %}"
5555
rm -rf ~/.cache/pip/*

0 commit comments

Comments
 (0)