Skip to content

Commit af55533

Browse files
committed
fix testing logic for isVis
1 parent 145e06c commit af55533

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

reproschema/tests/test_rs2redcap_redcap2rs.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -259,15 +259,13 @@ def compare_protocols(prot_tree_orig, prot_tree_final):
259259
)
260260

261261
elif key == "isVis":
262-
# Original isVis handling
263-
if orig_value is not None:
264-
if normalize_condition(
265-
orig_value
266-
) != normalize_condition(final_value):
262+
if orig_value is True:
263+
# If original is True and final is None/missing, don't count as error
264+
pass
265+
elif orig_value is not None:
266+
if normalize_condition(orig_value) != normalize_condition(final_value):
267267
error = True
268-
elif (
269-
final_value is not None and final_value is not True
270-
):
268+
elif final_value is not None and final_value is not True:
271269
error = True
272270

273271
if error:

0 commit comments

Comments
 (0)