chore(typescript): change moduleResolution (#1605)

Author: alexandre-abrioux

.circleci/config.yml

@@ -119,6 +119,10 @@ jobs:
             --ignore @requestnetwork/payment-processor \
             --ignore @requestnetwork/integration-test \
             --concurrency=2
+          environment:
+            # Lerna starts 2 Jest commands at the same time (see above --concurrency=2),
+            # so we use 50% of our CPU cores on each
+            JEST_MAX_WORKERS: '50%'
       - store_test_results:
           path: packages/advance-logic/reports/
       - store_test_results:

jest.config.js

@@ -17,4 +17,5 @@ module.exports = {
       },
     ],
   ],
+  ...(process.env.JEST_MAX_WORKERS ? { maxWorkers: process.env.JEST_MAX_WORKERS } : {}),
 };

package.json

@@ -52,7 +52,7 @@
     "npm-package-json-lint": "5.1.0",
     "prettier": "2.8.8",
     "prettier-plugin-solidity": "1.0.0-beta.19",
-    "typescript": "5.1.3"
+    "typescript": "5.8.3"
   },
   "resolutions": {
     "elliptic": "^6.6.1",

packages/advanced-logic/package.json

@@ -42,16 +42,16 @@
     "@requestnetwork/currency": "0.28.0",
     "@requestnetwork/types": "0.54.0",
     "@requestnetwork/utils": "0.54.0",
-    "tslib": "2.5.0"
+    "tslib": "2.8.1"
   },
   "devDependencies": {
     "@types/jest": "29.5.6",
     "@types/node": "18.11.9",
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
-    "ts-jest": "29.1.0",
+    "ts-jest": "29.3.2",
     "ts-node": "10.9.1",
-    "typescript": "5.1.3"
+    "typescript": "5.8.3"
   },
   "gitHead": "6155223cfce769e48ccae480c510b35b4f54b4d0"
 }

packages/currency/package.json

@@ -47,7 +47,7 @@
     "@requestnetwork/utils": "0.54.0",
     "multicoin-address-validator": "0.5.15",
     "node-dijkstra": "2.5.0",
-    "tslib": "2.5.0"
+    "tslib": "2.8.1"
   },
   "devDependencies": {
     "@types/jest": "29.5.6",
@@ -57,8 +57,8 @@
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
     "source-map-support": "0.5.19",
-    "ts-jest": "29.1.0",
+    "ts-jest": "29.3.2",
     "ts-node": "10.9.1",
-    "typescript": "5.1.3"
+    "typescript": "5.8.3"
   }
 }

packages/data-access/package.json

@@ -42,17 +42,17 @@
     "@requestnetwork/multi-format": "0.28.0",
     "@requestnetwork/types": "0.54.0",
     "@requestnetwork/utils": "0.54.0",
-    "tslib": "2.5.0"
+    "tslib": "2.8.1"
   },
   "devDependencies": {
     "@types/jest": "29.5.6",
     "@types/node": "18.11.9",
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
     "source-map-support": "0.5.19",
-    "ts-jest": "29.1.0",
+    "ts-jest": "29.3.2",
     "ts-node": "10.9.1",
-    "typescript": "5.1.3"
+    "typescript": "5.8.3"
   },
   "gitHead": "6155223cfce769e48ccae480c510b35b4f54b4d0"
 }

packages/data-access/src/index.ts

@@ -3,6 +3,6 @@ export { CombinedDataAccess } from './combined-data-access';
 export { DataAccessWrite } from './data-write';
 export { DataAccessRead } from './data-read';
 export { PendingStore } from './pending-store';
-export { DataAccessBaseOptions } from './types';
+export type { DataAccessBaseOptions } from './types';
 export { MockDataAccess } from './mock-data-access';
 export { NoPersistDataWrite } from './no-persist-data-write';

packages/data-format/package.json

@@ -40,15 +40,16 @@
     "test:watch": "yarn test --watch"
   },
   "dependencies": {
-    "ajv": "6.12.4",
+    "ajv": "8.17.1",
+    "ajv-formats": "3.0.1",
     "ethers": "5.7.2",
-    "tslib": "2.5.0"
+    "tslib": "2.8.1"
   },
   "devDependencies": {
     "@types/node": "18.11.9",
     "jest-junit": "16.0.0",
     "ts-node": "10.9.1",
-    "typescript": "5.1.3"
+    "typescript": "5.8.3"
   },
   "gitHead": "6155223cfce769e48ccae480c510b35b4f54b4d0"
 }

packages/data-format/src/index.ts

@@ -1,4 +1,5 @@
-import * as AJV from 'ajv';
+import { Ajv } from 'ajv';
+import addFormats from 'ajv-formats';
 import * as jsonSchema from 'ajv/lib/refs/json-schema-draft-06.json';
 import * as schemaAddress from './format/address.json';
 import { formats } from './format';
@@ -9,7 +10,8 @@ import { formats } from './format';
  * @return  object.valid == true if the json is valid, object.valid == false and object.errors otherwise.
  */
 export function validate(data: any): any {
-  const validationTool = new AJV().addMetaSchema(jsonSchema).addSchema(schemaAddress);
+  const validationTool = new Ajv().addMetaSchema(jsonSchema).addSchema(schemaAddress);
+  addFormats(validationTool);
 
   // Check the meta information
   if (!data.meta) {

packages/data-format/test/test.ts

@@ -30,7 +30,7 @@ describe('Request Network Data Validator', () => {
     // 'result.valid should be false'
     expect(result.valid).toBe(false);
     // 'result.errors is wrong'
-    expect(result.errors[0].message).toBe('should be string');
+    expect(result.errors[0].message).toBe('must be string');
   });
 
   it('should not validate an invalid invoice 0.0.3 format', () => {
@@ -39,7 +39,7 @@ describe('Request Network Data Validator', () => {
     // 'result.valid should be false'
     expect(result.valid).toBe(false);
     // 'result.errors is wrong'
-    expect(result.errors[0].message).toBe('should be string');
+    expect(result.errors[0].message).toBe('must be string');
   });
 
   it('should not validate a json without meta', () => {
@@ -66,7 +66,7 @@ describe('Request Network Data Validator', () => {
     // 'result.valid should be false'
     expect(result.valid).toBe(false);
     // 'result.errors is wrong'
-    expect(result.errors[0].message).toBe('should match format "date-time"');
+    expect(result.errors[0].message).toBe('must match format "date-time"');
   });
 
   it('should not validate a json with required parameter missing', () => {
@@ -75,7 +75,7 @@ describe('Request Network Data Validator', () => {
     // 'result.valid should be false'
     expect(result.valid).toBe(false);
     // 'result.errors is wrong'
-    expect(result.errors[0].message).toBe(`should have required property \'name\'`);
+    expect(result.errors[0].message).toBe(`must have required property \'name\'`);
   });
 
   it('should not validate a json with meta.format missing', () => {