Merge pull request #3112 from ResearchHub/user_id_for_dashboard

Temporary User ID parameter for funding dashboards

Author: michaelcanova

src/purchase/services/overview_mixin.py

@@ -1,4 +1,3 @@
-"""Shared query helpers for overview services."""
 from purchase.models import Purchase
 from purchase.related_models.usd_fundraise_contribution_model import UsdFundraiseContribution
 from purchase.utils import rsc_and_cents_to_usd

src/purchase/views/fundraise_view.py

@@ -19,9 +19,21 @@
 from purchase.services.funding_impact_service import FundingImpactService
 from purchase.services.funding_overview_service import FundingOverviewService
 from referral.services.referral_bonus_service import ReferralBonusService
+from user.models import User
 from user.permissions import IsModerator
 from user.related_models.follow_model import Follow
 
+#Temporary function for testing different user data, will be removed before release
+def _resolve_target_user(request) -> User | None:
+    """Return the user specified by ?user_id, falling back to the requester."""
+    user_id = request.query_params.get("user_id")
+    if user_id:
+        try:
+            return User.objects.get(id=user_id)
+        except User.DoesNotExist:
+            return None
+    return request.user
+
 
 class FundraiseViewSet(viewsets.ModelViewSet):
     queryset = Fundraise.objects.all()
@@ -302,14 +314,20 @@ def close(self, request, *args, **kwargs):
 
     @action(detail=False, methods=["get"], permission_classes=[IsAuthenticated])
     def funding_overview(self, request, *args, **kwargs):
-        """Return funding overview metrics for the authenticated user."""
-        data = self.funding_overview_service.get_funding_overview(request.user)
+        """Return funding overview metrics. Accepts optional ?user_id param."""
+        user = _resolve_target_user(request)
+        if user is None:
+            return Response({"error": "User not found"}, status=404)
+        data = self.funding_overview_service.get_funding_overview(user)
         serializer = FundingOverviewSerializer(data)
         return Response(serializer.data)
 
     @action(detail=False, methods=["get"], permission_classes=[IsAuthenticated])
     def funding_impact(self, request, *args, **kwargs):
-        """Return funding impact metrics for the authenticated user."""
-        data = self.funding_impact_service.get_funding_impact_overview(request.user)
+        """Return funding impact metrics. Accepts optional ?user_id param."""
+        user = _resolve_target_user(request)
+        if user is None:
+            return Response({"error": "User not found"}, status=404)
+        data = self.funding_impact_service.get_funding_impact_overview(user)
         serializer = FundingImpactSerializer(data)
         return Response(serializer.data)

src/purchase/views/grant_view.py

@@ -11,8 +11,20 @@
 from purchase.services.funding_overview_service import GrantOverviewService
 from researchhub_document.related_models.constants.document_type import PREREGISTRATION
 from researchhub_document.related_models.researchhub_post_model import ResearchhubPost
+from user.models import User
 from user.permissions import IsModerator
 
+#Temporary function for testing different user data, will be removed before release
+def _resolve_target_user(request) -> User | None:
+    """Return the user specified by ?user_id, falling back to the requester."""
+    user_id = request.query_params.get("user_id")
+    if user_id:
+        try:
+            return User.objects.get(id=user_id)
+        except User.DoesNotExist:
+            return None
+    return request.user
+
 
 class GrantViewSet(viewsets.ModelViewSet):
     queryset = Grant.objects.all()
@@ -202,11 +214,14 @@ def application(self, request, pk=None):
 
     @action(detail=True, methods=["get"], permission_classes=[IsAuthenticated])
     def overview(self, request, pk=None, *args, **kwargs):
-        """Return dashboard metrics for a grant, looked up by its post ID."""
+        """Return dashboard metrics for a grant. Accepts optional ?user_id param."""
         grant = Grant.objects.filter(unified_document__posts__id=pk).first()
         if not grant:
             return Response(status=404)
-        data = self.grant_overview_service.get_grant_overview(request.user, grant)
+        user = _resolve_target_user(request)
+        if user is None:
+            return Response({"error": "User not found"}, status=404)
+        data = self.grant_overview_service.get_grant_overview(user, grant)
         serializer = GrantOverviewSerializer(data)
         return Response(serializer.data)