Merge pull request #214 from dnlbauer/fix_constructur_type_error

fix: Error message for incompatible constructor options

Author: simleo

rocrate/rocrate.py

@@ -91,6 +91,8 @@ def __init__(self, source=None, gen_preview=False, init=False, exclude=None):
             # create a new ro-crate
             self.add(RootDataset(self), Metadata(self))
         elif init:
+            if isinstance(source, dict):
+                raise ValueError("parameter 'init' is not compatible with a dict source")
             self.__init_from_tree(source, gen_preview=gen_preview)
         else:
             source = self.__read(source, gen_preview=gen_preview)

test/test_read.py

@@ -595,3 +595,5 @@ def test_from_dict(tmpdir):
     for entity in d1, d2, f1:
         entity.source = None
     crate.write(out_path)
+    with pytest.raises(ValueError):
+        ROCrate(metadata, init=True)