data entity not linked from hasPart: raise only for 1.2

Author: simleo

rocrate/rocrate.py

@@ -27,6 +27,7 @@
 import os
 import shutil
 import tempfile
+import warnings
 
 from collections import OrderedDict
 from pathlib import Path
@@ -207,7 +208,11 @@ def __read_contextual_entities(self, entities):
         type_map = {_.__name__: _ for _ in subclasses(ContextEntity)}
         for identifier, entity in entities.items():
             if is_data_entity(entity):
-                raise ValueError(f"{entity['@id']} is a data entity but it's not linked from the root dataset's hasPart")
+                id_ = entity['@id']
+                if self.version_obj >= Version("1.2"):
+                    raise ValueError(f"'{id_}' is a data entity but it's not linked to from the root dataset's hasPart")
+                else:
+                    warnings.warn(f"'{id_}' looks like a data entity but it's not listed in the root dataset's hasPart")
             assert identifier == entity.pop('@id')
             cls = pick_type(entity, type_map, fallback=ContextEntity)
             self.add(cls(self, identifier, entity))

test/test_read.py

@@ -709,6 +709,7 @@ def test_read_version(test_data_dir):
     assert crate.version == "1.1"
 
 
+@pytest.mark.filterwarnings("ignore")
 @pytest.mark.parametrize("version", ["1.0", "1.1", "1.2"])
 def test_data_entity_not_linked(version):
     metadata = {
@@ -737,8 +738,13 @@ def test_data_entity_not_linked(version):
             }
         ]
     }
-    with pytest.raises(ValueError, match="hasPart"):
-        ROCrate(metadata)
+    if version == "1.2":
+        with pytest.raises(ValueError, match="hasPart"):
+            ROCrate(metadata)
+    else:
+        crate = ROCrate(metadata)
+        f1 = crate.get("f1.txt")
+        assert f1 in crate.contextual_entities
 
 
 @pytest.mark.parametrize("version", ["1.0", "1.1", "1.2"])