-
Notifications
You must be signed in to change notification settings - Fork 100
Open
Description
Our tests are messy, declaring header functions everywhere, as of PHP 5.4 we can use http_response_code function to check headers and xdebug_get_headers together to check for HTTP header changes on our tests.
Implementing our own header abstraction would pose work without much benefit - other than having better tests.
- Move version constraint to PHP 5.4 on
composer.json(we could go higher). - Implement
assertHttpStatusCodeassertion. - Implement
assertHeaderContainsassertion.
Original post
Issues #18 and #25 showed we need to manipulate the HTTP header sometimes, despite the correction of the issues we should implement some way to handle header manipulation in a way that fits inside the Respect/Rest/Router and feels right.
"How we are going to do that?" is the question that this issue should fix, hopefully with a nice and sweet push =D