Change how to stringify DateTimeInterface objects

DateTime and DateTimeImmutable are clearly date/time objects. Therefore,
the prefix "[date-time]" is entirely unnecessary. Besides, I want to
represent objects with "{}," which is more intuitive since we declare
classes with them.

Signed-off-by: Henrique Moody <[email protected]>

Author: henriquemoody

src/Stringifiers/ClusterStringifier.php

@@ -10,6 +10,7 @@
 
 namespace Respect\Stringifier\Stringifiers;
 
+use DateTimeInterface;
 use Respect\Stringifier\Quoters\CodeQuoter;
 use Respect\Stringifier\Stringifier;
 
@@ -38,7 +39,7 @@ public static function createDefault(): self
         $stringifier = new self();
         $stringifier->setStringifiers([
             new TraversableStringifier($stringifier, $quoter),
-            new DateTimeStringifier($stringifier, $quoter, 'c'),
+            new DateTimeStringifier($quoter, DateTimeInterface::ATOM),
             new ThrowableStringifier($stringifier, $quoter),
             new StringableObjectStringifier($stringifier),
             new JsonSerializableStringifier($stringifier, $quoter),

src/Stringifiers/DateTimeStringifier.php

@@ -19,7 +19,6 @@
 final class DateTimeStringifier implements Stringifier
 {
     public function __construct(
-        private readonly Stringifier $stringifier,
         private readonly Quoter $quoter,
         private readonly string $format
     ) {
@@ -31,13 +30,6 @@ public function stringify(mixed $raw, int $depth): ?string
             return null;
         }
 
-        return $this->quoter->quote(
-            sprintf(
-                '[date-time] (%s: %s)',
-                $raw::class,
-                $this->stringifier->stringify($raw->format($this->format), $depth + 1)
-            ),
-            $depth
-        );
+        return $this->quoter->quote(sprintf('%s { %s }', $raw::class, $raw->format($this->format)), $depth);
     }
 }

tests/integration/stringify-object-dateTime.phpt

@@ -11,5 +11,5 @@ outputMultiple(
 );
 ?>
 --EXPECT--
-`[date-time] (DateTime: "2017-12-31T23:59:59+00:00")`
-`[date-time] (DateTimeImmutable: "2017-12-31T23:59:59+00:00")`
+`DateTime { 2017-12-31T23:59:59+00:00 }`
+`DateTimeImmutable { 2017-12-31T23:59:59+00:00 }`

tests/unit/Stringifiers/DateTimeStringifierTest.php

@@ -8,7 +8,7 @@
 
 declare(strict_types=1);
 
-namespace Respect\Stringifier\Test\Stringifiers;
+namespace Respect\Stringifier\Test\Unit\Stringifiers;
 
 use DateTime;
 use DateTimeImmutable;
@@ -17,73 +17,52 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
-use Respect\Stringifier\Quoter;
-use Respect\Stringifier\Stringifier;
 use Respect\Stringifier\Stringifiers\DateTimeStringifier;
+use Respect\Stringifier\Test\Double\FakeQuoter;
 
 #[CoversClass(DateTimeStringifier::class)]
 final class DateTimeStringifierTest extends TestCase
 {
+    private const DEPTH = 0;
+
     #[Test]
-    public function shouldNotConvertWhenNotInstanceOfDateTimeInterface(): void
+    public function itShouldNotStringifyRawValueWhenItIsNotInstanceOfDateTimeInterface(): void
     {
-        $stringifierMock = $this->createMock(Stringifier::class);
-        $stringifierMock
-            ->expects($this->never())
-            ->method('stringify');
-
-        $quoterMock = $this->createMock(Quoter::class);
-        $quoterMock
-            ->expects($this->never())
-            ->method('quote');
-
-        $dateTimeStringifier = new DateTimeStringifier($stringifierMock, $quoterMock, 'c');
+        $sut = new DateTimeStringifier(new FakeQuoter(), 'c');
 
-        self::assertNull($dateTimeStringifier->stringify('NotDateTimeInterface', 0));
+        self::assertNull($sut->stringify('NotDateTimeInterface', self::DEPTH));
     }
 
     #[Test]
-    #[DataProvider('validValuesProvider')]
-    public function shouldConvertDateTimeInterfaceToString(
+    #[DataProvider('stringableRawValuesProvider')]
+    public function itShouldStringifyRawValueWhenItIsInstanceOfDateTimeInterface(
         DateTimeInterface $raw,
         string $format,
-        string $expected
+        string $string
     ): void {
-        $depth = 0;
-
-        $formattedDateTime = $raw->format($format);
-
-        $stringifierMock = $this->createMock(Stringifier::class);
-        $stringifierMock
-            ->expects($this->once())
-            ->method('stringify')
-            ->with($formattedDateTime, $depth + 1)
-            ->willReturn($formattedDateTime);
+        $quoter = new FakeQuoter();
 
-        $quoterMock = $this->createMock(Quoter::class);
-        $quoterMock
-            ->expects($this->once())
-            ->method('quote')
-            ->with($expected)
-            ->willReturn($expected);
+        $sut = new DateTimeStringifier($quoter, $format);
 
-        $dateTimeStringifier = new DateTimeStringifier($stringifierMock, $quoterMock, $format);
+        $actual = $sut->stringify($raw, self::DEPTH);
+        $expected = $quoter->quote($string, self::DEPTH);
 
-        self::assertSame($expected, $dateTimeStringifier->stringify($raw, $depth));
+        self::assertSame($expected, $actual);
     }
 
     /**
-     * @return mixed[][]
+     * @return array<int, array{0: DateTimeInterface, 1: string, 2: string}>
      */
-    public static function validValuesProvider(): array
+    public static function stringableRawValuesProvider(): array
     {
         $dateTime = new DateTime('2017-12-31T23:59:59+00:00');
         $dateTimeImmutable = DateTimeImmutable::createFromMutable($dateTime);
 
         return [
-            [$dateTime, 'd/m/Y', '[date-time] (DateTime: 31/12/2017)'],
-            [$dateTime, 'c', '[date-time] (DateTime: 2017-12-31T23:59:59+00:00)'],
-            [$dateTimeImmutable, 'Y-m-d H:i:s', '[date-time] (DateTimeImmutable: 2017-12-31 23:59:59)'],
+            [$dateTime, 'd/m/Y', 'DateTime { 31/12/2017 }'],
+            [$dateTime, 'c', 'DateTime { 2017-12-31T23:59:59+00:00 }'],
+            [$dateTime, DateTimeInterface::ATOM, 'DateTime { 2017-12-31T23:59:59+00:00 }'],
+            [$dateTimeImmutable, 'Y-m-d H:i:s', 'DateTimeImmutable { 2017-12-31 23:59:59 }'],
         ];
     }
 }