Bump phpstan/phpstan from 1.x to 2.x

I also upgrade other PHPStan extensions we're using, and fixed a few
issues.

Author: henriquemoody

composer.json

@@ -15,10 +15,10 @@
     },
     "require-dev": {
         "malukenho/docheader": "^0.1.7",
-        "phpstan/phpstan": "^1.10",
-        "phpstan/phpstan-deprecation-rules": "^1.1",
-        "phpstan/phpstan-phpunit": "^1.3",
-        "phpstan/phpstan-strict-rules": "^1.5",
+        "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-deprecation-rules": "^2.0",
+        "phpstan/phpstan-phpunit": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^12.5",
         "respect/coding-standard": "^4.0",
         "squizlabs/php_codesniffer": "^3.7"

src/Stringifiers/CallableStringifier.php

@@ -61,11 +61,11 @@ public function stringify(mixed $raw, int $depth): ?string
             return $this->buildMethod(new ReflectionMethod($raw, '__invoke'), $raw, $depth);
         }
 
-        if (is_array($raw) && is_object($raw[0])) {
+        if (is_array($raw) && is_object($raw[0]) && is_string($raw[1])) {
             return $this->buildMethod(new ReflectionMethod($raw[0], $raw[1]), $raw[0], $depth);
         }
 
-        if (is_array($raw) && is_string($raw[0])) {
+        if (is_array($raw) && is_string($raw[0]) && is_string($raw[1])) {
             return $this->buildStaticMethod(new ReflectionMethod($raw[0], $raw[1]), $depth);
         }
 
@@ -81,7 +81,7 @@ public function stringify(mixed $raw, int $depth): ?string
         return $this->buildFunction(new ReflectionFunction($raw), $depth);
     }
 
-    public function buildFunction(ReflectionFunction $raw, int $depth): ?string
+    public function buildFunction(ReflectionFunction $raw, int $depth): string
     {
         return $this->quoter->quote($this->buildSignature($raw, $depth), $depth);
     }

tests/fixtures/WithMethods.php

@@ -12,7 +12,7 @@ final class WithMethods
 {
     public function publicMethod(Iterator&Countable $parameter): ?static
     {
-        return new static();
+        return $parameter instanceof SplHeap ? new static() : null;
     }
 
     public static function publicStaticMethod(int|float $parameter): void

tests/src/Double/FakeStringifier.php

@@ -18,7 +18,7 @@
 
 final class FakeStringifier implements Stringifier
 {
-    public function stringify(mixed $raw, int $depth): ?string
+    public function stringify(mixed $raw, int $depth): string
     {
         return implode('.', ['fake', $depth, hash('crc32', serialize($raw))]);
     }

tests/unit/Stringifiers/CallableStringifierTest.php

@@ -24,9 +24,6 @@
 use function array_sum;
 use function sprintf;
 
-use const PHP_MAJOR_VERSION;
-use const PHP_MINOR_VERSION;
-
 #[CoversClass(CallableStringifier::class)]
 final class CallableStringifierTest extends TestCase
 {
@@ -76,10 +73,6 @@ public function itShouldStringifyWhenRawValueIsCallableWithDefaultValues(): void
     #[Test]
     public function itShouldStringifyWhenRawValueIsCallableThatDoesNotHaveAnAccessibleDefaultValue(): void
     {
-        if ([8, 1] !== [PHP_MAJOR_VERSION, PHP_MINOR_VERSION]) {
-            self::markTestSkipped('This test is not applicable to PHP 8.1+');
-        }
-
         $raw = 'array_walk';
 
         $quoter = new FakeQuoter();
@@ -88,7 +81,7 @@ public function itShouldStringifyWhenRawValueIsCallableThatDoesNotHaveAnAccessib
 
         $actual = $sut->stringify($raw, self::DEPTH);
         $expected = $quoter->quote(
-            'array_walk(object|array &$array, callable $callback, ?mixed $arg = fake.1.cbade92e): bool',
+            'array_walk(object|array &$array, callable $callback, ?mixed $arg = fake.1.cbade92e): true',
             self::DEPTH
         );