Change how to stringify resources

Considering that we use "[]" for arrays, removing it from the resources
makes sense. It also makes sense to use something else other than "()"
and "<>" makes the most sense also because it's familiar, as in
docblocks, we use "<>" to specify types.

Signed-off-by: Henrique Moody <[email protected]>

Author: henriquemoody

src/Stringifiers/ResourceStringifier.php

@@ -30,12 +30,6 @@ public function stringify(mixed $raw, int $depth): ?string
             return null;
         }
 
-        return $this->quoter->quote(
-            sprintf(
-                '[resource] (%s)',
-                get_resource_type($raw)
-            ),
-            $depth
-        );
+        return $this->quoter->quote(sprintf('resource <%s>', get_resource_type($raw)), $depth);
     }
 }

tests/integration/stringify-array.phpt

@@ -25,4 +25,4 @@ output([
 ]);
 ?>
 --EXPECT--
-`[1, NULL, [1.0, [[resource] (stream), ..., []]], FALSE, [object] (stdClass: []), ...]`
+`[1, NULL, [1.0, [resource <stream>, ..., []]], FALSE, [object] (stdClass: []), ...]`

tests/integration/stringify-resource.phpt

@@ -8,4 +8,4 @@ require 'vendor/autoload.php';
 output(tmpfile());
 ?>
 --EXPECT--
-`[resource] (stream)`
+`resource <stream>`

tests/unit/Stringifiers/ResourceStringifierTest.php

@@ -13,47 +13,34 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
-use Respect\Stringifier\Quoter;
 use Respect\Stringifier\Stringifiers\ResourceStringifier;
+use Respect\Stringifier\Test\Double\FakeQuoter;
 
 use function tmpfile;
 
 #[CoversClass(ResourceStringifier::class)]
 final class ResourceStringifierTest extends TestCase
 {
+    private const DEPTH = 0;
+
     #[Test]
-    public function shouldNotConvertToStringWhenRawValueIsNotResource(): void
+    public function itShouldNotStringifyRawValueWhenItIsNotOfTypeResource(): void
     {
-        $raw = true;
-        $depth = 0;
-
-        $quoterMock = $this->createMock(Quoter::class);
-        $quoterMock
-            ->expects($this->never())
-            ->method('quote');
+        $sut = new ResourceStringifier(new FakeQuoter());
 
-        $resourceStringifier = new ResourceStringifier($quoterMock);
-
-        self::assertNull($resourceStringifier->stringify($raw, $depth));
+        self::assertNull($sut->stringify(true, self::DEPTH));
     }
 
     #[Test]
-    public function shouldConvertToStringWhenRawValueIsNotResource(): void
+    public function itShouldStringifyRawValueWhenItIsOfTypeResource(): void
     {
-        $raw = tmpfile();
-        $depth = 0;
-
-        $expected = '[resource] (stream)';
+        $quoter = new FakeQuoter();
 
-        $quoterMock = $this->createMock(Quoter::class);
-        $quoterMock
-            ->expects($this->once())
-            ->method('quote')
-            ->with($expected, $depth)
-            ->willReturn($expected);
+        $sut = new ResourceStringifier($quoter);
 
-        $resourceStringifier = new ResourceStringifier($quoterMock);
+        $actual = $sut->stringify(tmpfile(), self::DEPTH);
+        $expected = $quoter->quote('resource <stream>', self::DEPTH);
 
-        self::assertSame($expected, $resourceStringifier->stringify($raw, $depth));
+        self::assertSame($expected, $actual);
     }
 }