Skip to content

Commit 4231729

Browse files
committed
Remove unused argument from Renderer::render()
Apparently, we were not using the argument anywhere, but I didn't notice that before.
1 parent 82e0722 commit 4231729

File tree

4 files changed

+5
-17
lines changed

4 files changed

+5
-17
lines changed

library/Message/Renderer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@
1313

1414
interface Renderer
1515
{
16-
public function render(Result $result, Translator $translator, string|null $template = null): string;
16+
public function render(Result $result, Translator $translator): string;
1717
}

library/Message/StandardRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public function __construct(
3333
) {
3434
}
3535

36-
public function render(Result $result, Translator $translator, string|null $template = null): string
36+
public function render(Result $result, Translator $translator): string
3737
{
3838
$parameters = $result->parameters;
3939
$parameters['path'] = $result->path !== null ? Quoted::fromPath($result->path) : null;
@@ -51,7 +51,7 @@ function (array $matches) use ($parameters, $translator) {
5151

5252
return $this->placeholder($matches[1], $parameters[$matches[1]], $translator, $matches[3] ?? null);
5353
},
54-
$translator->translate($template ?? $this->getTemplateMessage($result)),
54+
$translator->translate($this->getTemplateMessage($result)),
5555
);
5656

5757
if (!$result->hasCustomTemplate() && $result->adjacent !== null) {

tests/library/Message/TestingMessageRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
final class TestingMessageRenderer implements Renderer
1717
{
18-
public function render(Result $result, Translator $translator, string|null $template = null): string
18+
public function render(Result $result, Translator $translator): string
1919
{
20-
return $template ?? $result->template;
20+
return $result->template;
2121
}
2222
}

tests/unit/Message/StandardRendererTest.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,6 @@ public function itShouldRenderResultWithCustomTemplate(): void
3232
self::assertSame($result->template, $renderer->render($result, new DummyTranslator()));
3333
}
3434

35-
#[Test]
36-
public function itShouldRenderResultOverwritingCustomTemplateWhenTemplateIsPassedAsAnArgument(): void
37-
{
38-
$renderer = new StandardRenderer(new TestingStringifier());
39-
40-
$template = 'This is my brand new template';
41-
42-
$result = (new ResultBuilder())->template('This is my template')->build();
43-
44-
self::assertSame($template, $renderer->render($result, new DummyTranslator(), $template));
45-
}
46-
4735
#[Test]
4836
public function itShouldRenderResultProcessingParametersInTheTemplate(): void
4937
{

0 commit comments

Comments
 (0)