Move important value objects to the root namespace

henriquemoody · henriquemoody · commit bf9b970e2476 · 2025-12-21T11:14:47.000+01:00
The `Id`, `Name`, and `Path` value objects are not only message-related
concerns, they're part of the core of the library, hence it makes sense
to place them at the root namespace.
diff --git a/library/Id.php b/library/Id.php
@@ -7,9 +7,7 @@
 
 declare(strict_types=1);
 
-namespace Respect\Validation\Message\Placeholder;
-
-use Respect\Validation\Rule;
+namespace Respect\Validation;
 
 use function lcfirst;
 use function strrchr;
diff --git a/library/Message/InterpolationRenderer.php b/library/Message/InterpolationRenderer.php
@@ -12,8 +12,8 @@
 use ReflectionClass;
 use Respect\Stringifier\Stringifier;
 use Respect\Validation\Message\Placeholder\Listed;
-use Respect\Validation\Message\Placeholder\Name;
 use Respect\Validation\Message\Placeholder\Quoted;
+use Respect\Validation\Name;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 
diff --git a/library/Message/Placeholder/Quoted.php b/library/Message/Placeholder/Quoted.php
@@ -12,17 +12,7 @@
 final readonly class Quoted
 {
     public function __construct(
-        private string $value,
+        public string $value,
     ) {
     }
-
-    public static function fromPath(int|string $path): self
-    {
-        return new self('.' . $path);
-    }
-
-    public function getValue(): string
-    {
-        return $this->value;
-    }
 }
diff --git a/library/Message/Stringifier/NameStringifier.php b/library/Message/Stringifier/NameStringifier.php
@@ -10,7 +10,7 @@
 namespace Respect\Validation\Message\Stringifier;
 
 use Respect\Stringifier\Stringifier;
-use Respect\Validation\Message\Placeholder\Name;
+use Respect\Validation\Name;
 
 use function sprintf;
 
diff --git a/library/Message/Stringifier/PathStringifier.php b/library/Message/Stringifier/PathStringifier.php
@@ -11,7 +11,7 @@
 
 use Respect\Stringifier\Quoter;
 use Respect\Stringifier\Stringifier;
-use Respect\Validation\Message\Placeholder\Path;
+use Respect\Validation\Path;
 
 use function array_reverse;
 use function implode;
diff --git a/library/Message/Stringifier/QuotedStringifier.php b/library/Message/Stringifier/QuotedStringifier.php
@@ -26,6 +26,6 @@ public function stringify(mixed $raw, int $depth): string|null
             return null;
         }
 
-        return $this->quoter->quote($raw->getValue(), $depth);
+        return $this->quoter->quote($raw->value, $depth);
     }
 }
diff --git a/library/Name.php b/library/Name.php
@@ -7,7 +7,7 @@
 
 declare(strict_types=1);
 
-namespace Respect\Validation\Message\Placeholder;
+namespace Respect\Validation;
 
 final readonly class Name
 {
diff --git a/library/Path.php b/library/Path.php
@@ -7,7 +7,7 @@
 
 declare(strict_types=1);
 
-namespace Respect\Validation\Message\Placeholder;
+namespace Respect\Validation;
 
 final class Path
 {
diff --git a/library/Result.php b/library/Result.php
@@ -9,9 +9,6 @@
 
 namespace Respect\Validation;
 
-use Respect\Validation\Message\Placeholder\Id;
-use Respect\Validation\Message\Placeholder\Name;
-use Respect\Validation\Message\Placeholder\Path;
 use Respect\Validation\Rules\Core\Nameable;
 
 use function array_filter;
diff --git a/library/Rules/Attributes.php b/library/Rules/Attributes.php
@@ -12,7 +12,7 @@
 use Attribute;
 use ReflectionAttribute;
 use ReflectionObject;
-use Respect\Validation\Message\Placeholder\Id;
+use Respect\Validation\Id;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 use Respect\Validation\Rules\Core\Reducer;
diff --git a/library/Rules/Core/Nameable.php b/library/Rules/Core/Nameable.php
@@ -9,7 +9,7 @@
 
 namespace Respect\Validation\Rules\Core;
 
-use Respect\Validation\Message\Placeholder\Name;
+use Respect\Validation\Name;
 
 interface Nameable
 {
diff --git a/library/Rules/Core/Reducer.php b/library/Rules/Core/Reducer.php
@@ -9,7 +9,7 @@
 
 namespace Respect\Validation\Rules\Core;
 
-use Respect\Validation\Message\Placeholder\Name;
+use Respect\Validation\Name;
 use Respect\Validation\Rule;
 use Respect\Validation\Rules\AllOf;
 use Respect\Validation\Rules\Named;
diff --git a/library/Rules/Each.php b/library/Rules/Each.php
@@ -10,8 +10,8 @@
 namespace Respect\Validation\Rules;
 
 use Attribute;
-use Respect\Validation\Message\Placeholder\Path;
 use Respect\Validation\Message\Template;
+use Respect\Validation\Path;
 use Respect\Validation\Result;
 use Respect\Validation\Rules\Core\FilteredNonEmptyArray;
 
diff --git a/library/Rules/Key.php b/library/Rules/Key.php
@@ -10,7 +10,7 @@
 namespace Respect\Validation\Rules;
 
 use Attribute;
-use Respect\Validation\Message\Placeholder\Path;
+use Respect\Validation\Path;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 use Respect\Validation\Rules\Core\KeyRelated;
diff --git a/library/Rules/KeyExists.php b/library/Rules/KeyExists.php
@@ -11,8 +11,8 @@
 
 use ArrayAccess;
 use Attribute;
-use Respect\Validation\Message\Placeholder\Path;
 use Respect\Validation\Message\Template;
+use Respect\Validation\Path;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 use Respect\Validation\Rules\Core\KeyRelated;
diff --git a/library/Rules/Named.php b/library/Rules/Named.php
@@ -10,7 +10,7 @@
 namespace Respect\Validation\Rules;
 
 use Attribute;
-use Respect\Validation\Message\Placeholder\Name;
+use Respect\Validation\Name;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 use Respect\Validation\Rules\Core\Nameable;
diff --git a/library/Rules/Property.php b/library/Rules/Property.php
@@ -11,7 +11,7 @@
 
 use Attribute;
 use ReflectionObject;
-use Respect\Validation\Message\Placeholder\Path;
+use Respect\Validation\Path;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 use Respect\Validation\Rules\Core\Wrapper;
diff --git a/library/Rules/PropertyExists.php b/library/Rules/PropertyExists.php
@@ -11,8 +11,8 @@
 
 use Attribute;
 use ReflectionObject;
-use Respect\Validation\Message\Placeholder\Path;
 use Respect\Validation\Message\Template;
+use Respect\Validation\Path;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 
diff --git a/library/Validator.php b/library/Validator.php
@@ -11,7 +11,6 @@
 
 use Respect\Validation\Exceptions\ValidationException;
 use Respect\Validation\Message\ArrayFormatter;
-use Respect\Validation\Message\Placeholder\Name;
 use Respect\Validation\Message\StringFormatter;
 use Respect\Validation\Message\Translator;
 use Respect\Validation\Mixins\Builder;
diff --git a/tests/library/Builders/ResultBuilder.php b/tests/library/Builders/ResultBuilder.php
@@ -9,9 +9,9 @@
 
 namespace Respect\Validation\Test\Builders;
 
-use Respect\Validation\Message\Placeholder\Id;
-use Respect\Validation\Message\Placeholder\Name;
-use Respect\Validation\Message\Placeholder\Path;
+use Respect\Validation\Id;
+use Respect\Validation\Name;
+use Respect\Validation\Path;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 use Respect\Validation\Test\Rules\Stub;
diff --git a/tests/unit/Message/Formatter/OnlyFailedChildrenResultFilterTest.php b/tests/unit/Message/Formatter/OnlyFailedChildrenResultFilterTest.php
@@ -11,8 +11,8 @@
 
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Test;
-use Respect\Validation\Message\Placeholder\Path;
 use Respect\Validation\OnlyFailedChildrenResultFilter;
+use Respect\Validation\Path;
 use Respect\Validation\Result;
 use Respect\Validation\Test\Builders\ResultBuilder;
 use Respect\Validation\Test\TestCase;
diff --git a/tests/unit/Message/Formatter/TemplateResolverTest.php b/tests/unit/Message/Formatter/TemplateResolverTest.php
@@ -12,7 +12,7 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Test;
 use Respect\Validation\Exceptions\ComponentException;
-use Respect\Validation\Message\Placeholder\Path;
+use Respect\Validation\Path;
 use Respect\Validation\Test\Builders\ResultBuilder;
 use Respect\Validation\Test\TestCase;
 use stdClass;
diff --git a/tests/unit/Message/InterpolationRendererTest.php b/tests/unit/Message/InterpolationRendererTest.php
@@ -11,9 +11,9 @@
 
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Test;
-use Respect\Validation\Message\Placeholder\Name;
 use Respect\Validation\Message\Translator\ArrayTranslator;
 use Respect\Validation\Message\Translator\DummyTranslator;
+use Respect\Validation\Name;
 use Respect\Validation\Test\Builders\ResultBuilder;
 use Respect\Validation\Test\Message\TestingStringifier;
 use Respect\Validation\Test\TestCase;
diff --git a/tests/unit/Message/Stringifier/QuotedStringifierTest.php b/tests/unit/Message/Stringifier/QuotedStringifierTest.php
@@ -37,7 +37,7 @@ public function itShouldStringifyWhenValueIsAnInstanceOfQuoted(string $value): v
         $quoter = new StandardQuoter(1);
         $stringifier = new QuotedStringifier($quoter);
 
-        $expected = $quoter->quote($quoted->getValue(), 0);
+        $expected = $quoter->quote($quoted->value, 0);
         $actual = $stringifier->stringify($quoted, 0);
 
         self::assertSame($expected, $actual);
diff --git a/tests/unit/Rules/NotTest.php b/tests/unit/Rules/NotTest.php
@@ -12,7 +12,7 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\Test;
-use Respect\Validation\Message\Placeholder\Id;
+use Respect\Validation\Id;
 use Respect\Validation\Test\Rules\Stub;
 use Respect\Validation\Test\RuleTestCase;
 

Original file line number	Diff line number	Diff line change
`@@ -12,17 +12,7 @@`
`12`	`12`	`final readonly class Quoted`
`13`	`13`	`{`
`14`	`14`	`public function __construct(`
`15`		`- private string $value,`
	`15`	`+ public string $value,`
`16`	`16`	`) {`
`17`	`17`	`}`
`18`		`-`
`19`		`- public static function fromPath(int\|string $path): self`
`20`		`- {`
`21`		`- return new self('.' . $path);`
`22`		`- }`
`23`		`-`
`24`		`- public function getValue(): string`
`25`		`- {`
`26`		`- return $this->value;`
`27`		`- }`
`28`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,6 @@ public function stringify(mixed $raw, int $depth): string\|null`
`26`	`26`	`return null;`
`27`	`27`	`}`
`28`	`28`
`29`		`- return $this->quoter->quote($raw->getValue(), $depth);`
	`29`	`+ return $this->quoter->quote($raw->value, $depth);`
`30`	`30`	`}`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`declare(strict_types=1);`
`9`	`9`
`10`		`-namespace Respect\Validation\Message\Placeholder;`
	`10`	`+namespace Respect\Validation;`
`11`	`11`
`12`	`12`	`final readonly class Name`
`13`	`13`	`{`