#134: Sporadically ringing sound for incoming call isn't heard

Author: atsakiridis

restcomm.android.client.sdk/src/main/java/org/mobicents/restcomm/android/client/sdk/RCDevice.java

@@ -278,7 +278,7 @@ public void run() {
                     DeviceImpl.GetInstance().Shutdown();
                 }
             };
-            mainHandler.postDelayed(myRunnable, 2000);
+            mainHandler.postDelayed(myRunnable, 500);
         }
         state = DeviceState.OFFLINE;
     }

sipua/src/main/java/org/mobicents/restcomm/android/sipua/impl/SoundManager.java

@@ -87,6 +87,7 @@ public void run() {
 				int result = audioManager.requestAudioFocus(sm, AudioManager.STREAM_MUSIC, AudioManager.AUDIOFOCUS_GAIN_TRANSIENT);
 				if (result == AudioManager.AUDIOFOCUS_REQUEST_GRANTED) {
 					ringingPlayer.start();
+					Log.i(TAG, "startRinging start()");
 				}
 			}
 		};
@@ -100,16 +101,19 @@ public void stopRinging()
 		Runnable myRunnable = new Runnable() {
 			@Override
 			public void run() {
-				ringingPlayer.pause();
-				// Abandon audio focus when playback complete
-				audioManager.abandonAudioFocus(sm);
+				if (ringingPlayer.isPlaying()) {
+					ringingPlayer.pause();
+					// Abandon audio focus when playback complete
+					audioManager.abandonAudioFocus(sm);
+					Log.i(TAG, "stopRinging pause()");
+				}
 			}
 		};
 		mainHandler.post(myRunnable);
 	}
 	public void startCalling()
 	{
-		if (outgoingOn == false) {
+		if (!outgoingOn) {
 			return;
 		}
 
@@ -122,6 +126,7 @@ public void run() {
 				int result = audioManager.requestAudioFocus(sm, AudioManager.STREAM_MUSIC, AudioManager.AUDIOFOCUS_GAIN_TRANSIENT);
 				if (result == AudioManager.AUDIOFOCUS_REQUEST_GRANTED) {
 					callingPlayer.start();
+					Log.i(TAG, "startCalling start()");
 				}
 			}
 		};
@@ -135,16 +140,19 @@ public void stopCalling()
 		Runnable myRunnable = new Runnable() {
 			@Override
 			public void run() {
-				callingPlayer.pause();
-				// Abandon audio focus when playback complete
-				audioManager.abandonAudioFocus(sm);
+				if (callingPlayer.isPlaying()) {
+					callingPlayer.pause();
+					// Abandon audio focus when playback complete
+					audioManager.abandonAudioFocus(sm);
+					Log.i(TAG, "stopCalling pause()");
+				}
 			}
 		};
 		mainHandler.post(myRunnable);
 	}
 	public void incomingMessage()
 	{
-		if (incomingOn == false) {
+		if (!incomingOn) {
 			return;
 		}
 
@@ -157,6 +165,7 @@ public void run() {
 				int result = audioManager.requestAudioFocus(sm, AudioManager.STREAM_MUSIC, AudioManager.AUDIOFOCUS_GAIN_TRANSIENT);
 				if (result == AudioManager.AUDIOFOCUS_REQUEST_GRANTED) {
 					messagePlayer.start();
+					Log.i(TAG, "incomingMessage start()");
 				}
 			}
 		};
@@ -165,7 +174,7 @@ public void run() {
 
 	public void outgoingMessage()
 	{
-		if (outgoingOn == false) {
+		if (!outgoingOn) {
 			return;
 		}
 
@@ -178,6 +187,7 @@ public void run() {
 				int result = audioManager.requestAudioFocus(sm, AudioManager.STREAM_MUSIC, AudioManager.AUDIOFOCUS_GAIN_TRANSIENT);
 				if (result == AudioManager.AUDIOFOCUS_REQUEST_GRANTED) {
 					messagePlayer.start();
+					Log.i(TAG, "outgoingMessage start()");
 				}
 			}
 		};