Refactor copy/paste feature following review

 - New HandleShortcut function implemented to ViewModel
 - Improve code to match repository naming convention
 - Prevent from using paste feature in the pointer finder
 - Using of ParseHex instead of iswxdigit and refactoring logic based on this change

Author: Vancleeff

src/ui/viewmodels/MemoryViewerViewModel.hh

@@ -160,6 +160,9 @@ public:
     /// </summary>
     void SetSize(MemSize value) { SetValue(SizeProperty, ra::etoi(value)); }
 
+    bool IsReadOnly() const noexcept { return m_bReadOnly; }
+    void SetReadOnly(bool value) noexcept { m_bReadOnly = value; }
+
     void OnClick(int nX, int nY);
     void OnResized(int nWidth, int nHeight);
     bool OnChar(char c);

src/ui/win32/bindings/ControlBinding.cpp

@@ -5,8 +5,6 @@
 #include "services\ServiceLocator.hh"
 #include "services\IClock.hh"
 
-#include "ui\viewmodels\MessageBoxViewModel.hh"
-
 #include "ui\win32\Desktop.hh"
 
 namespace ra {

src/ui/win32/bindings/ControlBinding.hh

@@ -5,6 +5,8 @@
 #include "ui\BindingBase.hh"
 #include "ui\win32\DialogBase.hh"
 
+#include "ui\viewmodels\MessageBoxViewModel.hh"
+
 namespace ra {
 namespace ui {
 namespace win32 {

src/ui/win32/bindings/MemoryViewerControlBinding.cpp

@@ -140,6 +140,8 @@ bool MemoryViewerControlBinding::OnKeyDown(UINT nChar)
 
     if (!m_pViewModel.IsAddressFixed())
         bHandled = HandleNavigation(nChar);
+    if (!bHandled)
+        bHandled = HandleShortcut(nChar);
 
     m_bSuppressMemoryViewerInvalidate = false;
 
@@ -232,52 +234,64 @@ bool MemoryViewerControlBinding::HandleNavigation(UINT nChar)
             }
             return true;
 
+        default:
+            return false;
+    }
+}
+
+bool MemoryViewerControlBinding::HandleShortcut(UINT nChar)
+{
+    const bool bShiftHeld = (GetKeyState(VK_SHIFT) < 0);
+    const bool bControlHeld = (GetKeyState(VK_CONTROL) < 0);
+
+    switch (nChar)
+    {
         case 'C':
             if (bControlHeld)
             {
                 const auto& pEmulatorContext = ra::services::ServiceLocator::Get<ra::data::context::EmulatorContext>();
-                const auto iValue = pEmulatorContext.ReadMemory(m_pViewModel.GetAddress(), m_pViewModel.GetSize());
-                std::wstring sValue = ra::data::MemSizeFormat(iValue, m_pViewModel.GetSize(), MemFormat::Hex);
+                const auto nValue = pEmulatorContext.ReadMemory(m_pViewModel.GetAddress(), m_pViewModel.GetSize());
+                std::wstring sValue = ra::data::MemSizeFormat(nValue, m_pViewModel.GetSize(), MemFormat::Hex);
 
                 ra::services::ServiceLocator::Get<ra::services::IClipboard>().SetText(ra::Widen(sValue));
             }
             return true;
 
         case 'V':
-            if (bControlHeld)
+            if (bControlHeld and !m_pViewModel.IsReadOnly())
             {
                 auto nAddress = m_pViewModel.GetAddress();
                 const auto& pEmulatorContext = ra::services::ServiceLocator::Get<ra::data::context::EmulatorContext>();
                 std::wstring sClipboardText = ra::services::ServiceLocator::Get<ra::services::IClipboard>().GetText();
-                auto n = m_pViewModel.GetSize();
+                const auto nNibblesForSize = ra::data::MemSizeBytes(m_pViewModel.GetSize());
+                std::vector<std::uint32_t> v_nValues;
+                std::wstring sError;
 
                 if (sClipboardText.empty())
                     return false;
 
-                // Check if the string is a valid hexadecimal value
-                for (wchar_t ch : sClipboardText)
-                    if (!iswxdigit(ch)) return false;
-
-                // Padding zeroes depending if shift is pressed (strict mode) or not (replace mode)
-                if (bShiftHeld)
+                // Split the clipboard value into substrings matching the current size and check if they're valid hexadecimal values
+                for (size_t i = 0; i < sClipboardText.size(); i += nNibblesForSize * 2)
                 {
-                    const auto nNibblesForSize = ra::data::MemSizeBytes(m_pViewModel.GetSize()) * 2;
-
-                    if (nNibblesForSize < sClipboardText.length())
-                        sClipboardText = sClipboardText.substr(sClipboardText.length() - nNibblesForSize);
-                    else
+                    std::wstring sSubString = sClipboardText.substr(i, nNibblesForSize * 2);
+                    unsigned int nValue;
+                    
+                    if (!ra::ParseHex(sSubString, 0xFFFFFFFF, nValue, sError))
                     {
-                        std::wstring sPadding(nNibblesForSize - sClipboardText.length(), L'0');
-                        sClipboardText = (sPadding + sClipboardText);
+                        ra::ui::viewmodels::MessageBoxViewModel::ShowWarningMessage(L"Paste value failed", sError);
+                        return false;
                     }
-                }else 
-                    sClipboardText = sClipboardText.length() % 2 == 1 ? (L"0" + sClipboardText) : sClipboardText;
 
-                // Writing every byte separately considerably improves stability and enables long sequences to be pasted
-                for (int i = sClipboardText.length(); i != 0; i-=2)
+                    v_nValues.push_back(nValue);
+                }
+
+                for (auto nValue : v_nValues)
                 {
-                    std::wstring sValue = sClipboardText.substr(i - 2, 2);
-                    pEmulatorContext.WriteMemoryByte(nAddress++, std::stoi(sValue, 0, 16));
+                    //Single mode writes only the first value, multi mode (shift) writes every values
+                    pEmulatorContext.WriteMemory(nAddress, m_pViewModel.GetSize(), nValue);
+                    if (!bShiftHeld)
+                        break;
+                    nAddress += nNibblesForSize;
                 }
             }
             return true;

src/ui/win32/bindings/MemoryViewerControlBinding.hh

@@ -63,6 +63,7 @@ protected:
 
 private:
     bool HandleNavigation(UINT nChar);
+    bool HandleShortcut(UINT nChar);
     bool m_bSuppressMemoryViewerInvalidate = false;
 
     ra::ui::viewmodels::MemoryViewerViewModel& m_pViewModel;

src/ui/win32/bindings/NumericTextBoxBinding.hh

@@ -4,8 +4,6 @@
 
 #include "TextBoxBinding.hh"
 
-#include "ui\viewmodels\MessageBoxViewModel.hh"
-
 #include "RA_StringUtils.h"
 
 namespace ra {