fix(alerts): ignore FFXI (#4382)

https://discord.com/channels/476211979464343552/1458253117891149844/1458493450138947678

Author: wescopeland

app/Helpers/render/ticket.php

@@ -26,7 +26,6 @@ function ticketAvatar(
     $ticketStateClass = match ($safeTicket->state) {
         TicketState::Open, TicketState::Request => 'open',
         TicketState::Closed, TicketState::Resolved => 'closed',
-        default => '',
     };
 
     return avatar(
@@ -56,7 +55,6 @@ function renderTicketCard(int|Ticket $ticket): string
     $ticketStateClass = match ($ticket->state) {
         TicketState::Open, TicketState::Request => 'open',
         TicketState::Closed, TicketState::Resolved => 'closed',
-        default => '',
     };
 
     return "<div class='tooltip-body flex items-start' style='max-width: 400px'>" .

app/Support/Alerts/Listeners/TriggerSuspiciousBeatTimeAlert.php

@@ -34,6 +34,12 @@ public function handle(PlayerGameBeaten $event): void
 
         $game = $event->game;
 
+        // Final Fantasy XI supports retroactive unlocks.
+        // We use a regex so we don't match against XII or XIII.
+        if (preg_match('/^Final Fantasy XI($|[:\s\-])/', $game->title)) {
+            return;
+        }
+
         // Bail if we don't have a sufficient sample size.
         if ($game->times_beaten_hardcore < 20) {
             return;

tests/Feature/Support/Alerts/Listeners/TriggerSuspiciousBeatTimeAlertTest.php

@@ -80,4 +80,35 @@ public function testItDoesNotTriggerWhenTimeIsAboveThreshold(): void
         // Assert
         Queue::assertNothingPushed();
     }
+
+    public function testItDoesNotTriggerForFinalFantasyXIGames(): void
+    {
+        // Arrange
+        Queue::fake();
+
+        config(['services.discord.alerts_webhook.suspicious_beat_time' => 'https://discord.com/api/webhooks/test']);
+
+        $system = System::factory()->create();
+        $user = User::factory()->create();
+        $game = Game::factory()->create([
+            'title' => 'Final Fantasy XI: Rise of the Zilart',
+            'system_id' => $system->id,
+            'times_beaten_hardcore' => 100,
+            'median_time_to_beat_hardcore' => 3600,
+        ]);
+
+        PlayerGame::factory()->create([
+            'user_id' => $user->id,
+            'game_id' => $game->id,
+            'time_to_beat_hardcore' => 60, // would normally trigger an alert
+        ]);
+
+        $event = new PlayerGameBeaten($user, $game, hardcore: true);
+
+        // Act
+        (new TriggerSuspiciousBeatTimeAlert())->handle($event);
+
+        // Assert
+        Queue::assertNothingPushed();
+    }
 }