Skip to content

Commit 90d9cb1

Browse files
authored
Merge pull request #3541 from cmitu/simcoupe-updates
simcoupe: update the branch selection to fix building
2 parents 57b212d + cafba39 commit 90d9cb1

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

scriptmodules/emulators/simcoupe.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ rp_module_section="opt"
1818
rp_module_flags=""
1919

2020
function _get_branch_simcoupe() {
21-
local branch="master"
22-
# latest simcoupe requires cmake 3.8.2 - on Stretch older versions throw a cmake error about CXX17
21+
local branch="main"
22+
# latest simcoupe requires cmake 3.14 - on Stretch older versions throw a cmake error about CXX17
2323
# dialect support but actually seem to build ok. Lock systems with older cmake to 20200711 tag,
24-
# which builds ok on Raspbian Stretch and hopefully Ubuntu 18.04.
24+
# which builds ok on Raspbian Stretch, and systems with cmake 3.12 to 20210501, which builds ok on Ubuntu 18.04.
2525

2626
# Test using "apt-cache madison" as this code could be called when cmake isn't yet installed but correct version
2727
# is available - eg via update check with builder module which removes dependencies after building.
@@ -30,6 +30,8 @@ function _get_branch_simcoupe() {
3030
local cmake_ver=$(apt-cache madison cmake | cut -d\| -f2 | sort --version-sort | head -1 | xargs)
3131
if compareVersions "$cmake_ver" lt 3.8.2; then
3232
branch="20200711"
33+
elif compareVersions "$cmake_ver" lt 3.14; then
34+
branch="20210501"
3335
fi
3436
echo "$branch"
3537
}
@@ -44,6 +46,8 @@ function sources_simcoupe() {
4446

4547
function build_simcoupe() {
4648
cmake -DCMAKE_INSTALL_PREFIX="$md_inst" .
49+
# force the downloaded 'SAAsound' dependency to be statically linked
50+
sed -i 's/ SHARED//' _deps/saasound-src/CMakeLists.txt
4751
make clean
4852
make
4953
md_ret_require="$md_build/simcoupe"

0 commit comments

Comments
 (0)