builder - only build binaries when newer

Copy retropie.pkg to archive folder named as $md_id.pkg and use this in rp_hasNewerModule if no installed
package is found. Adjust the builder code to check for a newer source package to utilise this so we only
rebuild binaries as are needed.

Author: joolswills

scriptmodules/admin/builder.sh

@@ -26,15 +26,16 @@ function module_builder() {
         # eg scraper which fails as go1.8 doesn't work under qemu
         hasFlag "${__mod_info[$id/flags]}" "nobin" && continue
 
+        # if the module has no install_ function skip to the next module
         ! fnExists "install_${id}" && continue
 
-        # skip already built archives, so we can retry failed modules
-        [[ -f "$__tmpdir/archives/$__binary_path/${__mod_info[$id/type]}/$id.tar.gz" ]] && continue
+        # if there is a not a newer version, skip to the next module
+        ! rp_hasNewerModule "$id" "source" && continue
 
         # build, install and create binary archive.
         # initial clean in case anything was in the build folder when calling
         local mode
-        for mode in clean remove depends sources build install create_bin clean remove "depends remove"; do
+        for mode in clean depends sources build install create_bin clean remove "depends remove"; do
             # continue to next module if not available or an error occurs
             rp_callModule "$id" $mode || break
         done
@@ -108,6 +109,6 @@ function chroot_build_builder() {
                 /home/pi/RetroPie-Setup/retropie_packages.sh builder "$@"
         done
 
-        rsync -av "$md_build/$dist/home/pi/RetroPie-Setup/tmp/archives/" "$home/RetroPie-Setup/tmp/archives/"
+        rsync -av --exclude '*.pkg' "$md_build/$dist/home/pi/RetroPie-Setup/tmp/archives/" "$home/RetroPie-Setup/tmp/archives/"
     done
 }

scriptmodules/packages.sh

@@ -684,32 +684,37 @@ function rp_installBin() {
 function rp_createBin() {
     printHeading "Creating binary archive for $md_desc"
 
-    if [[ ! -d "$rootdir/$md_type/$md_id" ]]; then
-        printMsgs "console" "No install directory $rootdir/$md_type/$md_id - no archive created"
+    if [[ ! -d "$md_inst" ]]; then
+        printMsgs "console" "No install directory $md_inst - no archive created"
         return 1
     fi
 
-    if dirIsEmpty "$rootdir/$md_type/$md_id"; then
-        printMsgs "console" "Empty install directory $rootdir/$md_type/$md_id - no archive created"
+    if dirIsEmpty "$md_inst"; then
+        printMsgs "console" "Empty install directory $md_inst - no archive created"
         return 1
     fi
 
     local archive="$md_id.tar.gz"
     local dest="$__tmpdir/archives/$__binary_path/$md_type"
     mkdir -p "$dest"
     rm -f "$dest/$archive" "$dest/$archive.asc"
+    local ret=1
     if tar cvzf "$dest/$archive" -C "$rootdir/$md_type" "$md_id"; then
         if [[ -n "$__gpg_signing_key" ]]; then
             if signFile "$dest/$archive"; then
                 chown $user:$user "$dest/$archive" "$dest/$archive.asc"
-                return 0
+                ret=0
             fi
         else
-            return 0
+            ret=0
         fi
     fi
-    rm -f "$dest/$archive"
-    return 1
+    if [[ "$ret" -eq 0 ]]; then
+        cp "$md_inst/retropie.pkg" "$dest/$md_id.pkg"
+    else
+        rm -f "$dest/$archive"
+    fi
+    return "$ret"
 }
 
 function rp_hasModule() {
@@ -835,6 +840,12 @@ function rp_loadPackageInfo() {
     local load=0
     local pkg_file="$(rp_getInstallPath $id)/retropie.pkg"
 
+    local builder_pkg_file="$__tmpdir/archives/$__binary_path/${__mod_info[$id/type]}/$id.pkg"
+    # fallback to using package info for built binaries so the binary builder code can update only changed modules
+    if [[ ! -f "$pkg_file" && -f "$builder_pkg_file" ]]; then
+        pkg_file="$builder_pkg_file"
+    fi
+
     # if the pkg file is available, we will load the data in the next loop
     [[ -f "$pkg_file" ]] && load=1