system / packages - allow bypassing signing when creating binaries for testing

Also moved the retropie email used for checking to __gpg_retropie_key and use this rather than __gpg_signing_key
as we hardcode the install of the actual key - so the logic didn't make sense in the case of wanting to sign
with another key. But __gpg_signing_key can now be set to an empty string to bypass signing of binaries as used
by the build scripts. This is only useful for developers/testing binary creation on systems without our signing key.

Author: joolswills

scriptmodules/packages.sh

@@ -692,14 +692,18 @@ function rp_createBin() {
     local archive="$md_id.tar.gz"
     local dest="$__tmpdir/archives/$__binary_path/$md_type"
     mkdir -p "$dest"
-    rm -f "$dest/$archive"
+    rm -f "$dest/$archive" "$dest/$archive.asc"
     if tar cvzf "$dest/$archive" -C "$rootdir/$md_type" "$md_id"; then
-        if signFile "$dest/$archive"; then
-            chown $user:$user "$dest/$archive" "$dest/$archive.asc"
+        if [[ -n "$__gpg_signing_key" ]]; then
+            if signFile "$dest/$archive"; then
+                chown $user:$user "$dest/$archive" "$dest/$archive.asc"
+                return 0
+            fi
+        else
             return 0
         fi
     fi
-    rm -f "$dest/$archive" "$dest/$archive.asc"
+    rm -f "$dest/$archive"
     return 1
 }
 

scriptmodules/system.sh

@@ -74,8 +74,14 @@ function conf_binary_vars() {
 
     __archive_url="https://files.retropie.org.uk/archives"
 
-    [[ -z "$__gpg_signing_key" ]] && __gpg_signing_key="[email protected]"
-    if ! gpg --list-keys "$__gpg_signing_key" &>/dev/null; then
+    # set the gpg key used by RetroPie
+    __gpg_retropie_key="[email protected]"
+
+    # if __gpg_signing_key is not set, set to __gpg_retropie_key
+    [[ ! -v __gpg_signing_key ]] && __gpg_signing_key="$__gpg_retropie_key"
+
+    # if the RetroPie public key is not installed, install it.
+    if ! gpg --list-keys "$__gpg_retropie_key" &>/dev/null; then
         gpg --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys DC9D77FF8208FFC51D8F50CCF1B030906A3B0D31
     fi
 }