Revert "Make GI_GetCheats noexcept"

This reverts commit 199817b.

Author: kubaau

libs/s25main/GameInterface.h

@@ -37,5 +37,5 @@ class GameInterface
     /// Executes the construction of a road
     virtual void GI_BuildRoad() = 0;
 
-    virtual Cheats& GI_GetCheats() noexcept = 0;
+    virtual Cheats& GI_GetCheats() = 0;
 };

libs/s25main/desktops/dskGameInterface.h

@@ -84,7 +84,7 @@ class dskGameInterface :
     /// Baut die gewünschte bis jetzt noch visuelle Straße (schickt Anfrage an Server)
     void GI_BuildRoad() override;
 
-    Cheats& GI_GetCheats() noexcept override { return cheats_; }
+    Cheats& GI_GetCheats() override { return cheats_; }
 
     // Sucht einen Weg von road_point_x/y zu cselx/y und baut ihn ( nur visuell )
     // Bei Wasserwegen kann die Reichweite nicht bis zum gewünschten

tests/s25Main/integration/testCheats.cpp

@@ -52,21 +52,15 @@ MOCK_BASE_CLASS(MockGameInterface, GameInterface)
     MOCK_METHOD(GI_TeamWinner, 1)
     MOCK_METHOD(GI_StartRoadBuilding, 2)
     MOCK_METHOD(GI_CancelRoadBuilding, 0)
-    MOCK_METHOD(GI_BuildRoad, 0);
-
-    // can't mock noexcept function in turtle - working around it
-    MockGameInterface(Cheats & cheats) : cheats_{cheats} {}
-    Cheats & cheats_;
-    Cheats& GI_GetCheats() noexcept override
-    {
-        return cheats_;
-    }
+    MOCK_METHOD(GI_BuildRoad, 0)
+    MOCK_METHOD(GI_GetCheats, 0)
 };
 } // namespace
 
 BOOST_FIXTURE_TEST_CASE(CanToggleAllVisible_IfCheatModeIsOn_ButOnlyDisableAllVisible_IfCheatModeIsNotOn, CheatsFixture)
 {
-    MockGameInterface mgi{gameDesktop.GI_GetCheats()};
+    MockGameInterface mgi;
+    MOCK_EXPECT(mgi.GI_GetCheats).returns(std::ref(gameDesktop.GI_GetCheats()));
     MOCK_EXPECT(mgi.GI_UpdateMapVisibility).exactly(4); // because the actual toggling should occur 4 times
     world.SetGameInterface(&mgi);