Merge pull request #1771 from ottml/fix_clang_tidy_on_ci

Fix clang tidy on ci

Author: Flamefire

.clang-tidy

@@ -12,28 +12,58 @@ Checks: >-
   modernize-*,
   performance-*,
   readability-*,
+  -bugprone-assignment-in-if-condition,
+  -bugprone-casting-through-void,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-empty-catch,
+  -bugprone-implicit-widening-of-multiplication-result,
   -bugprone-narrowing-conversions,
+  -bugprone-optional-value-conversion,
+  -bugprone-reserved-identifier,
+  -bugprone-switch-missing-default-case,
   -bugprone-too-small-loop-variable,
+  -bugprone-unchecked-optional-access,
+  -bugprone-unhandled-exception-at-new,
+  -clang-analyzer-core.NonNullParamChecker,
+  -clang-analyzer-cplusplus.NewDeleteLeaks,
+  -clang-analyzer-optin.core.EnumCastOutOfRange,
   -clang-analyzer-osx.*,
+  -misc-confusable-identifiers,
+  -misc-const-correctness,
+  -misc-include-cleaner,
   -misc-non-private-member-variables-in-classes,
+  -misc-no-recursion,
   -misc-unused-parameters,
+  -misc-use-anonymous-namespace,
   -modernize-avoid-c-arrays,
+  -modernize-macro-to-enum,
   -modernize-raw-string-literal,
   -modernize-return-braced-init-list,
   -modernize-use-default-member-init,
   -modernize-use-emplace,
   -modernize-use-nodiscard,
   -modernize-use-override,
   -modernize-use-trailing-return-type,
+  -performance-avoid-endl,
+  -performance-enum-size,
+  -performance-move-const-arg,
+  -performance-no-int-to-ptr,
+  -readability-avoid-nested-conditional-operator,
+  -readability-avoid-return-with-void-value,
   -readability-braces-around-statements,
   -readability-convert-member-functions-to-static,
   -readability-else-after-return,
+  -readability-function-cognitive-complexity,
+  -readability-identifier-length,
   -readability-implicit-bool-conversion,
   -readability-isolate-declaration,
   -readability-magic-numbers,
   -readability-named-parameter,
+  -readability-redundant-casting,
   -readability-static-accessed-through-instance,
+  -readability-suspicious-call-argument,
   -readability-uppercase-literal-suffix,
+  -readability-use-anyofallof,
   -readability-identifier-naming,
   -clang-diagnostic-inconsistent-missing-override
 CheckOptions:
@@ -43,5 +73,8 @@ CheckOptions:
     value: 'Point<.*?>;MapPoint;Position;Extent;DrawPoint'
   - key: performance-unnecessary-value-param.AllowedTypes
     value: 'Point<.*?>;MapPoint;Position;Extent;DrawPoint'
-AnalyzeTemporaryDtors: false
+  - key: readability-function-cognitive-complexity.IgnoreMacros
+    value: true
+  - key: readability-simplify-boolean-expr.IgnoreMacros
+    value: true
 ...

external/libendian

@@ -142,7 +142,7 @@ driver::RawSoundHandle AudioSDL::LoadEffect(const std::string& filepath)
 
 driver::RawSoundHandle AudioSDL::LoadEffect(const std::vector<char>& data, const std::string& /*ext*/)
 {
-    SDL_RWops* rwOps = SDL_RWFromConstMem(&data[0], static_cast<int>(data.size()));
+    SDL_RWops* rwOps = SDL_RWFromConstMem(data.data(), static_cast<int>(data.size()));
     Mix_Chunk* sound = Mix_LoadWAV_RW(rwOps, true); //-V601
 
     if(sound == nullptr)

external/libsiedler2

@@ -20,8 +20,11 @@ template<typename T>
 struct RectBase
 {
     using position_type = Point<T>;
+    // Deactivated to bug in clang-tidy
+    // NOLINTBEGIN(modernize-type-traits)
     using extent_elem_type =
       typename std::conditional_t<std::is_integral_v<T>, std::make_unsigned<T>, std::common_type<T>>::type;
+    // NOLINTEND(modernize-type-traits)
     using extent_type = Point<extent_elem_type>;
     T left, top, right, bottom;
     constexpr RectBase() : RectBase(position_type::all(0), extent_type::all(0)) {}

external/libutil

@@ -35,8 +35,11 @@ namespace detail {
     void pushContainer(Serializer& ser, const T& container, long)
     {
         using Type = typename T::value_type;
+        // Deactivated to bug in clang-tidy
+        // NOLINTBEGIN(modernize-type-traits)
         using Integral =
           typename std::conditional_t<std::is_enum_v<Type>, std::underlying_type<Type>, std::common_type<Type>>::type;
+        // NOLINTEND(modernize-type-traits)
         for(const auto el : container)
         {
             // Cast also required for bool vector -.-

external/mygettext

@@ -132,10 +132,10 @@ bool captureBacktrace(DebugInfo::stacktrace_t& stacktrace, LPCONTEXT ctx) noexce
     return true;
 }
 #else
-bool captureBacktrace(DebugInfo::stacktrace_t& stacktrace, void*) noexcept
+bool captureBacktrace(DebugInfo::stacktrace_t& stacktrace, void*) noexcept(false)
 {
 #    if RTTR_BACKTRACE_HAS_FUNCTION
-    const auto num_frames = backtrace(&stacktrace[0], stacktrace.size());
+    const auto num_frames = backtrace(stacktrace.data(), stacktrace.size());
     stacktrace.resize(num_frames);
     return true;
 #    else
@@ -182,7 +182,7 @@ DebugInfo::~DebugInfo()
     sock.Close();
 }
 
-DebugInfo::stacktrace_t DebugInfo::GetStackTrace(void* ctx) noexcept
+DebugInfo::stacktrace_t DebugInfo::GetStackTrace(void* ctx) noexcept(false)
 {
 #ifndef RTTR_CONTEXT_PTR_TYPE
     using RTTR_CONTEXT_PTR_TYPE = void*;
@@ -267,7 +267,7 @@ bool DebugInfo::SendStackTrace(const stacktrace_t& stacktrace)
         endStacktrace.push_back(reinterpret_cast<littleVoid_t::value_type>(ptr));
 
     unsigned stacktraceLen = sizeof(littleVoid_t) * endStacktrace.size();
-    return SendString(reinterpret_cast<const char*>(&endStacktrace[0]), stacktraceLen);
+    return SendString(reinterpret_cast<const char*>(endStacktrace.data()), stacktraceLen);
 }
 
 bool DebugInfo::SendReplay()