GHA: Don't use HomeBrew Lua on OSX

5.4 is not supported by kaguya yet an older versions are not available.

Author: Flamefire

.github/workflows/unit-tests.yml

@@ -164,7 +164,7 @@ jobs:
           if [[ "${{runner.os}}" =~ macOS ]]; then
             echo "HOMEBREW_PREFIX=$HOMEBREW_PREFIX"
             echo "HOMEBREW_CELLAR=$HOMEBREW_CELLAR"
-            brew install cmake boost sdl2 sdl2_mixer gettext miniupnpc lua
+            brew install cmake boost sdl2 sdl2_mixer gettext miniupnpc
             echo "Available Boost installs: $(ls "$HOMEBREW_CELLAR/boost/")"
             # Use the latest (last folder)
             BOOST_ROOT=$(find "$HOMEBREW_CELLAR/boost/"* -maxdepth 0 -type d | tail -n1)

README.md

@@ -75,7 +75,7 @@ All of them can be installed with the package manager.
 - sdl2_mixer
 - gettext (make sure it is in your path with e.g. `brew link --force gettext`)
 - miniupnpc
-- lua 5.2
+- lua 5.1-5.3 (available via the `dev-tools` submodule included by default)
 
 All of them can be installed via homebrew
 

external/CMakeLists.txt

@@ -6,11 +6,16 @@ include(RttrTestingCfg)
 option(RTTR_EXTERNAL_BUILD_TESTING "Enable tests of external dependencies" OFF)
 set(BUILD_TESTING ${RTTR_EXTERNAL_BUILD_TESTING})
 
+set(include_devtools_default OFF)
 if(EXISTS ${CMAKE_CURRENT_LIST_DIR}/dev-tools/CMakeLists.txt AND NOT DEFINED RTTR_INCLUDE_DEVTOOLS)
-    message(STATUS "Precompiled binaries are available to use for development."
-                   "They are not compatible with all platforms though."
-                   "Configure with -DRTTR_INCLUDE_DEVTOOLS=ON to make them available to CMake."
-            )
+    if(APPLE) # Lua 5.2 required which is not easily available on OSX
+      set(include_devtools_default ON)
+    else()
+      message(STATUS "Precompiled binaries are available to use for development."
+                     "They are not compatible with all platforms though."
+                     "Configure with -DRTTR_INCLUDE_DEVTOOLS=ON to make them available to CMake."
+              )
+    endif()
 endif()
 option(RTTR_INCLUDE_DEVTOOLS "Include folder with precompiled binaries for development" OFF)
 if(RTTR_INCLUDE_DEVTOOLS)