Skip to content

Conversation

@ReubenJ
Copy link
Owner

@ReubenJ ReubenJ commented Feb 17, 2025

This PR adds two constraints on QN grammars

  • Constrain Ceil and Floor in QN grammar to not directly include a entity or constant
  • Forbid ceil(floor)

Related issues

There is no related issue.

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@ReubenJ ReubenJ added the enhancement New feature or request label Feb 17, 2025
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (462ea81) to head (08dbe41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   98.55%   98.61%   +0.06%     
==========================================
  Files           2        2              
  Lines         138      144       +6     
==========================================
+ Hits          136      142       +6     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReubenJ ReubenJ merged commit 2c14a15 into main Feb 18, 2025
4 checks passed
@ReubenJ ReubenJ deleted the feat/qn-constraints branch February 18, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants