Fix reduced timeouts being used for HTTP requests when a proxy URL is configured (#3188)

## Summary

- When a proxy URL is configured, fallback URLs are disabled
(`AppConfig.fallbackBaseURLs` is empty). However, the timeout manager
still applied the aggressive 5s/2s timeouts meant for endpoints with
fallback support.
- This caused proxy requests to time out with no fallback recovery path,
making the proxy unusable for slow connections.
- Added `hasProxyURL` parameter to
`HTTPTimeoutManager.getTimeoutForRequest()` so it uses the default
timeout when a proxy is active.

**Related PR:** RevenueCat/purchases-ios#6416

## Test plan

- [x] Added `getTimeoutForRequest returns DEFAULT_TIMEOUT_MS for
fallback-supporting endpoint when proxy URL is set`
- [x] Added `getTimeoutForRequest returns DEFAULT_TIMEOUT_MS after
timeout when proxy URL is set`
- [x] All 17 existing HTTPTimeoutManager tests pass

Author: rickvdl

purchases/src/main/kotlin/com/revenuecat/purchases/common/HTTPClient.kt

@@ -291,7 +291,10 @@ internal class HTTPClient(
                 debugLog { "HTTP request:\\n ${toCurlRequest(httpRequest)}" }
             }
 
-            val timeout = timeoutManager.getTimeoutForRequest(endpoint, isFallbackURL)
+            val timeout = timeoutManager.getTimeoutForRequest(
+                isFallback = isFallbackURL,
+                fallbackAvailable = endpoint.supportsFallbackBaseURLs && appConfig.fallbackBaseURLs.isNotEmpty(),
+            )
 
             connection = getConnection(httpRequest, timeout)
         } catch (e: MalformedURLException) {

purchases/src/main/kotlin/com/revenuecat/purchases/common/networking/HTTPTimeoutManager.kt

@@ -42,20 +42,19 @@ internal class HTTPTimeoutManager(
     private val lastTimeoutRequestTime = AtomicLong(0L)
 
     /**
-     * Calculates the timeout for a request based on the endpoint and whether it's a fallback call.
-     * @param endpoint The endpoint being requested
+     * Calculates the timeout for a request based on whether fallback URLs are available.
      * @param isFallback Whether this is a fallback request
+     * @param fallbackAvailable Whether fallback URLs are available for this request
      * @return The timeout in milliseconds
      */
-    fun getTimeoutForRequest(endpoint: Endpoint, isFallback: Boolean): Long {
+    fun getTimeoutForRequest(isFallback: Boolean, fallbackAvailable: Boolean): Long {
         // Check if reset is needed (10 minutes elapsed)
         if (shouldResetTimeout()) {
             resetTimeout()
         }
 
         val timeout = when {
-            isFallback -> DEFAULT_TIMEOUT_MS
-            !endpoint.supportsFallbackBaseURLs -> DEFAULT_TIMEOUT_MS
+            isFallback || !fallbackAvailable -> DEFAULT_TIMEOUT_MS
             lastTimeoutRequestTime.get() > 0L -> REDUCED_TIMEOUT_MS
             else -> SUPPORTED_FALLBACK_TIMEOUT_MS
         }

purchases/src/test/java/com/revenuecat/purchases/common/HTTPClientTest.kt

@@ -1091,7 +1091,7 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
         timeoutManager.recordRequestResult(
             HTTPTimeoutManager.RequestResult.TIMEOUT_ON_MAIN_BACKEND_FOR_FALLBACK_SUPPORTED_ENDPOINT
         )
-        assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = true))
             .isEqualTo(HTTPTimeoutManager.REDUCED_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
 
         // Setup successful response
@@ -1116,7 +1116,7 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
 
         // Verify timeout was reset
         assertThat(result.responseCode).isEqualTo(RCHTTPStatusCodes.SUCCESS)
-        assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = true))
             .isEqualTo(HTTPTimeoutManager.SUPPORTED_FALLBACK_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
         verify(exactly = 1) {
             timeoutManager.recordRequestResult(HTTPTimeoutManager.RequestResult.SUCCESS_ON_MAIN_BACKEND)
@@ -1135,7 +1135,7 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
         client = createClient(appConfig = appConfig, timeoutManager = timeoutManager)
 
         // Initially timeout should be default
-        assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = true))
             .isEqualTo(HTTPTimeoutManager.SUPPORTED_FALLBACK_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
 
         // Setup fallback server response
@@ -1184,7 +1184,7 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
 
             // Verify HTTPClient recorded TIMEOUT_ON_MAIN_BACKEND_FOR_FALLBACK_SUPPORTED_ENDPOINT
             assertThat(result.responseCode).isEqualTo(RCHTTPStatusCodes.SUCCESS)
-            assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+            assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = true))
                 .isEqualTo(HTTPTimeoutManager.REDUCED_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
             verify(exactly = 1) {
                 timeoutManager.recordRequestResult(
@@ -1207,7 +1207,7 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
         client = createClient(appConfig = appConfig, timeoutManager = timeoutManager)
 
         // Initially timeout should be default
-        assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = false))
             .isEqualTo(HTTPTimeoutManager.DEFAULT_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
 
         enqueue(
@@ -1231,10 +1231,10 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
             )
         }.isInstanceOf(SocketTimeoutException::class.java)
 
-        // Verify HTTPClient recorded TIMEOUT_ON_MAIN_BACKEND_WITH_FALLBACK
-        assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+        // Verify HTTPClient recorded OTHER_RESULT (not timeout for fallback endpoint)
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = false))
             .isEqualTo(HTTPTimeoutManager.DEFAULT_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
-        assertThat(timeoutManager.getTimeoutForRequest(Endpoint.GetProductEntitlementMapping, isFallback = false))
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = true))
             .isEqualTo(HTTPTimeoutManager.SUPPORTED_FALLBACK_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
         verify(exactly = 1) {
             timeoutManager.recordRequestResult(HTTPTimeoutManager.RequestResult.OTHER_RESULT)
@@ -1255,7 +1255,7 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
         timeoutManager.recordRequestResult(
             HTTPTimeoutManager.RequestResult.TIMEOUT_ON_MAIN_BACKEND_FOR_FALLBACK_SUPPORTED_ENDPOINT
         )
-        assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = true))
             .isEqualTo(HTTPTimeoutManager.REDUCED_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
 
         // Setup error response (non-timeout error)
@@ -1280,7 +1280,7 @@ internal class HTTPClientTest: BaseHTTPClientTest() {
 
         // Verify HTTPClient recorded OTHER_RESULT and did NOT reset timeout
         assertThat(result.responseCode).isEqualTo(RCHTTPStatusCodes.NOT_FOUND)
-        assertThat(timeoutManager.getTimeoutForRequest(endpoint, isFallback = false))
+        assertThat(timeoutManager.getTimeoutForRequest(isFallback = false, fallbackAvailable = true))
             .isEqualTo(HTTPTimeoutManager.REDUCED_TIMEOUT_MS / HTTPTimeoutManager.TEST_DIVIDER)
         verify(exactly = 1) {
             timeoutManager.recordRequestResult(HTTPTimeoutManager.RequestResult.OTHER_RESULT)