Paywall v2 `.onRestoreCompleted` not called

[DavidTiimo]

• I have updated Purchases SDK to the latest version
• I have read the Contribution Guidelines
• I have searched the Community
• I have read docs.revenuecat.com
• I have searched for existing Github issues

Describe the bug

In the following code snippet the print line will not be called. I have seen many issues here on GitHub and in the community regarding this issue with not much news on it. Some of them have replies from developers saying it was fixed in 5.17.0, but this is not true for me and for others I have seen.

RevenueCatUI.PaywallView(offering: offering, displayCloseButton: true)
 .onRestoreCompleted { _ in
     print("onRestoreCompleted")
 }

1. Environment
   1. Platform: iOS
   2. SDK version: 5.22.1
   3. StoreKit version:
      • StoreKit 1 (default on versions <5.0.0. Can be enabled in versions >=5.0.0 with .with(storeKitVersion: .storeKit1))
      • StoreKit 2 (default on versions >=5.0.0)
   4. OS version: iOS 18.4
   5. Xcode version: 16.3
   6. Device and/or simulator:
      • Device
      • Simulator
   7. Environment:
      • Sandbox
      • TestFlight
      • Production
   8. How widespread is the issue. Percentage of devices affected.
2. Debug logs that reproduce the issue. Complete logs with Purchases.logLevel = .verbose will help us debug this issue.

Logs here

3. Steps to reproduce, with a description of expected vs. actual behavior

Actual

• Add .onRestoreCompletedto a RevenueCatUI.PaywallView
• Click restore purchase button
• Nothing happens

Expected

• Add .onRestoreCompletedto a RevenueCatUI.PaywallView
• Click restore purchase button
• The closure in onRestoreCompleted is called

4. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)

Related:

• https://community.revenuecat.com/sdks-51/paywall-callbacks-never-called-5881
• https://community.revenuecat.com/sdks-51/onpurchasecompleted-handler-is-not-called-on-recent-version-of-revenuecat-ios-purchase5-18-6032
• https://community.revenuecat.com/sdks-51/onpurchasecompleted-not-being-called-in-swift-sdk-5880
  -https://community.revenuecat.com/sdks%2D51/restore%2Dcompletion%2Dhandlers%2Dnot%2Dfiring%2Din%2Dpresentpaywallifneeded%2D4674
• Clicking the Restore Purchase button in Paywalls doesn't get the user information #3511

5. Additional context
   Add any other context about the problem here.

[RCGitBot]

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

[dfmuir]

Came here to open this issue, so I am glad it was already created.

The issue seems to be that onRestoreCompleted is only called when the updated CustomerInfo has active subscriptions or non-subscriptions. As it stands, there is no event for when the restore operation completes successfully but did not restore anything (referred to by RC as restore_purchases_with_empty_result). In my app, I want to use this event to hide my loader, and potentially create an alert that says "Nothing restored".

Moving the call to self.purchaseHandler.setRestored(customerInfo) outside of the if success conditional in ButtonComponentView here resolves this issue.

Not sure how that will affect existing code, but there needs to be a way to handle this case.

[AndyDentFree]

It is not a Paywall V2 issue, I get it with V1. But the SDK pull request will #5253 that needs fixing.

Note that the original issue #4420 was closed back in Oct 2024 indicating it was intended behaviour:

At this time restoring purchases will not return a specific popup for when the user has no purchases to restore but I will pass this along to the team as feedback.