Skip to content

Commit 8b1923d

Browse files
vegarovegaro
authored
Remove flipper from tester (#950)
Several reasons for the removal: - We don't use it - I keep hitting an issue in iOS that Flipper uses a missing function <img width="260" alt="Screenshot 2024-03-20 at 17 24 22" src="https://github.com/RevenueCat/react-native-purchases/assets/664544/56d8e143-4c3f-4968-a1ed-449f26e00fae"> - It removes 10 iOS dependencies - The sample for the next version of RN doesn't have Flipper
1 parent 75fd868 commit 8b1923d

File tree

4 files changed

+5
-124
lines changed

4 files changed

+5
-124
lines changed

‎examples/purchaseTesterTypescript/android/app/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ android {
109109
dependencies {
110110
// The version of react-native is set by the React Native Gradle Plugin
111111
implementation("com.facebook.react:react-android")
112-
implementation("com.facebook.react:flipper-integration")
113112

114113
if (hermesEnabled.toBoolean()) {
115114
implementation("com.facebook.react:hermes-android")

‎examples/purchaseTesterTypescript/android/app/src/main/java/com/revenuecat/purchases_sample/MainApplication.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import com.facebook.react.ReactPackage
99
import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.load
1010
import com.facebook.react.defaults.DefaultReactHost.getDefaultReactHost
1111
import com.facebook.react.defaults.DefaultReactNativeHost
12-
import com.facebook.react.flipper.ReactNativeFlipper
1312
import com.facebook.soloader.SoLoader
1413

1514
class MainApplication : Application(), ReactApplication {
@@ -40,7 +39,6 @@ class MainApplication : Application(), ReactApplication {
4039
// If you opted-in for the New Architecture, we load the native entry point for this app.
4140
load()
4241
}
43-
ReactNativeFlipper.initializeFlipper(this, reactNativeHost.reactInstanceManager)
4442
}
4543
}
4644

‎examples/purchaseTesterTypescript/ios/Podfile

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,6 @@ require Pod::Executable.execute_command('node', ['-p',
88
platform :ios, min_ios_version_supported
99
prepare_react_native_project!
1010

11-
# If you are using a `react-native-flipper` your iOS build will fail when `NO_FLIPPER=1` is set.
12-
# because `react-native-flipper` depends on (FlipperKit,...) that will be excluded
13-
#
14-
# To fix this you can also exclude `react-native-flipper` using a `react-native.config.js`
15-
# ```js
16-
# module.exports = {
17-
# dependencies: {
18-
# ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
19-
# ```
20-
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled
21-
2211
linkage = ENV['USE_FRAMEWORKS']
2312
if linkage != nil
2413
Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
@@ -36,11 +25,6 @@ target 'PurchaseTester' do
3625

3726
use_react_native!(
3827
:path => config[:reactNativePath],
39-
# Enables Flipper.
40-
#
41-
# Note that if you have use_frameworks! enabled, Flipper will not work and
42-
# you should disable the next line.
43-
:flipper_configuration => flipper_config,
4428
# An absolute path to your application root.
4529
:app_path => "#{Pod::Config.instance.installation_root}/.."
4630
)

‎examples/purchaseTesterTypescript/ios/Podfile.lock

Lines changed: 5 additions & 105 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
PODS:
22
- boost (1.83.0)
3-
- CocoaAsyncSocket (7.6.5)
43
- DoubleConversion (1.1.6)
54
- FBLazyVector (0.73.5)
65
- FBReactNativeSpec (0.73.5):
@@ -10,69 +9,12 @@ PODS:
109
- React-Core (= 0.73.5)
1110
- React-jsi (= 0.73.5)
1211
- ReactCommon/turbomodule/core (= 0.73.5)
13-
- Flipper (0.201.0):
14-
- Flipper-Folly (~> 2.6)
15-
- Flipper-Boost-iOSX (1.76.0.1.11)
16-
- Flipper-DoubleConversion (3.2.0.1)
17-
- Flipper-Fmt (7.1.7)
18-
- Flipper-Folly (2.6.10):
19-
- Flipper-Boost-iOSX
20-
- Flipper-DoubleConversion
21-
- Flipper-Fmt (= 7.1.7)
22-
- Flipper-Glog
23-
- libevent (~> 2.1.12)
24-
- OpenSSL-Universal (= 1.1.1100)
25-
- Flipper-Glog (0.5.0.5)
26-
- Flipper-PeerTalk (0.0.4)
27-
- FlipperKit (0.201.0):
28-
- FlipperKit/Core (= 0.201.0)
29-
- FlipperKit/Core (0.201.0):
30-
- Flipper (~> 0.201.0)
31-
- FlipperKit/CppBridge
32-
- FlipperKit/FBCxxFollyDynamicConvert
33-
- FlipperKit/FBDefines
34-
- FlipperKit/FKPortForwarding
35-
- SocketRocket (~> 0.6.0)
36-
- FlipperKit/CppBridge (0.201.0):
37-
- Flipper (~> 0.201.0)
38-
- FlipperKit/FBCxxFollyDynamicConvert (0.201.0):
39-
- Flipper-Folly (~> 2.6)
40-
- FlipperKit/FBDefines (0.201.0)
41-
- FlipperKit/FKPortForwarding (0.201.0):
42-
- CocoaAsyncSocket (~> 7.6)
43-
- Flipper-PeerTalk (~> 0.0.4)
44-
- FlipperKit/FlipperKitHighlightOverlay (0.201.0)
45-
- FlipperKit/FlipperKitLayoutHelpers (0.201.0):
46-
- FlipperKit/Core
47-
- FlipperKit/FlipperKitHighlightOverlay
48-
- FlipperKit/FlipperKitLayoutTextSearchable
49-
- FlipperKit/FlipperKitLayoutIOSDescriptors (0.201.0):
50-
- FlipperKit/Core
51-
- FlipperKit/FlipperKitHighlightOverlay
52-
- FlipperKit/FlipperKitLayoutHelpers
53-
- FlipperKit/FlipperKitLayoutPlugin (0.201.0):
54-
- FlipperKit/Core
55-
- FlipperKit/FlipperKitHighlightOverlay
56-
- FlipperKit/FlipperKitLayoutHelpers
57-
- FlipperKit/FlipperKitLayoutIOSDescriptors
58-
- FlipperKit/FlipperKitLayoutTextSearchable
59-
- FlipperKit/FlipperKitLayoutTextSearchable (0.201.0)
60-
- FlipperKit/FlipperKitNetworkPlugin (0.201.0):
61-
- FlipperKit/Core
62-
- FlipperKit/FlipperKitReactPlugin (0.201.0):
63-
- FlipperKit/Core
64-
- FlipperKit/FlipperKitUserDefaultsPlugin (0.201.0):
65-
- FlipperKit/Core
66-
- FlipperKit/SKIOSNetworkPlugin (0.201.0):
67-
- FlipperKit/Core
68-
- FlipperKit/FlipperKitNetworkPlugin
6912
- fmt (6.2.1)
7013
- glog (0.3.5)
7114
- hermes-engine (0.73.5):
7215
- hermes-engine/Pre-built (= 0.73.5)
7316
- hermes-engine/Pre-built (0.73.5)
7417
- libevent (2.1.12)
75-
- OpenSSL-Universal (1.1.1100)
7618
- PurchasesHybridCommon (10.2.0):
7719
- RevenueCat (= 4.39.0)
7820
- PurchasesHybridCommonUI (10.2.0):
@@ -1121,10 +1063,10 @@ PODS:
11211063
- RevenueCat (4.39.0)
11221064
- RevenueCatUI (4.39.0):
11231065
- RevenueCat (= 4.39.0)
1124-
- RNPaywalls (7.23.0):
1066+
- RNPaywalls (7.24.0):
11251067
- PurchasesHybridCommonUI (= 10.2.0)
11261068
- React-Core
1127-
- RNPurchases (7.23.0):
1069+
- RNPurchases (7.24.0):
11281070
- PurchasesHybridCommon (= 10.2.0)
11291071
- React-Core
11301072
- RNScreens (3.29.0):
@@ -1139,30 +1081,9 @@ DEPENDENCIES:
11391081
- DoubleConversion (from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`)
11401082
- FBLazyVector (from `../node_modules/react-native/Libraries/FBLazyVector`)
11411083
- FBReactNativeSpec (from `../node_modules/react-native/React/FBReactNativeSpec`)
1142-
- Flipper (= 0.201.0)
1143-
- Flipper-Boost-iOSX (= 1.76.0.1.11)
1144-
- Flipper-DoubleConversion (= 3.2.0.1)
1145-
- Flipper-Fmt (= 7.1.7)
1146-
- Flipper-Folly (= 2.6.10)
1147-
- Flipper-Glog (= 0.5.0.5)
1148-
- Flipper-PeerTalk (= 0.0.4)
1149-
- FlipperKit (= 0.201.0)
1150-
- FlipperKit/Core (= 0.201.0)
1151-
- FlipperKit/CppBridge (= 0.201.0)
1152-
- FlipperKit/FBCxxFollyDynamicConvert (= 0.201.0)
1153-
- FlipperKit/FBDefines (= 0.201.0)
1154-
- FlipperKit/FKPortForwarding (= 0.201.0)
1155-
- FlipperKit/FlipperKitHighlightOverlay (= 0.201.0)
1156-
- FlipperKit/FlipperKitLayoutPlugin (= 0.201.0)
1157-
- FlipperKit/FlipperKitLayoutTextSearchable (= 0.201.0)
1158-
- FlipperKit/FlipperKitNetworkPlugin (= 0.201.0)
1159-
- FlipperKit/FlipperKitReactPlugin (= 0.201.0)
1160-
- FlipperKit/FlipperKitUserDefaultsPlugin (= 0.201.0)
1161-
- FlipperKit/SKIOSNetworkPlugin (= 0.201.0)
11621084
- glog (from `../node_modules/react-native/third-party-podspecs/glog.podspec`)
11631085
- hermes-engine (from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`)
11641086
- libevent (~> 2.1.12)
1165-
- OpenSSL-Universal (= 1.1.1100)
11661087
- RCT-Folly (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)
11671088
- RCT-Folly/Fabric (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)
11681089
- RCTRequired (from `../node_modules/react-native/Libraries/RCTRequired`)
@@ -1171,7 +1092,6 @@ DEPENDENCIES:
11711092
- React-callinvoker (from `../node_modules/react-native/ReactCommon/callinvoker`)
11721093
- React-Codegen (from `build/generated/ios`)
11731094
- React-Core (from `../node_modules/react-native/`)
1174-
- React-Core/DevSupport (from `../node_modules/react-native/`)
11751095
- React-Core/RCTWebSocket (from `../node_modules/react-native/`)
11761096
- React-CoreModules (from `../node_modules/react-native/React/CoreModules`)
11771097
- React-cxxreact (from `../node_modules/react-native/ReactCommon/cxxreact`)
@@ -1215,18 +1135,8 @@ DEPENDENCIES:
12151135

12161136
SPEC REPOS:
12171137
trunk:
1218-
- CocoaAsyncSocket
1219-
- Flipper
1220-
- Flipper-Boost-iOSX
1221-
- Flipper-DoubleConversion
1222-
- Flipper-Fmt
1223-
- Flipper-Folly
1224-
- Flipper-Glog
1225-
- Flipper-PeerTalk
1226-
- FlipperKit
12271138
- fmt
12281139
- libevent
1229-
- OpenSSL-Universal
12301140
- PurchasesHybridCommon
12311141
- PurchasesHybridCommonUI
12321142
- RevenueCat
@@ -1342,23 +1252,13 @@ EXTERNAL SOURCES:
13421252

13431253
SPEC CHECKSUMS:
13441254
boost: d3f49c53809116a5d38da093a8aa78bf551aed09
1345-
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
13461255
DoubleConversion: fea03f2699887d960129cc54bba7e52542b6f953
13471256
FBLazyVector: 56e0e498dbb513b96c40bac6284729ba4e62672d
13481257
FBReactNativeSpec: 146c741a3f40361f6bc13a4ba284678cbedb5881
1349-
Flipper: c7a0093234c4bdd456e363f2f19b2e4b27652d44
1350-
Flipper-Boost-iOSX: fd1e2b8cbef7e662a122412d7ac5f5bea715403c
1351-
Flipper-DoubleConversion: 2dc99b02f658daf147069aad9dbd29d8feb06d30
1352-
Flipper-Fmt: 60cbdd92fc254826e61d669a5d87ef7015396a9b
1353-
Flipper-Folly: 584845625005ff068a6ebf41f857f468decd26b3
1354-
Flipper-Glog: 70c50ce58ddaf67dc35180db05f191692570f446
1355-
Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9
1356-
FlipperKit: 37525a5d056ef9b93d1578e04bc3ea1de940094f
13571258
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
13581259
glog: c5d68082e772fa1c511173d6b30a9de2c05a69a2
13591260
hermes-engine: 1d1835b2cc54c381909d94d1b3c8e0a2f1a94a0e
13601261
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
1361-
OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c
13621262
PurchasesHybridCommon: f161942f40eb37372c78d7c6524254b0b32ac752
13631263
PurchasesHybridCommonUI: a320ce797a44d3f4c38becf7d1ddb519f1654a88
13641264
RCT-Folly: 7169b2b1c44399c76a47b5deaaba715eeeb476c0
@@ -1405,12 +1305,12 @@ SPEC CHECKSUMS:
14051305
ReactCommon: 2947b0bffd82ea0e58ca7928881152d4c6dae9af
14061306
RevenueCat: b552a07693b061ff7ea42c8c224f0613755aafe1
14071307
RevenueCatUI: b79724edfb0291eed4cc6172f6d7341d22301c7e
1408-
RNPaywalls: 7596731626dd6043c35cb7ae2c9965fd4d012f29
1409-
RNPurchases: 6348b645f638d22cd8a83563fa6a07bc7853ed84
1308+
RNPaywalls: be765980de2f3cdca23feabe3d81c40b2de8852f
1309+
RNPurchases: 4ebeacb9d039c1c6095467559499a7b90ab3c4eb
14101310
RNScreens: 17e2f657f1b09a71ec3c821368a04acbb7ebcb46
14111311
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
14121312
Yoga: a716eea57d0d3430219c0a5a233e1e93ee931eb7
14131313

1414-
PODFILE CHECKSUM: ab476acbcac920954d425ba29607a6198963789b
1314+
PODFILE CHECKSUM: ef31637b966dabf84533f91f817cd6515b22cbe8
14151315

14161316
COCOAPODS: 1.15.2

0 commit comments

Comments
 (0)