refactor: inject utils filesystem to update flow

Author: mlataza

cmd/agent_smith/main.go

@@ -66,7 +66,7 @@ func main() {
 		return
 	}
 
-	updateContext, err := newUpdateContext(os.Args[1:], sys, domain, svcMgr)
+	updateContext, err := newUpdateContext(os.Args[1:], sys, domain, svcMgr, fs)
 	if err == nil {
 		// Run update routine
 		runUpdate(updateContext)

cmd/agent_smith/update.go

@@ -50,7 +50,7 @@ func runUpdate(params *updateContext) {
 
 	// Read and parse the config file
 	configFilePath := pathsData.ConfigFilePath
-	configFileBytes, err := os.ReadFile(configFilePath)
+	configFileBytes, err := params.FS.ReadFile(configFilePath)
 	if err != nil {
 		logger.Error("Failed to load config", "error", err)
 		return
@@ -76,7 +76,7 @@ func runUpdate(params *updateContext) {
 		return
 	}
 
-	err = os.WriteFile(configFilePath, configBytes, utils.DefaultFileMod)
+	err = params.FS.WriteFile(configFilePath, configBytes, utils.DefaultFileMod)
 	if err != nil {
 		logger.Error("Failed to save config", "error", err)
 		return
@@ -85,20 +85,20 @@ func runUpdate(params *updateContext) {
 	logger.Info("Configuration successfully updated", "path", configFilePath)
 
 	// Copy the agent executable
-	execFilePath, err := os.Executable()
+	execFilePath, err := params.FS.Executable()
 	if err != nil {
 		logger.Error("Failed to get executable", "error", err)
 		return
 	}
 
-	execFileBytes, err := os.ReadFile(execFilePath)
+	execFileBytes, err := params.FS.ReadFile(execFilePath)
 	if err != nil {
 		logger.Error("Failed to read executable file", "error", err)
 		return
 	}
 
 	agentExecutablePath := pathsData.AgentExecutablePath
-	err = os.WriteFile(agentExecutablePath, execFileBytes, utils.DefaultExecutableFileMod)
+	err = params.FS.WriteFile(agentExecutablePath, execFileBytes, utils.DefaultExecutableFileMod)
 	if err != nil {
 		logger.Error("Failed to create agent executable", "error", err)
 		return

cmd/agent_smith/update_context.go

@@ -22,9 +22,10 @@ type updateContext struct {
 	Domain agent.DomainInfoProvider
 
 	ServiceManager service.ServiceManager
+	FS             utils.FileSystem
 }
 
-func newUpdateContext(args []string, sys agent.SystemInfoProvider, domain agent.DomainInfoProvider, svcMgr service.ServiceManager) (*updateContext, error) {
+func newUpdateContext(args []string, sys agent.SystemInfoProvider, domain agent.DomainInfoProvider, svcMgr service.ServiceManager, fsys utils.FileSystem) (*updateContext, error) {
 	var params updateContext
 
 	fs := flag.NewFlagSet("config", flag.ContinueOnError)
@@ -56,6 +57,7 @@ func newUpdateContext(args []string, sys agent.SystemInfoProvider, domain agent.
 	params.Sys = sys
 	params.Domain = domain
 	params.ServiceManager = svcMgr
+	params.FS = fsys
 
 	return &params, nil
 }

cmd/agent_smith/update_context_test.go

@@ -8,7 +8,7 @@ import (
 func TestNewUpdateContext(t *testing.T) {
 	orgId := "test123"
 
-	result, _ := newUpdateContext([]string{"--org-id", orgId, "--update"}, nil, nil, nil)
+	result, _ := newUpdateContext([]string{"--org-id", orgId, "--update"}, nil, nil, nil, nil)
 
 	if result.OrgId != orgId {
 		t.Errorf("expected %v, got %v", orgId, result.OrgId)
@@ -37,7 +37,7 @@ func TestNewUpdateContext(t *testing.T) {
 	}
 
 	for _, errorTest := range errorTests {
-		_, err := newUpdateContext(errorTest.args, nil, nil, nil)
+		_, err := newUpdateContext(errorTest.args, nil, nil, nil, nil)
 
 		if err == nil || !strings.Contains(err.Error(), errorTest.message) {
 			t.Errorf("expected error %s, got %v", errorTest.message, err.Error())