refactor: default constants and validation

Author: mlataza

cmd/agent_smith/config.go

@@ -22,16 +22,17 @@ type fetchConfigurationResponse struct {
 }
 
 func validateConfiguration(device agent.Device) error {
-	required := map[string]string{
-		"device_id":          device.DeviceId,
-		"rewst_engine_host":  device.RewstEngineHost,
-		"shared_access_key":  device.SharedAccessKey,
-		"azure_iot_hub_host": device.AzureIotHubHost,
-	}
-	for field, value := range required {
-		if value == "" {
-			return fmt.Errorf("missing required field: %s", field)
-		}
+	if device.DeviceId == "" {
+		return fmt.Errorf("missing required field: device_id")
+	}
+	if device.RewstEngineHost == "" {
+		return fmt.Errorf("missing required field: rewst_engine_host")
+	}
+	if device.SharedAccessKey == "" {
+		return fmt.Errorf("missing required field: shared_access_key")
+	}
+	if device.AzureIotHubHost == "" {
+		return fmt.Errorf("missing required field: azure_iot_hub_host")
 	}
 	return nil
 }

cmd/agent_smith/service.go

@@ -112,7 +112,11 @@ func (svc *serviceContext) Execute(
 			},
 		)
 		runner := agent.NewAutoUpdateRunner(
-			logger, updater, agent.DefaultUpdateInterval(), agent.DefaultMaxRetries(), agent.DefaultBaseBackoff(),
+			logger,
+			updater,
+			agent.DefaultUpdateInterval(),
+			agent.DefaultMaxRetries(),
+			agent.DefaultBaseBackoff(),
 		)
 		runner.Start()
 		defer runner.Stop()

internal/agent/updater.go

@@ -44,6 +44,12 @@ var baseBackoffStr = ""
 // Example: -ldflags "-X github.com/RewstApp/agent-smith-go/internal/agent.maxRetriesStr=3"
 var maxRetriesStr = ""
 
+const (
+	defaultUpdateInterval = 48 * time.Hour
+	defaultBaseBackoff    = 5 * time.Minute
+	defaultMaxRetries     = 5
+)
+
 // DefaultUpdateInterval returns the auto-update check interval.
 // Uses updateIntervalStr if set via ldflags, otherwise defaults to 48 hours.
 func DefaultUpdateInterval() time.Duration {
@@ -52,7 +58,7 @@ func DefaultUpdateInterval() time.Duration {
 			return d
 		}
 	}
-	return 48 * time.Hour
+	return defaultUpdateInterval
 }
 
 // DefaultBaseBackoff returns the base backoff duration for update retries.
@@ -63,7 +69,7 @@ func DefaultBaseBackoff() time.Duration {
 			return d
 		}
 	}
-	return 5 * time.Minute
+	return defaultBaseBackoff
 }
 
 // DefaultMaxRetries returns the maximum number of update retry attempts.
@@ -75,7 +81,7 @@ func DefaultMaxRetries() int {
 			return n
 		}
 	}
-	return 5
+	return defaultMaxRetries
 }
 
 type RunCommandFunc = func(path string, args []string) error