Bug: `Edit Table` and `Format Table` affect the line below the table

[jbridgy]

The commands Edit Table and Format Table incorrectly modify the line immediately following the table. If the line is empty, it is deleted. Otherwise it is absorbed into the leftmost cell of a newly added row.

Example

Initial Situation:

| Header 1       | Header 2       |
|----------------|----------------|
| Row 1 Column 1 | Row 1 Column 2 |


Non-empty line 1 below table.
Non-empty line 2 below table.

Situation after executing Format Table four times:

| Header 1                      | Header 2       |
|-------------------------------|----------------|
| Row 1 Column 1                | Row 1 Column 2 |
| Non-empty line 1 below table. |                |
| Non-empty line 2 below table. |                |

This bug occurs with Markdown Monster 4.0.3.4, but if I remember correctly, it exists already for a while, maybe already with version 3.x.

[RickStrahl]

Looks like there are two bugs here:

1. Format removes trailing linebreak
2. Table detection doesn't stop when it reaches a non table line

1. is the main issue - I thought that was addressed in a previous fix but apparently not.

Technically 2. is invalid markdown (as seen by the fact that the renderer breaks with table rendering on that), but it still shouldn't try to pull that into the table - that makes a hell of a lot wronger 😄

[RickStrahl]

Fixed in 4.1.3.5.

There are few minor operational changed:

• Table no longer is left fully selected after operation
• Cursor stays in previous position if possible

[jbridgy]

Thanks for the quick fix! 👍

Regarding cursor positioning, I have two suggestions:

1. Format Table: The cursor currently jumps below the table after execution. Ideally, the cursor position should remain unchanged.

2. Edit Table: The cursor currently stays where it was before opening the editor, which is fine if the user exited without pressing Embed Table or did not move the cursor within the table editor.

   However, if the user did press Embed Table, I would expect the cursor to return to its position immediately before pressing the button, or at least remain within the same cell.

   Note: Invoking Edit Table followed by Embed Table without making changes is equivalent to invoking Format Table.

[RickStrahl]

This should be fixed as a side effect of #1260. Both Edit and Format Table now leave the cursor position in its original row and column.

Note this is based on original coordinates - if the content changes the old position will not stay in sync with the new content but go to the previous position regardless whereever that may be. In some cases that might even be outside of the table altogether if content was removed off the end.

However the overall behavior much more often than not gets you to the location you'll want to be after insertion.