Skip to content

Commit f66c83a

Browse files
Kamal Sai DevarapalliKamal Sai Devarapalli
authored andcommitted
fix: resolve line length issues in usermanagement service views
- Wrap EventStreamMonitor error class instantiations in parentheses - Fix lines exceeding 79-character limit in fetch_user.py and remove_user.py - Improve code readability while maintaining PEP 8 compliance
1 parent 34f88d2 commit f66c83a

File tree

2 files changed

+25
-15
lines changed

2 files changed

+25
-15
lines changed

services/usermanagement/app/views/fetch_user.py

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ def get_user_info(userid):
8181
messagedata="Retrieved User"
8282
)
8383
if len(custom_user_response_body.keys()) <= 0:
84-
invalid_req_err_res = EventStreamMonitorInternalServerError(
85-
message="Get User Response creation Failed",
86-
logger_instance=user_management_logger,
84+
invalid_req_err_res = (
85+
EventStreamMonitorInternalServerError(
86+
message="Get User Response creation Failed",
87+
logger_instance=user_management_logger,
88+
)
8789
)
8890
return invalid_req_err_res.send_response_to_client()
8991
get_usr_response = make_response(custom_user_response_body)
@@ -127,9 +129,11 @@ def get_user_info(userid):
127129
UsersModel
128130
).get(userid)
129131
if get_user_instance is None:
130-
usr_not_found_err_res = EventStreamMonitorNotFoundError(
131-
message="Retrieved user doesn't exists",
132-
logger_instance=user_management_logger,
132+
usr_not_found_err_res = (
133+
EventStreamMonitorNotFoundError(
134+
message="Retrieved user doesn't exists",
135+
logger_instance=user_management_logger,
136+
)
133137
)
134138
return usr_not_found_err_res.send_response_to_client()
135139
except sqlalchemy.exc.NoResultFound as ex:
@@ -194,9 +198,11 @@ def get_user_info(userid):
194198
get_user_instance
195199
)
196200
if len(get_user_instance.keys()) <= 0:
197-
invalid_req_err_res = EventStreamMonitorInternalServerError(
198-
message="Get User Response creation Failed",
199-
logger_instance=user_management_logger,
201+
invalid_req_err_res = (
202+
EventStreamMonitorInternalServerError(
203+
message="Get User Response creation Failed",
204+
logger_instance=user_management_logger,
205+
)
200206
)
201207
app_manager_db_obj.close_session(
202208
session_instance=get_user_management_session

services/usermanagement/app/views/remove_user.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,11 @@ def deregister_user(userid):
8888
UsersModel
8989
).get(userid)
9090
if del_user_instance is None:
91-
usr_not_found_err_res = EventStreamMonitorNotFoundError(
92-
message="Retrieved user doesn't exists",
93-
logger_instance=user_management_logger,
91+
usr_not_found_err_res = (
92+
EventStreamMonitorNotFoundError(
93+
message="Retrieved user doesn't exists",
94+
logger_instance=user_management_logger,
95+
)
9496
)
9597
return usr_not_found_err_res.send_response_to_client()
9698
except sqlalchemy.exc.NoResultFound as ex:
@@ -214,9 +216,11 @@ def deregister_user(userid):
214216
"Unexpected error occurred :: %s\tLine No:: %s",
215217
ex, sys.exc_info()[2].tb_lineno
216218
)
217-
internal_err_res = EventStreamMonitorInternalServerError(
218-
message="Internal Server Error",
219-
logger_instance=user_management_logger,
219+
internal_err_res = (
220+
EventStreamMonitorInternalServerError(
221+
message="Internal Server Error",
222+
logger_instance=user_management_logger,
223+
)
220224
)
221225
return internal_err_res.send_response_to_client()
222226
else:

0 commit comments

Comments
 (0)