Skip to content

EntityGithubInsightsReadmeCard does not handle relative links #2134

@lazytesting

Description

@lazytesting

Expected Behavior

Relative links in the readme.md should work. This means that they lead to an url in this format:
https://github.com/{org}/{repo}/{file}

Current Behavior

Currently the links don't work as they link to https://api.github.com/{org}/{repo}/{file} (api subdomain)

Steps to Reproduce

Example: in the root folder of the repo I have readme.md
readme.md has a relative link to /folder/more-info.md

In that case the link in backstage resolves to: https://api.github.com/organisation/repo/folder.md

Possible Solution

Context

  • deeplinks in readme files are not working

Your Environment

  • @backstage/plugin-catalog-react version: 1.16.1
  • @backstage/integration version: version 1.2.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions