Missed another mut: contains_range doesn't require &mut

Author: Dr-Emann

croaring/src/bitmap/imp.rs

@@ -202,18 +202,18 @@ impl Bitmap {
     /// ```
     /// use croaring::Bitmap;
     ///
-    /// let mut bitmap = Bitmap::create();
-    /// bitmap.add_range((1..3));
+    /// let bitmap = Bitmap::of(&[1, 2]);
     /// assert!(bitmap.contains_range((1..3)));
     ///
+    /// let mut bitmap = bitmap.clone();
     /// bitmap.add(u32::MAX - 1);
     /// bitmap.add(u32::MAX);
     /// assert!(bitmap.contains_range((u32::MAX - 1)..=u32::MAX))
     /// ```
     #[inline]
-    pub fn contains_range<R: RangeBounds<u32>>(&mut self, range: R) -> bool {
+    pub fn contains_range<R: RangeBounds<u32>>(&self, range: R) -> bool {
         let (start, end) = range_to_exclusive(range);
-        unsafe { ffi::roaring_bitmap_contains_range(&mut self.bitmap, start, end) }
+        unsafe { ffi::roaring_bitmap_contains_range(&self.bitmap, start, end) }
     }
 
     /// Empties the bitmap

croaring/src/bitmap/ops.rs

@@ -133,7 +133,7 @@ impl<'a> BitAnd<&'a Bitmap> for Bitmap {
     /// ```
     #[inline]
     fn bitand(self, other: &'a Bitmap) -> Bitmap {
-        self.and(&other)
+        self.and(other)
     }
 }
 
@@ -161,7 +161,7 @@ impl<'a, 'b> BitAnd<&'a Bitmap> for &'b Bitmap {
     /// ```
     #[inline]
     fn bitand(self, other: &'a Bitmap) -> Bitmap {
-        self.and(&other)
+        self.and(other)
     }
 }
 
@@ -256,7 +256,7 @@ impl<'a> BitOr<&'a Bitmap> for Bitmap {
     /// ```
     #[inline]
     fn bitor(self, other: &'a Bitmap) -> Bitmap {
-        self.or(&other)
+        self.or(other)
     }
 }
 
@@ -284,7 +284,7 @@ impl<'a, 'b> BitOr<&'a Bitmap> for &'b Bitmap {
     /// ```
     #[inline]
     fn bitor(self, other: &'a Bitmap) -> Bitmap {
-        self.or(&other)
+        self.or(other)
     }
 }
 
@@ -372,7 +372,7 @@ impl<'a> BitXor<&'a Bitmap> for Bitmap {
     /// ```
     #[inline]
     fn bitxor(self, other: &'a Bitmap) -> Bitmap {
-        self.xor(&other)
+        self.xor(other)
     }
 }
 
@@ -403,7 +403,7 @@ impl<'a, 'b> BitXor<&'a Bitmap> for &'b Bitmap {
     /// ```
     #[inline]
     fn bitxor(self, other: &'a Bitmap) -> Bitmap {
-        self.xor(&other)
+        self.xor(other)
     }
 }
 
@@ -498,7 +498,7 @@ impl<'a> Sub<&'a Bitmap> for Bitmap {
     /// ```
     #[inline]
     fn sub(self, other: &'a Bitmap) -> Bitmap {
-        self.andnot(&other)
+        self.andnot(other)
     }
 }
 
@@ -531,7 +531,7 @@ impl<'a, 'b> Sub<&'a Bitmap> for &'b Bitmap {
     /// ```
     #[inline]
     fn sub(self, other: &'a Bitmap) -> Bitmap {
-        self.andnot(&other)
+        self.andnot(other)
     }
 }
 

croaring/src/treemap/imp.rs

@@ -223,7 +223,7 @@ impl Treemap {
         for (key, bitmap) in &self.map {
             other
                 .map
-                .get(&key)
+                .get(key)
                 .map(|other_bitmap| treemap.map.insert(*key, bitmap.and(other_bitmap)));
         }
 

croaring/src/treemap/ops.rs

@@ -78,7 +78,7 @@ impl<'a> BitAnd<&'a Treemap> for Treemap {
     /// ```
     #[inline]
     fn bitand(self, other: &'a Treemap) -> Treemap {
-        self.and(&other)
+        self.and(other)
     }
 }
 
@@ -106,7 +106,7 @@ impl<'a, 'b> BitAnd<&'a Treemap> for &'b Treemap {
     /// ```
     #[inline]
     fn bitand(self, other: &'a Treemap) -> Treemap {
-        self.and(&other)
+        self.and(other)
     }
 }
 
@@ -201,7 +201,7 @@ impl<'a> BitOr<&'a Treemap> for Treemap {
     /// ```
     #[inline]
     fn bitor(self, other: &'a Treemap) -> Treemap {
-        self.or(&other)
+        self.or(other)
     }
 }
 
@@ -229,7 +229,7 @@ impl<'a, 'b> BitOr<&'a Treemap> for &'b Treemap {
     /// ```
     #[inline]
     fn bitor(self, other: &'a Treemap) -> Treemap {
-        self.or(&other)
+        self.or(other)
     }
 }
 
@@ -319,7 +319,7 @@ impl<'a> BitXor<&'a Treemap> for Treemap {
     /// ```
     #[inline]
     fn bitxor(self, other: &'a Treemap) -> Treemap {
-        self.xor(&other)
+        self.xor(other)
     }
 }
 
@@ -351,7 +351,7 @@ impl<'a, 'b> BitXor<&'a Treemap> for &'b Treemap {
     /// ```
     #[inline]
     fn bitxor(self, other: &'a Treemap) -> Treemap {
-        self.xor(&other)
+        self.xor(other)
     }
 }
 
@@ -449,7 +449,7 @@ impl<'a> Sub<&'a Treemap> for Treemap {
     /// ```
     #[inline]
     fn sub(self, other: &'a Treemap) -> Treemap {
-        self.andnot(&other)
+        self.andnot(other)
     }
 }
 
@@ -483,7 +483,7 @@ impl<'a, 'b> Sub<&'a Treemap> for &'b Treemap {
     /// ```
     #[inline]
     fn sub(self, other: &'a Treemap) -> Treemap {
-        self.andnot(&other)
+        self.andnot(other)
     }
 }