fixing various and and or issues

Author: lemire

arraycontainer.go

@@ -417,8 +417,10 @@ func (ac *arrayContainer) iorArray(value2 *arrayContainer) container {
 func (ac *arrayContainer) iorBitmap(bc2 *bitmapContainer) container {
 	bc1 := ac.toBitmapContainer()
 	bc1.iorBitmap(bc2)
-	*ac = *newArrayContainerFromBitmap(bc1)
-	return ac
+	// DO NOT DO THIS:
+	// *ac = *newArrayContainerFromBitmap(bc1)
+	// This will create gigantic array containers in the case of repeated calls to iorBitmap.
+	return bc1
 }
 
 func (ac *arrayContainer) iorRun16(rc *runContainer16) container {

roaring_test.go

@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"math"
 	"math/rand"
+	randv2 "math/rand/v2"
+
 	"strconv"
 	"testing"
 
@@ -13,6 +15,39 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func TestSplitter_BrokeBm(t *testing.T) {
+	bm1 := NewBitmap()
+	bm2 := NewBitmap()
+	bm3 := NewBitmap()
+
+	for i := 0; i < 2000; i++ {
+		bm1.Add(uint32(i))
+		bm2.Add(uint32(i + 2000))
+		bm3.Add(uint32(i * 4000))
+	}
+	res := FastOr(bm1, bm2, bm3)
+
+	require.NoError(t, res.Validate())
+
+	return
+}
+
+func TestRoaring_AndMask(t *testing.T) {
+	r := randv2.New(randv2.NewPCG(13, 22)) // reproducible random
+
+	rb := NewBitmap()
+	for j := 0; j < 1_000_000; j++ {
+		rb.Add(r.Uint32N(10_000_000) + 5_000_000)
+	}
+
+	mask := New()
+	mask.AddRange(1, 10_000_001)
+	mask.And(rb)
+
+	err := mask.Validate()
+	require.NoError(t, err) // this fails
+}
+
 func TestIssue440(t *testing.T) {
 	a := NewBitmap()
 	a.AddMany([]uint32{1, 2, 3})

runcontainer.go

@@ -1887,9 +1887,13 @@ func (rc *runContainer16) iand(a container) container {
 	case *runContainer16:
 		return rc.inplaceIntersect(c)
 	case *arrayContainer:
+		// inplace intersection with array is not supported
+		// It is likely not very useful either.
 		return rc.andArray(c)
 	case *bitmapContainer:
-		return rc.iandBitmapContainer(c)
+		// inplace intersection with bitmap is not supported
+		// It is very difficult to do this inplace and likely not useful.
+		return rc.andBitmapContainer(c)
 	}
 	panic("unsupported container type")
 }
@@ -1900,12 +1904,6 @@ func (rc *runContainer16) inplaceIntersect(rc2 *runContainer16) container {
 	return rc
 }
 
-func (rc *runContainer16) iandBitmapContainer(bc *bitmapContainer) container {
-	isect := rc.andBitmapContainer(bc)
-	*rc = *newRunContainer16FromContainer(isect)
-	return rc
-}
-
 func (rc *runContainer16) andArray(ac *arrayContainer) container {
 	if len(rc.iv) == 0 {
 		return newArrayContainer()