Merge pull request #111 from maciej/par_and_fix

Fixes an issue with ParAnd producing bitmaps with empty containers

Author: lemire

parallel.go

@@ -170,7 +170,9 @@ func appenderRoutine(bitmapChan chan<- *Bitmap, resultChan <-chan keyedContainer
 		},
 	}
 	for i := range keys {
-		answer.highlowcontainer.appendContainer(keys[i], containers[i], false)
+		if containers[i] != nil { // in case a resulting container was empty, see ParAnd function
+			answer.highlowcontainer.appendContainer(keys[i], containers[i], false)
+		}
 	}
 
 	bitmapChan <- answer
@@ -274,8 +276,17 @@ func ParAnd(parallelism int, bitmaps ...*Bitmap) *Bitmap {
 		for input := range inputChan {
 			c := input.containers[0].and(input.containers[1])
 			for _, next := range input.containers[2:] {
+				if c.getCardinality() == 0 {
+					break
+				}
 				c = c.iand(next)
 			}
+
+			// Send a nil explicitly if the result of the intersection is an empty container
+			if c.getCardinality() == 0 {
+				c = nil
+			}
+
 			kx := keyedContainer{
 				input.key,
 				c,

parallel_test.go

@@ -46,6 +46,15 @@ func TestParAggregationsOneEmpty(t *testing.T) {
 	})
 }
 
+func TestParAggregationsDisjointSetIntersection(t *testing.T) {
+	Convey("Par", t, func() {
+		rb1 := BitmapOf(1)
+		rb2 := BitmapOf(2)
+
+		So(ParAnd(0, rb1, rb2).Stats().Containers, ShouldEqual, 0)
+	})
+}
+
 func TestParAggregationsReversed3COW(t *testing.T) {
 	Convey("Par", t, func() {
 		rb1 := NewBitmap()