Implement Memoize<T>

Author: staabm

src/Reflection/Adapter/ReflectionEnum.php

@@ -18,6 +18,7 @@
 use Roave\BetterReflection\Reflection\ReflectionMethod as BetterReflectionMethod;
 use Roave\BetterReflection\Reflection\ReflectionProperty as BetterReflectionProperty;
 use Roave\BetterReflection\Util\FileHelper;
+use Roave\BetterReflection\Util\Memoize;
 use ValueError;
 
 use function array_combine;
@@ -33,12 +34,27 @@
  */
 final class ReflectionEnum extends CoreReflectionEnum
 {
-    /** @var list<ReflectionEnumUnitCase>|list<ReflectionEnumBackedCase>|null */
-    private array|null $cases = null;
+    /** @var Memoize<list<ReflectionEnumUnitCase>|list<ReflectionEnumBackedCase>> */
+    private Memoize $cases;
 
     public function __construct(private BetterReflectionEnum $betterReflectionEnum)
     {
         unset($this->name);
+
+        $this->cases = new Memoize(function() {
+            $isBacked = $this->betterReflectionEnum->isBacked();
+            $cases    = $this->betterReflectionEnum->getCases();
+
+            $mappedCases = [];
+            foreach ($cases as $case) {
+                if ($isBacked) {
+                    $mappedCases[] = new ReflectionEnumBackedCase($case);
+                } else {
+                    $mappedCases[] = new ReflectionEnumUnitCase($case);
+                }
+            }
+            return $mappedCases;
+        });
     }
 
     /** @return non-empty-string */
@@ -533,23 +549,7 @@ public function getCase(string $name): ReflectionEnumUnitCase|ReflectionEnumBack
     /** @return list<ReflectionEnumUnitCase>|list<ReflectionEnumBackedCase> */
     public function getCases(): array
     {
-        if ($this->cases !== null) {
-            return $this->cases;
-        }
-
-        $isBacked = $this->betterReflectionEnum->isBacked();
-        $cases    = $this->betterReflectionEnum->getCases();
-
-        $mappedCases = [];
-        foreach ($cases as $case) {
-            if ($isBacked) {
-                $mappedCases[] = new ReflectionEnumBackedCase($case);
-            } else {
-                $mappedCases[] = new ReflectionEnumUnitCase($case);
-            }
-        }
-
-        return $this->cases = $mappedCases;
+        return $this->cases->memoize();
     }
 
     public function isBacked(): bool

src/Util/Memoize.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Roave\BetterReflection\Util;
+
+/** @template T */
+final class Memoize {
+    /**
+     * @var T
+     * @psalm-suppress PossiblyNullPropertyAssignmentValue
+     */
+    private mixed $cached = null;
+
+    /**
+     * @var callable(): T
+     */
+    private  $fn;
+
+    /** @param callable(): T $fn */
+    public function __construct(callable $fn)
+    {
+        $this->fn = $fn;
+    }
+
+    /**
+     * @return T
+     */
+    public function memoize(): mixed {
+        if ($this->cached === null) {
+            $this->cached = ($this->fn)();
+        }
+        return $this->cached;
+    }
+}